[dm-devel] 答复: Re: [PATCH] libmultipath: fix multipath -q command logic

Hello Hannes, check_daemon() now is only used to determine whether to set/remove queue_if_no_path feature for mapped devices, which you said maybe another issue, we are looking forward for your patch. Thanks, Tang 发件人: Hannes Reinecke 收件人:

[dm-devel] [PATCH 0/9] Additional checks for strace DM ioctl decoder test

Hello. Aside from additional checks themselves, this patchset also contains two notable changes: * Fix for the previous patchset - misplaced comma printing ("dm: Fix comma printing for the case when dm_target_msg structure is inaccessible"). * Update of printstr_ex call, which enables proper

[dm-devel] [PATCH 4/9] tests/ioctl_dm: whitespace

--- tests/ioctl_dm.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/ioctl_dm.c b/tests/ioctl_dm.c index 5f2689c..261983c 100644 --- a/tests/ioctl_dm.c +++ b/tests/ioctl_dm.c @@ -24,7 +24,8 @@ static struct s { } u; } s; -static void init_s(struct

Re: [dm-devel] [PATCH] multipathd: fix issue in 'map $map getprstatus' reply

Please have a review for this patch, hope for your comments. Thanks 发件人: peng.lia...@zte.com.cn 收件人: christophe varoqui , 抄送: zhang.ka...@zte.com.cn, dm-devel@redhat.com, peng liang 日期: 2016-08-04 15:31 主题: [dm-devel]

[dm-devel] 答复: [RFC] unreleased lock after handler failure

Hi, Michael Wang This patch looks well for me, cleanup_lock() should be called without affected by the return value of h->fn(). Regards, Tang 发件人: Michael Wang 收件人: christophe.varo...@opensvc.com, dm-devel@redhat.com, 日期: 2016/10/12 16:11 主题:

[dm-devel] [PATCH 5/9] dm: Fix comma printing for the case when dm_target_msg structure is inaccessible

--- dm.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dm.c b/dm.c index d846233..b1d455c 100644 --- a/dm.c +++ b/dm.c @@ -342,10 +342,12 @@ dm_decode_dm_target_msg(struct tcb *tcp, unsigned long addr, offset + target_msg_message_offs <= ioc->data_size) {

[dm-devel] [PATCH 9/9] tests: Add checks for abbreviated DM ioctl output

--- tests/.gitignore |1 + tests/Makefile.am |2 + tests/ioctl_dm-v.c|2 + tests/ioctl_dm-v.test | 12 tests/ioctl_dm.c | 178 +++-- tests/ioctl_dm.test |2 +- 6 files changed, 160 insertions(+), 37

[dm-devel] [PATCH 6/9] tests/ioctl_dm: overly long string printing checks

--- tests/ioctl_dm.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/ioctl_dm.c b/tests/ioctl_dm.c index 261983c..24232b7 100644 --- a/tests/ioctl_dm.c +++ b/tests/ioctl_dm.c @@ -67,12 +67,12 @@ main(void) init_s(, sizeof(s), offsetof(struct s, u));

[dm-devel] [RFC] unreleased lock after handler failure

Hi, folks While we are testing with the latest multipathd, we encounter issue that once 'del map' failed, all the following operation will show 'error -1 receiving packet' whatever how long the timeout has been set (we have applied the latest fix which make sure the poll will last for 10

[dm-devel] [PATCH] multipath-tools: release lock on handler failure

Inside parse_cmd() the pthread_cleanup_pop() rely on '!r' as the indicator of locked or not, while this will be overwritten if the handler return failed, and the unlock will be missing. This will lead into the situation that all the following operation will trying to hold a lock which will never

Re: [dm-devel] [PATCH] multipath-tools: preload also scsi_dh_hp_sw before run multipathd

On 10/11/2016 03:41 PM, Hannes Reinecke wrote: > On 10/11/2016 02:55 PM, Xose Vazquez Perez wrote: >> Cc: Hannes Reinecke >> Cc: Christophe Varoqui >> Cc: device-mapper development >> Signed-off-by: Xose Vazquez Perez

[dm-devel] [PATCH 7/9] tests: Some additional checks for ioctl_dm test

--- tests/ioctl_dm.c | 505 ++ 1 file changed, 505 insertions(+) diff --git a/tests/ioctl_dm.c b/tests/ioctl_dm.c index 24232b7..0b2c5a7 100644 --- a/tests/ioctl_dm.c +++ b/tests/ioctl_dm.c @@ -2,13 +2,26 @@ #ifdef HAVE_LINUX_DM_IOCTL_H

[dm-devel] [PATCH 2/9] tests: Add check for printing of overlength strings to ioctl_dm test

--- tests/ioctl_dm.c|2 +- tests/ioctl_dm.test |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/ioctl_dm.c b/tests/ioctl_dm.c index 6ad4ea9..0a3bbf4 100644 --- a/tests/ioctl_dm.c +++ b/tests/ioctl_dm.c @@ -77,7 +77,7 @@ main(void) printf("ioctl(-1,

[dm-devel] [PATCH 8/9] tests: Add ioctl_dm to .gitignore

--- tests/.gitignore |1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore index a6d014d..9045117 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -103,6 +103,7 @@ getxxid inet-cmsg ioctl ioctl_block +ioctl_dm ioctl_evdev ioctl_evdev-v ioctl_mtd

Re: [dm-devel] [PATCH] multipath-tools: remove hwhandler when it's alua

On 10/11/2016 08:22 AM, Hannes Reinecke wrote: > Autodetection will only work if the hardware handler is loaded. > If the handler is _not_ loaded autodetection won't work, either. > And if we add this patch multipath will never load the modules, neither. > So we need this functionality as a

Re: [dm-devel] 答复: [RFC] unreleased lock after handler failure

Hi, Tang On 10/12/2016 10:33 AM, tang.jun...@zte.com.cn wrote: > Hi, Michael Wang > > This patch looks well for me, cleanup_lock() should be called without > affectedby the return value of h->fn(). Thanks for the quick respond, I'll submit a formal patch then :-) Regards, Michael Wang > >

Re: [dm-devel] [PATCH] multipathd: fix issue in 'map $map getprstatus' reply

On 10/11/16 20:03, peng.lia...@zte.com.cn wrote: > From: peng liang > > -add missing newline to 'map|multipath $map getprstatus' reply > -use asprintf instead of sprintf > > Signed-off-by: peng liang > --- > multipathd/cli_handlers.c | 14

Re: [dm-devel] [PATCH] multipath-tools: remove hwhandler when it's alua

On 10/11/2016 08:43 AM, Christophe Varoqui wrote: > so Xosé, can you confirm the last introduced hwtable entries don't need the > alua hwhandler : Yes, defined: > - tegile > - nimble No needed/defined: > - nexsan > - nfinidat - NexGen|Pivot3 -- dm-devel mailing list dm-devel@redhat.com

Re: [dm-devel] [PATCH] multipath-tools: preload also scsi_dh_hp_sw before run multipathd

On 10/12/2016 02:43 PM, Hannes Reinecke wrote: > On 10/12/2016 01:37 PM, Xose Vazquez Perez wrote: >> scsi_dh_hp_sw is used also for dec/compaq ESA12000 and RA8000 arrays with >> HSG80 controller. >> And in HP MSA 1000/1500 and EVA 3000/5000, with old firmware. >> > EVA? I sincerely doubt that.

Re: [dm-devel] [PATCH] multipath-tools: add IBM/FlashSystem to hwtable

On 10/07/2016 04:24 PM, Steffen Maier wrote: > You'll notice that we from Linux on s390x have a bit different recommendations > for some of the values (no_path_retry actually depends on whether you have a > cluster software/filesystem that can cope with EIO on last-path-loss. > Currently, > I

Re: [dm-devel] [PATCH] multipath-tools: preload also scsi_dh_hp_sw before run multipathd

On 10/12/2016 01:37 PM, Xose Vazquez Perez wrote: On 10/11/2016 03:41 PM, Hannes Reinecke wrote: On 10/11/2016 02:55 PM, Xose Vazquez Perez wrote: Cc: Hannes Reinecke Cc: Christophe Varoqui Cc: device-mapper development

[dm-devel] [PATCH] multipath-tools: add Xiotech ISE arrays to hwtable

Based on documentation provided by the manufacturer: https://drive.google.com/file/d/0B_B6YmEmO7cDc201a3ZlcmFvUmM Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez ---

Re: [dm-devel] [PATCH] multipath-tools: remove hwhandler when it's alua

On Wed, Oct 12, 2016 at 01:06:10PM +0200, Xose Vazquez Perez wrote: > On 10/11/2016 08:22 AM, Hannes Reinecke wrote: > > > Autodetection will only work if the hardware handler is loaded. > > If the handler is _not_ loaded autodetection won't work, either. > > And if we add this patch multipath

[dm-devel] [PATCH v2] dm raid1: "mirror" target doesn't use all available legs on multiple failures

In case legs of a mirror target fail, any read will cause a new, operational default leg to be selected and the read be resubmitted to it. If that new default leg fails the read too, no other still accessible legs are used to resubmit the read again thus failing the io. Fix by allowing the read