Re: [dm-devel] [PATCH] multipath-tools: release lock on handler failure

2016-10-17 Thread Michael Wang
Dear maintainer, is this patch looks fine to you? Regards, Michael Wang On 10/12/2016 10:54 AM, Michael Wang wrote: > > Inside parse_cmd() the pthread_cleanup_pop() rely on '!r' as the > indicator of locked or not, while this will be overwritten if the > handler return failed, and the unlock wil

Re: [dm-devel] [PATCH] multipath-tools: release lock on handler failure

2016-10-17 Thread Christophe Varoqui
Merged. Thanks. On Mon, Oct 17, 2016 at 10:02 AM, Michael Wang wrote: > Dear maintainer, is this patch looks fine to you? > > Regards, > Michael Wang > > On 10/12/2016 10:54 AM, Michael Wang wrote: > > > > Inside parse_cmd() the pthread_cleanup_pop() rely on '!r' as the > > indicator of locked

Re: [dm-devel] [PATCH] multipath-tools: add VIOLIN arrays to hardware table

2016-10-17 Thread Xose Vazquez Perez
On 10/16/2016 06:56 PM, Hannes Reinecke wrote: >> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c >> index aca46ab..e34032d 100644 >> --- a/libmultipath/hwtable.c >> +++ b/libmultipath/hwtable.c >> @@ -944,6 +944,32 @@ static struct hwentry default_hw[] = { >> .pgpolicy

[dm-devel] [PATCH] multipath-tools: fix DEFAULT values

2016-10-17 Thread Xose Vazquez Perez
replace RR_WEIGHT_NONE with DEFAULT_RR_WEIGHT, and define DEFAULT_FLUSH Cc: Benjamin Marzinski Cc: Hannes Reinecke Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmultipath/defaults.h | 1 + libmultipath/propsel.c | 4 ++-- 2 files changed, 3 in

[dm-devel] [PATCH] multipath-tools: fix DEFAULT values

2016-10-17 Thread Xose Vazquez Perez
replace RR_WEIGHT_NONE with DEFAULT_RR_WEIGHT, and define DEFAULT_FLUSH Cc: Benjamin Marzinski Cc: Hannes Reinecke Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmultipath/defaults.h | 1 + libmultipath/propsel.c | 4 ++-- 2 files changed, 3 in

[dm-devel] [PATCH] multipath-tools: replace static value with default_variable for flush_on_last_del

2016-10-17 Thread Xose Vazquez Perez
Cc: Benjamin Marzinski Cc: Hannes Reinecke Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmultipath/config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libmultipath/config.c b/libmultipath/config.c index a48b8af..92e4deb

Re: [dm-devel] [PATCH] multipath-tools: fix DEFAULT values

2016-10-17 Thread Xose Vazquez Perez
On 10/17/2016 06:32 PM, Xose Vazquez Perez wrote: > replace RR_WEIGHT_NONE with DEFAULT_RR_WEIGHT, and define DEFAULT_FLUSH Sorry, duplicate. Drop one of them. Thank you. > > Cc: Benjamin Marzinski > Cc: Hannes Reinecke > Cc: Christophe Varoqui > Cc: device-mapper development > Signed-off-by

[dm-devel] [PATCH] dm raid: fix activation of exisiting raid4/10 mapped devices

2016-10-17 Thread Heinz Mauelshagen
dm-raid 1.9.0 fails to activate existing RAID4/10 mapped devices created with old superblock format without takeover/reshaping support prior to upstream commit 33e53f06850f44ec9722e08a993ecf8816e447a5. Fix by reverting to the old raid4 layout and basing checks on mddev->new_{level,layout,...} memb

[dm-devel] [PATCH] multipath-tools: clarify no_path_retry in multipath.conf.5

2016-10-17 Thread Xose Vazquez Perez
no_path_retrySpecify what to do when all paths are down. Possible values are: value > 0 number of retries until disable I/O queueing. failfor immediate failure (no I/O queueing). queue for never stop I/O queueing. Similar to queue_if_no_path. See KNOWN ISSUE

[dm-devel] [PATCH] multipath-tools: replace IO by I/O in multipath.conf.5

2016-10-17 Thread Xose Vazquez Perez
to be consistent with the rest of the text. Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- multipath/multipath.conf.5 | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/multipath/multipath.conf.5 b/multipat

[dm-devel] [PATCH 1/3] segment faulty occured in dm_get_status()

2016-10-17 Thread tang . junhui
From: "tang.junhui" Signed-off-by: tang.junhui segment faulty occured in dm_get_status(), the call trace is: -- (gdb) bt 0 0x00338ec328a5 in raise () from /lib64/libc.so.6 1 0x00338ec3400d in abort () from /lib64/libc

[dm-devel] [PATCH 3/3] Treat PATH_TIMEOUT as PATH_DOWN

2016-10-17 Thread tang . junhui
From: "tang.junhui" Treat PATH_TIMEOUT as PATH_DOWN since it is basically the same as PATH_DOWN, except with a different state name. So change it to PATH_DOWN immediately if it is PATH_TIMEOUT according to the method in pathinfo(). After the modification all PATH_TIMEOUTs are equal to PATH_DOWN s

[dm-devel] [PATCH 2/3] access vecs memory outside of locking range in check_path()

2016-10-17 Thread tang . junhui
From: "tang.junhui" there are vecs->mpvec memory accesses outside of locking range in check_path(), the judgments is not necessary since the they has existed in vector_foreach_slot(), so delete them. Signed-off-by: tang.junhui --- multipathd/main.c | 45 ++--