Re: [dm-devel] dm-persistent-data: free sm_metadata on failed create

2016-12-01 Thread Mike Snitzer
Staged for 4.10 inclusion with a revised header, see: https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-4.10=b34af3050734ba53a7afa4f3ab9fe9d6bbfbf802 On Thu, Dec 01 2016 at 5:58am -0500, Edward Thornber wrote: > ack > > On Wed, Nov 30,

Re: [dm-devel] [PATCH] libmultipath: ensure dev_loss_tmo will be update to MAX_DEV_LOSS_TMO if no_path_retry set to queue

2016-12-01 Thread Benjamin Marzinski
On Thu, Dec 01, 2016 at 09:06:14AM +0800, peng.lia...@zte.com.cn wrote: >If fast_io_fail_tmo isn't set, it will be use the DEFAULT_FAST_IO_FAIL >in select_fast_io_fail. > >So, multipath will not run the limited of dev_loss_tmo to 600. Yes, but the kernel will. With your patch

[dm-devel] [PATCH] dm-crypt: reject key strings containing whitespace chars

2016-12-01 Thread Ondrej Kozina
Well, I was wrong. Unfortunately key_string may theoreticaly contain whitespace even after it's processed by dm_split_args(). The dm core driver supports escaping of almost all chars including any whitespace. if uspace passes key in the kernel in format ":32:logon:my_prefix:my\ key" the dm-crypt

Re: [dm-devel] [PATCH] dm-persistent-data: free sm_metadata on failed create

2016-12-01 Thread Edward Thornber
ack On Wed, Nov 30, 2016 at 05:56:14PM -0600, Benjamin Marzinski wrote: > In dm_sm_metadata_create we temporarily change the dm_space_map > operations from ops, whose destroy function deallocates the > sm_metadata, to bootstrap_ops, whose destroy function doesn't. If we > fail in