Re: [dm-devel] [PATCH] libmultipath: increase path product_id/rev field size for NVMe

2018-02-07 Thread Benjamin Marzinski
On Fri, Jan 19, 2018 at 12:55:35PM +0100, Martin Wilck wrote: > NVMe allows longer strings for the model (product) and firmware rev > than SCSI. Reviewed-by: Benjamin Marzinski > > Signed-off-by: Martin Wilck > --- > libmultipath/config.c| 2 +- >

[dm-devel] [PATCH 4/7] multipathd: remove unused configure parameter

2018-02-07 Thread Benjamin Marzinski
configure() is always called with start_waiters=1, so there is no point in having the parameter. Remove it. Signed-off-by: Benjamin Marzinski --- multipathd/main.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/multipathd/main.c

[dm-devel] [PATCH 1/7] multipath: fix tur checker locking

2018-02-07 Thread Benjamin Marzinski
Commit 6e2423fd fixed a bug where the tur checker could cancel a detached thread after it had exitted. However in fixing this, the new code grabbed a mutex (to call condlog) while holding a spin_lock. To deal with that, and to try to keep with the maixim "lock data, not code", I've changed how the

[dm-devel] [PATCH 3/7] multipathd: remove coalesce_paths from ev_add_map

2018-02-07 Thread Benjamin Marzinski
If ev_add_map is called for a multipath device that doesn't exist in device-mapper, it will call coalesce_paths to add it. This doesn't work and hasn't for years. It doesn't add the map to the mpvec, or start up waiters, or do any of the necessary things that do get done when you call ev_add_map

[dm-devel] [PATCH 6/7] multipathd: change spurious uevent msg priority

2018-02-07 Thread Benjamin Marzinski
The "spurious uevent, path already in pathvec" is not anything to worry about, so it should not have the error priority. Signed-off-by: Benjamin Marzinski --- multipathd/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/multipathd/main.c

[dm-devel] Help request: setting up /dev/zero using dm-crypt ...

2018-02-07 Thread Ravi Prakash Putchala
Hi, We would like to experiment and see the performance results with different options of dm-crypt. To do this we would like to setup /dev/zero with dm-crypt as mentioned in https://www.redhat.com/archives/dm-devel/2015-February/msg00106.html However, when I did the following no new mapping gets

Re: [dm-devel] Help request: setting up /dev/zero using dm-crypt ...

2018-02-07 Thread Milan Broz
On 02/07/2018 09:15 AM, Ravi Prakash Putchala wrote: > We would like to experiment and see the performance results with different > options of dm-crypt. To do this we would like to setup /dev/zero with > dm-crypt as mentioned in >