Re: [dm-devel] [PATCH v3 1/7] libmultipath: fix tur checker locking

2018-02-13 Thread Hannes Reinecke
On 02/13/2018 04:42 AM, Benjamin Marzinski wrote: > Commit 6e2423fd fixed a bug where the tur checker could cancel a > detached thread after it had exitted. However in fixing this, the new > code grabbed a mutex (to call condlog) while holding a spin_lock. To > deal with this, I've done away with

[dm-devel] [PATCH] dm-integrity: Fail early if required HMAC key is not available.

2018-02-13 Thread Milan Broz
With crypto API commit 9fa68f620041be04720d0cbfb1bd3ddfc6310b24 crypto: hash - prevent using keyed hashes without setting key dm-integrity cannot use keyed algorithms without setting key. The dm-integrity recognizes this too late (during use of HMAC), so it allows creation and formatting of

Re: [dm-devel] [RFC PATCH 5/5] multipathd: RFC add new polling dmevents waiter thread

2018-02-13 Thread Martin Wilck
Hi Ben, On Mon, 2018-02-12 at 17:18 -0600, Benjamin Marzinski wrote: > On Sat, Feb 10, 2018 at 08:55:53PM +0100, Martin Wilck wrote: > > Hi Ben, > > > > thanks a lot for this. I have only a few minor nitpicks (see > > below). > > I suppose you've tested this already? > > Yes. I do plan on doing

Re: [dm-devel] [PATCH v3 1/7] libmultipath: fix tur checker locking

2018-02-13 Thread Martin Wilck
On Mon, 2018-02-12 at 21:42 -0600, Benjamin Marzinski wrote: > Commit 6e2423fd fixed a bug where the tur checker could cancel a > detached thread after it had exitted. However in fixing this, the new > code grabbed a mutex (to call condlog) while holding a spin_lock. To > deal with this, I've

Re: [dm-devel] [RFC PATCH 5/5] multipathd: RFC add new polling dmevents waiter thread

2018-02-13 Thread Benjamin Marzinski
On Tue, Feb 13, 2018 at 09:50:19AM +0100, Martin Wilck wrote: > Hi Ben, > > On Mon, 2018-02-12 at 17:18 -0600, Benjamin Marzinski wrote: > > On Sat, Feb 10, 2018 at 08:55:53PM +0100, Martin Wilck wrote: > > > Hi Ben, > > > > > > thanks a lot for this. I have only a few minor nitpicks (see > > >

Re: [dm-devel] [RFC PATCH 5/5] multipathd: RFC add new polling dmevents waiter thread

2018-02-13 Thread Martin Wilck
On Tue, 2018-02-13 at 10:49 -0600, Benjamin Marzinski wrote: > On Tue, Feb 13, 2018 at 09:50:19AM +0100, Martin Wilck wrote: > > Hi Ben, > > > > Am I understanding correctly that you are working on libdevmapper > > in > > parallel? If yes, would it make sense to have libmultipath use the > >

Re: [dm-devel] [PATCH v3 1/7] libmultipath: fix tur checker locking

2018-02-13 Thread Benjamin Marzinski
On Tue, Feb 13, 2018 at 11:20:39AM +0100, Hannes Reinecke wrote: > On 02/13/2018 04:42 AM, Benjamin Marzinski wrote: > I would rather set 'ct->running' from within the thread; otherwise there > is a chance that pthread_create() returns without error, but the thread > itself hasn't been run yet.

Re: [dm-devel] [PATCH 2/2] dm-writecache

2018-02-13 Thread Mikulas Patocka
On Fri, 8 Dec 2017, Dan Williams wrote: > > > > when we write to > > > > persistent memory using cached write instructions and use dax_flush > > > > afterwards to flush cache for the affected range, the performance is > > > > about > > > > 350MB/s. It is practically unusable - worse than

Re: [dm-devel] [PATCH 2/2] dm-writecache

2018-02-13 Thread Dan Williams
On Tue, Feb 13, 2018 at 2:00 PM, Mikulas Patocka wrote: > > > On Fri, 8 Dec 2017, Dan Williams wrote: > >> > > > when we write to >> > > > persistent memory using cached write instructions and use dax_flush >> > > > afterwards to flush cache for the affected range, the

Re: [dm-devel] [PATCH 2/2] dm-writecache

2018-02-13 Thread Mikulas Patocka
On Tue, 13 Feb 2018, Dan Williams wrote: > On Tue, Feb 13, 2018 at 2:00 PM, Mikulas Patocka wrote: > > > > > > On Fri, 8 Dec 2017, Dan Williams wrote: > > > >> > > > when we write to > >> > > > persistent memory using cached write instructions and use dax_flush > >> > > >

Re: [dm-devel] [PATCH 2/2] dm-writecache

2018-02-13 Thread Dan Williams
On Tue, Feb 13, 2018 at 5:24 PM, Mikulas Patocka wrote: > > > On Tue, 13 Feb 2018, Dan Williams wrote: > >> On Tue, Feb 13, 2018 at 2:00 PM, Mikulas Patocka wrote: >> > >> > >> > On Fri, 8 Dec 2017, Dan Williams wrote: >> > >> >> > > > when we write to