Re: [dm-devel] dm bufio: Reduce dm_bufio_lock contention

2018-06-15 Thread Mikulas Patocka
On Fri, 15 Jun 2018, Michal Hocko wrote: > On Thu 14-06-18 14:34:06, Mikulas Patocka wrote: > > > > > > On Thu, 14 Jun 2018, Michal Hocko wrote: > > > > > On Thu 14-06-18 15:18:58, jing xia wrote: > > > [...] > > > > PID: 22920 TASK: ffc0120f1a00 CPU: 1 COMMAND: "kworker/u8:2" > > >

Re: [dm-devel] dm bufio: Reduce dm_bufio_lock contention

2018-06-15 Thread Mikulas Patocka
On Fri, 15 Jun 2018, Michal Hocko wrote: > On Fri 15-06-18 07:35:07, Mikulas Patocka wrote: > > > > Because mempool uses it. Mempool uses allocations with "GFP_NOIO | > > __GFP_NORETRY | __GFP_NOMEMALLOC | __GFP_NOWARN". An so dm-bufio uses > > these flags too. dm-bufio is just a big

Re: [dm-devel] dm bufio: Reduce dm_bufio_lock contention

2018-06-15 Thread Michal Hocko
On Fri 15-06-18 08:47:52, Mikulas Patocka wrote: > > > On Fri, 15 Jun 2018, Michal Hocko wrote: > > > On Fri 15-06-18 07:35:07, Mikulas Patocka wrote: > > > > > > Because mempool uses it. Mempool uses allocations with "GFP_NOIO | > > > __GFP_NORETRY | __GFP_NOMEMALLOC | __GFP_NOWARN". An so

Re: [dm-devel] dm bufio: Reduce dm_bufio_lock contention

2018-06-15 Thread Michal Hocko
On Fri 15-06-18 07:35:07, Mikulas Patocka wrote: > > > On Fri, 15 Jun 2018, Michal Hocko wrote: > > > On Thu 14-06-18 14:34:06, Mikulas Patocka wrote: > > > > > > > > > On Thu, 14 Jun 2018, Michal Hocko wrote: > > > > > > > On Thu 14-06-18 15:18:58, jing xia wrote: > > > > [...] > > > > >

[dm-devel] [PATCH] Fix lintian complaint about bad whatis entry

2018-06-15 Thread Xose Vazquez Perez
From: Vincent McIntyre Cc: Christophe Varoqui Cc: DM-DEV ML Signed-off-by: Vincent McIntyre Signed-off-by: Xose Vazquez Perez --- libmpathpersist/mpath_persistent_reserve_in.3 | 2 +- libmpathpersist/mpath_persistent_reserve_out.3 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

[dm-devel] [PATCH] multipath-tools: remove unused SCSI_REV_SIZE

2018-06-15 Thread Xose Vazquez Perez
It was replaced in 00ee0bda40f8b6ac060211c36a419c699af7f778 Cc: Martin Wilck Cc: Christophe Varoqui Cc: DM-DEV ML Signed-off-by: Xose Vazquez Perez --- libmultipath/structs.h | 1 - 1 file changed, 1 deletion(-) diff --git a/libmultipath/structs.h b/libmultipath/structs.h index

Re: [dm-devel] [PATCH v2 1/5] md: Avoid namespace collision with bitmap API

2018-06-15 Thread kbuild test robot
Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on next-20180615] [also build test ERROR on v4.17] [cannot apply to md/for-next linus/master dm/for-next v4.17 v4.17-rc7 v4.17-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve

Re: [dm-devel] [PATCH v2 1/5] md: Avoid namespace collision with bitmap API

2018-06-15 Thread kbuild test robot
Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on next-20180615] [also build test ERROR on v4.17] [cannot apply to md/for-next linus/master dm/for-next v4.17 v4.17-rc7 v4.17-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve

Re: [dm-devel] [PATCH 15/28] libmultipath: merge hwentries inside a conf file

2018-06-15 Thread Benjamin Marzinski
On Fri, Jun 08, 2018 at 12:20:28PM +0200, Martin Wilck wrote: > Merging hwentries with identical vendor/product/revision is still useful, > although it's not strictly necessary any more. But such identical entries > should always be merged, not only if they appear in different configuration >

Re: [dm-devel] [PATCH] multipath-tools: remove unused SCSI_REV_SIZE

2018-06-15 Thread Martin Wilck
On Fri, 2018-06-15 at 16:44 +0200, Xose Vazquez Perez wrote: > It was replaced in 00ee0bda40f8b6ac060211c36a419c699af7f778 > > Cc: Martin Wilck > Cc: Christophe Varoqui > Cc: DM-DEV ML > Signed-off-by: Xose Vazquez Perez > --- > libmultipath/structs.h | 1 - > 1 file changed, 1 deletion(-)

Re: [dm-devel] why does __split_and_process_bio use bio_clone_bioset?

2018-06-15 Thread Christoph Hellwig
On Thu, Jun 14, 2018 at 04:08:09PM -0400, Mike Snitzer wrote: > The patch below seems to work fine (given quick testing).. It also has a > side-effect of not breaking integrity support (which commit 18a25da8 > appears to do because it isn't accounting for any of the integrity stuff > bio_split, or

Re: [dm-devel] why does __split_and_process_bio use bio_clone_bioset?

2018-06-15 Thread Mike Snitzer
On Fri, Jun 15 2018 at 3:38am -0400, Christoph Hellwig wrote: > On Thu, Jun 14, 2018 at 04:08:09PM -0400, Mike Snitzer wrote: > > The patch below seems to work fine (given quick testing).. It also has a > > side-effect of not breaking integrity support (which commit 18a25da8 > > appears to do

Re: [dm-devel] dm bufio: Reduce dm_bufio_lock contention

2018-06-15 Thread Michal Hocko
On Thu 14-06-18 14:34:06, Mikulas Patocka wrote: > > > On Thu, 14 Jun 2018, Michal Hocko wrote: > > > On Thu 14-06-18 15:18:58, jing xia wrote: > > [...] > > > PID: 22920 TASK: ffc0120f1a00 CPU: 1 COMMAND: "kworker/u8:2" > > > #0 [ffc0282af3d0] __switch_to at ff8008085e48 > > >