Re: [dm-devel] [PATCH v2 05/10] block: add emulation for copy

2022-02-16 Thread Mikulas Patocka
On Mon, 7 Feb 2022, Nitesh Shetty wrote: > + goto retry; > + return PTR_ERR(bio); > + } > + > + bio->bi_iter.bi_sector = sector >> SECTOR_SHIFT; > + bio->bi_opf = op; > + bio_set_dev(bio, bdev); >

Re: [dm-devel] [PATCH v2 08/10] dm: Add support for copy offload.

2022-02-16 Thread Mikulas Patocka
On Mon, 7 Feb 2022, Nitesh Shetty wrote: > Before enabling copy for dm target, check if underlaying devices and > dm target support copy. Avoid split happening inside dm target. > Fail early if the request needs split, currently spliting copy > request is not supported > > Signed-off-by:

Re: [dm-devel] [PATCH] udev-md-raid-assembly.rules: skip if DM_UDEV_DISABLE_OTHER_RULES_FLAG

2022-02-16 Thread NeilBrown
On Thu, 17 Feb 2022, mwi...@suse.com wrote: > From: Martin Wilck > > device-mapper sets the flag DM_UDEV_DISABLE_OTHER_RULES_FLAG to 1 for > devices which are unusable. They may be no set up yet, suspended, or > otherwise unusable (e.g. multipath maps without usable path). This > flag does not

Re: [dm-devel] make the blk-mq stacking interface optional

2022-02-16 Thread Mike Snitzer
On Tue, Feb 15 2022 at 5:05P -0500, Christoph Hellwig wrote: > Hi Jens, > > this series requires an explicit select to use the blk-mq stacking > interfaces. This means they don't get build without dm support, and > thus the buildbot should catch abuses like the one we had in the ufs > driver

[dm-devel] [PATCH] dm-stats: refactor dm_stats_precise_timestamps

2022-02-16 Thread Mikulas Patocka
Don't pollute struct mapped_device with dm_stats_precise_timestamps; move it into struct dm_stats. This patch also removes dm_stats->last_sector and dm_stats->last_rw which are unused. Signed-off-by: Mikulas Patocka --- drivers/md/dm-core.h |2 -- drivers/md/dm-stats.c | 28

Re: [dm-devel] [PATCH 6/7] dm: remove write same support

2022-02-16 Thread Mike Snitzer
On Wed, Feb 09 2022 at 3:28P -0500, Christoph Hellwig wrote: > There are no more end-users of REQ_OP_WRITE_SAME left, so we can start > deleting it. > > Signed-off-by: Christoph Hellwig Thanks. Reviewed-by: Mike Snitzer -- dm-devel mailing list dm-devel@redhat.com

Re: [dm-devel] make the blk-mq stacking interface optional

2022-02-16 Thread Jens Axboe
On Tue, 15 Feb 2022 11:05:35 +0100, Christoph Hellwig wrote: > this series requires an explicit select to use the blk-mq stacking > interfaces. This means they don't get build without dm support, and > thus the buildbot should catch abuses like the one we had in the ufs > driver more easily. And

Re: [dm-devel] remove REQ_OP_WRITE_SAME v2

2022-02-16 Thread Jens Axboe
On 2/9/22 10:51 PM, Christoph Hellwig wrote: > On Wed, Feb 09, 2022 at 01:00:26PM -0500, Martin K. Petersen wrote: >> >> Christoph, >> >>> Now that we are using REQ_OP_WRITE_ZEROES for all zeroing needs in the >>> kernel there is very little use left for REQ_OP_WRITE_SAME. We only >>> have two

Re: [dm-devel] remove REQ_OP_WRITE_SAME v2

2022-02-16 Thread Christoph Hellwig
On Wed, Feb 16, 2022 at 08:07:56PM -0700, Jens Axboe wrote: > Let's just use the SCSI tree - I didn't check if it throws any conflicts > right now, so probably something to check upfront... There is a minor conflict because the __blkdev_issue_write_same function removed by this series is affected