Re: [dm-devel] [PATCH] multipath-tools: unreachable controllers maintainers

2016-06-06 Thread Martin K. Petersen
Srinivasan Ramani <srinivas.ram...@oracle.com> is the correct address. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] scsi-debug regression with 4.5-rc?

2016-03-05 Thread Martin K. Petersen
Mike> should be: q->limits.discard_granularity = 1 * logical_block_size; *blush* Will fix. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 03/12] BUG: Losing bits on request.cmd_flags

2016-04-04 Thread Martin K. Petersen
patch set from Mike Christie that cleans all this up. Please use that as baseline. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 2/3] block: require write_same and discard requests align to logical block size

2016-06-28 Thread Martin K. Petersen
Failure to do this causes Darrick> other errors in other parts of the block layer or the SCSI Darrick> layer because disks don't support partial logical block writes. Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com> -- Martin K. Petersen Oracle Linux Engineering

Re: [dm-devel] [PATCH 1/3] block: invalidate the page cache when issuing BLKZEROOUT.

2016-06-28 Thread Martin K. Petersen
>>>>> "Darrick" == Darrick J Wong <darrick.w...@oracle.com> writes: Darrick> Invalidate the page cache (as a regular O_DIRECT write would Darrick> do) to avoid returning stale cache contents at a later time. Reviewed-by: Martin K. Petersen <martin.pete

Re: [dm-devel] [PATCH] scsi: blacklist all RDAC devices for BLIST_NO_ULD_ATTACH

2016-08-15 Thread Martin K. Petersen
>>>>> "Xose" == Xose Vazquez Perez <xose.vazq...@gmail.com> writes: Xose> "Universal Xport" LUN is used for in-band storage array Xose> management. Applied to 4.8/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering --

Re: [dm-devel] [PATCH 03/18] block: fix elevator init check

2017-01-25 Thread Martin K. Petersen
hecking for the flush flags in __get_request. Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com> -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 05/18] block: allow specifying size for extra command data

2017-01-25 Thread Martin K. Petersen
o a bit heavy on the else brackets a couple of places. But no biggie. Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com> -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 12/18] scsi: respect unchecked_isa_dma for blk-mq

2017-01-25 Thread Martin K. Petersen
nd share the code to Christoph> allocate the sense buffers as well as the sense buffer slab Christoph> caches between the legacy and blk-mq path. Acked-by: Martin K. Petersen <martin.peter...@oracle.com> -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@r

Re: [dm-devel] [PATCH 11/18] scsi: remove gfp_flags member in scsi_host_cmd_pool

2017-01-25 Thread Martin K. Petersen
no point passing Christoph> the kmalloc-family only GFP_DMA flag to kmem_cache_alloc. Christoph> Drop all the infrastructure for doing so. Acked-by: Martin K. Petersen <martin.peter...@oracle.com> -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@r

Re: [dm-devel] [PATCH 13/18] scsi: remove scsi_cmd_dma_pool

2017-01-25 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig <h...@lst.de> writes: Christoph> There is no need for GFP_DMA allocations of the scsi_cmnd Christoph> structures themselves, all that might be DMAed to or from is Christoph> the actual payload, or the sens

Re: [dm-devel] [PATCH 04/18] block: simplify blk_init_allocated_queue

2017-01-25 Thread Martin K. Petersen
lock to the caller as Christoph> passing them as argument doesn't simplify anything. While Christoph> we're at it also remove two pointless NULL assignments, given Christoph> that the request structure is zeroed on allocation. Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com>

Re: [dm-devel] [PATCH 08/18] scsi_dh_rdac: switch to scsi_execute_req_flags()

2017-01-25 Thread Martin K. Petersen
will set Christoph> REQ_QUIET and REQ_PREEMPT, but this is okay as we're Christoph> evaluating the errors anyway and should be able to send the Christoph> command even if the device is quiesced. Acked-by: Martin K. Petersen <martin.peter...@oracle.com> -- Martin K. Petersen

Re: [dm-devel] [PATCH 14/18] scsi: remove __scsi_alloc_queue

2017-01-25 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig <h...@lst.de> writes: Christoph> Instead do an internal export of __scsi_init_queue for the Christoph> transport classes that export BSG nodes. Acked-by: Martin K. Petersen <martin.peter...@oracle.com> -- Marti

Re: [dm-devel] [PATCH 15/18] scsi: allocate scsi_cmnd structures as part of struct request

2017-01-25 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig <h...@lst.de> writes: Christoph> Rely on the new block layer functionality to allocate Christoph> additional driver specific data behind struct request instead Christoph> of implementing it in SCSI itѕelf. Ac

Re: [dm-devel] [PATCH 18/18] block: don't assign cmd_flags in __blk_rq_prep_clone

2017-01-25 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig <h...@lst.de> writes: Christoph> These days we have the proper flags set since request Christoph> allocation time. Acked-by: Martin K. Petersen <martin.peter...@oracle.com> -- Martin K. Petersen Oracle Lin

Re: [dm-devel] [PATCH v2] block: disallow changing max_sectors_kb on a request stacking device

2016-11-08 Thread Martin K. Petersen
it to contain the minimum max_sectors from below. It was really only envisioned as a LLD limit but it may be useful in this case. queue_max_sectors_store() already enforces it. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] scsi: replace wrong device handler name for CLARiiON arrays

2016-10-11 Thread Martin K. Petersen
>>>>> "Xose" == Xose Vazquez Perez <xose.vazq...@gmail.com> writes: Xose> At drivers/scsi/device_handler/scsi_dh_emc.c it was defined as: Xose> #define CLARIION_NAME "emc" Applied to 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux

Re: [dm-devel] [PATCH v2] scsi_devinfo: remove synchronous ALUA for NETAPP devices

2016-12-07 Thread Martin K. Petersen
>>>>> "Xose" == Xose Vazquez Perez <xose.vazq...@gmail.com> writes: Xose> NetApp did confirm this is not required. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] RFC: always use REQ_OP_WRITE_ZEROES for zeroing offload

2017-03-30 Thread Martin K. Petersen
Mike Snitzer <snit...@redhat.com> writes: > Would be very useful, particularly for testing, if > drivers/scsi/scsi_debug.c were updated to support WRITE ZEROES. There is no WRITE ZEROES in SCSI. You should be able to get the right behavior with lbpws=1 lbprz=1. -- Martin

Re: [dm-devel] [PATCH 22/23] drbd: implement REQ_OP_WRITE_ZEROES

2017-03-30 Thread Martin K. Petersen
et's make sure our semantics match the hardware ditto. - So write zeroes should behave deterministically and explicitly handle any blocks that can't be cleared via deprovisioning. - And discard can work at the discard granularity in a non-deterministic fashion. -- Martin K. Petersen

Re: [dm-devel] [PATCH 12/23] sd: handle REQ_UNMAP

2017-03-30 Thread Martin K. Petersen
and if the device has too many sectors that will already cause > discard to fail, I'm not sure I understand what you mean by that? -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 23/23] block: remove the discard_zeroes_data flag

2017-03-30 Thread Martin K. Petersen
this variable (as opposed to the ioctl). -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 03/23] sd: implement REQ_OP_WRITE_ZEROES

2017-03-29 Thread Martin K. Petersen
pecified write operation to that LBA;" I.e. With WRITE SAME it is the responsibility of the device server to write any LBAs described by the command that were not successfully unmapped. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 12/23] sd: handle REQ_UNMAP

2017-03-30 Thread Martin K. Petersen
RITE_ZEROES path in addition to the DISCARD path. Oh, I see. We only had the LBA sanity check in place for write same, not for discard. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] remove REQ_OP_WRITE_SAME

2017-04-13 Thread Martin K. Petersen
til I finish the token stuff. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 26/27] scsi: sd: Separate zeroout and discard command choices

2017-04-19 Thread Martin K. Petersen
Paolo, > Should this be conditional on lbprz, lbpws, lbpws10 and max_ws_blocks? It is intentional that things can be overridden from userland for devices that report the "wrong" thing. We do the same for discard so people can set up udev rules. -- Martin K. Petersen

Re: [dm-devel] [PATCH 08/23] scsi: introduce a result field in struct scsi_request

2017-04-19 Thread Martin K. Petersen
Christoph Hellwig <h...@lst.de> writes: > This passes on the scsi_cmnd result field to users of passthrough > requests. Currently we abuse req->errors for this purpose, but that > field will go away in its current form. Reviewed-by: Martin K. Petersen <martin.peter..

Re: [dm-devel] [PATCH] block: get rid of blk_integrity_revalidate()

2017-04-19 Thread Martin K. Petersen
em to recall that the reason for the revalidate hook was that either NVMe or nvdimm had to register an integrity profile prior to the actual format being known. So while I am OK with the change from a SCSI perspective, I think we need Keith and Dan to ack it. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v2 for-4.12] block: fix blk_integrity_register to use template's interval_exp if not 0

2017-04-23 Thread Martin K. Petersen
ying device if its logical block size > conflicts with the underlying device's logical block size. Looks good! Acked-by: Martin K. Petersen <martin.peter...@oracle.com> -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH for-4.12] block, dm: use __blk_integrity_register to properly setup integrity profile

2017-04-23 Thread Martin K. Petersen
integrity interval be explicitly specified in the integrity template for all callers. Maybe with a fallback to qlbs if it's set to 0. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 25/25] block: remove the discard_zeroes_data flag

2017-04-05 Thread Martin K. Petersen
Christoph Hellwig <h...@lst.de> writes: > Now that we use the proper REQ_OP_WRITE_ZEROES operation everywhere we > can kill this hack. Oh yeah! Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com> -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mai

Re: [dm-devel] always use REQ_OP_WRITE_ZEROES for zeroing offload

2017-04-05 Thread Martin K. Petersen
onfiguration for most storage devices. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 01/25] ѕd: split sd_setup_discard_cmnd

2017-04-05 Thread Martin K. Petersen
ite same functions for the upcoming scsi implementation of the Write Zeroes > operation. Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com> Minor nit: Patch header should be "sd: ..." instead of " d: ...". -- Martin K. Petersen Oracle Linux Engineerin

Re: [dm-devel] [PATCH 02/25] block: renumber REQ_OP_WRITE_ZEROES

2017-04-05 Thread Martin K. Petersen
Christoph Hellwig <h...@lst.de> writes: > Make life easy for implementations that needs to send a data buffer > to the device (e.g. SCSI) by numbering it as a data out command. Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com> -- Martin K. Petersen Oracle

Re: [dm-devel] [PATCH 03/25] block: implement splitting of REQ_OP_WRITE_ZEROES bios

2017-04-05 Thread Martin K. Petersen
Christoph Hellwig <h...@lst.de> writes: > Copy and past the REQ_OP_WRITE_SAME code to prepare to implementations > that limit the write zeroes size. Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com> -- Martin K. Petersen Oracle Linux Engineering -- dm-dev

Re: [dm-devel] [PATCH 04/25] sd: implement REQ_OP_WRITE_ZEROES

2017-04-05 Thread Martin K. Petersen
Christoph Hellwig <h...@lst.de> writes: Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com> -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 09/25] block: stop using blkdev_issue_write_same for zeroing

2017-04-05 Thread Martin K. Petersen
Christoph Hellwig <h...@lst.de> writes: > We'll always use the WRITE ZEROES code for zeroing now. Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com> -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.red

Re: [dm-devel] [PATCH 11/25] block: add a REQ_UNMAP flag for REQ_OP_WRITE_ZEROES

2017-04-05 Thread Martin K. Petersen
for a static function > that would have become even more out of data with this change. Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com> -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 10/25] block: add a flags argument to (__)blkdev_issue_zeroout

2017-04-05 Thread Martin K. Petersen
Christoph Hellwig <h...@lst.de> writes: > Turn the existin discard flag into a new BLKDEV_ZERO_UNMAP flag with g > similar semantics, but without referring to diѕcard. s Reviewed-by: Martin K. Petersen <martin.pete

Re: [dm-devel] [PATCH 13/25] block_dev: use blkdev_issue_zerout for hole punches

2017-04-05 Thread Martin K. Petersen
Christoph Hellwig <h...@lst.de> writes: > This gets us support for non-discard efficient write of zeroes > (e.g. NVMe) and prepare for removing the discard_zeroes_data flag. s Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com> --

Re: [dm-devel] [PATCH 12/25] block: add a new BLKDEV_ZERO_NOFALLBACK flag

2017-04-05 Thread Martin K. Petersen
Christoph Hellwig <h...@lst.de> writes: > This avoids fallbacks to explicit zeroing in (__)blkdev_issue_zeroout > if the caller doesn't want them. > > Also clean up the convoluted check for the return condition that this > new flag is added to. Reviewed-by: Martin K. P

Re: [dm-devel] [PATCH 14/25] sd: implement unmapping Write Zeroes

2017-04-05 Thread Martin K. Petersen
Christoph Hellwig <h...@lst.de> writes: > Try to use a write same with unmap bit variant if the device supports it > and the caller allows for it. Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com> -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mai

Re: [dm-devel] [PATCH 15/25] nvme: implement REQ_OP_WRITE_ZEROES

2017-04-05 Thread Martin K. Petersen
Christoph Hellwig <h...@lst.de> writes: > But now for the real NVMe Write Zeroes yet, just to get rid of the > discard abuse for zeroing. Also rename the quirk flag to be a bit > more self-explanatory. Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com> -

Re: [dm-devel] [PATCH 22/25] block: stop using discards for zeroing

2017-04-05 Thread Martin K. Petersen
-EOPNOTSUPP is returned, the caller should retry the blkdev_issue_zeroout() and the fallback path will be used." Otherwise OK. Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com> -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 22/23] drbd: implement REQ_OP_WRITE_ZEROES

2017-03-30 Thread Martin K. Petersen
he fallback to a zeroout command is to do a regular write. So if DM doesn't zero the blocks, the block layer is going to it. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] bio-integrity: revert "stop abusing bi_end_io"

2017-08-05 Thread Martin K. Petersen
hat approach to reverting Christoph's commit. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] bio-integrity: revert "stop abusing bi_end_io"

2017-08-05 Thread Martin K. Petersen
driver or HBA firmware. So the verification is designed to be done by the top level entity that attaches the protection information to the bio. In this case bio_integrity_prep(). -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redh

Re: [dm-devel] [RFC PATCH] bio-integrity: Fix regression if profile verify_fn is NULL

2017-08-02 Thread Martin K. Petersen
the endio function). Anyway. So I think that the BLK_INTEGRITY_VERIFY logic needs to be carried over to __bio_integrity_endio()... -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] two small integrity cleanups

2017-08-09 Thread Martin K. Petersen
Christoph, > Found these while coming up with the fixes just sent. Also OK. Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com> -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] bio-integrity: revert "stop abusing bi_end_io"

2017-08-07 Thread Martin K. Petersen
s from one address space to the other. In addition, some HBA hardware allows us to program the PI engine with the seed value. So the submitter value to LBA conversion can be done on the fly in hardware. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-deve

Re: [dm-devel] [PATCH 02/13] scsi/osd: don't save block errors into req_results

2017-05-26 Thread Martin K. Petersen
Christoph, > We will only have sense data if the command exectured and got a SCSI > result, so this is pointless. "executed" Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com> -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-

Re: [dm-devel] remove REQ_OP_WRITE_SAME

2017-05-08 Thread Martin K. Petersen
Christoph, > Any chance to get a sneak preview of that work? I have been on the road since LSF/MM and just got back home. I'll make it a priority. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] scsi_dh: add new rdac devices

2017-12-07 Thread Martin K. Petersen
plied to 4.16/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH V2] blk-mq: introduce BLK_STS_DEV_RESOURCE

2018-01-23 Thread Martin K. Petersen
BLK_STS_SOURCE, for example, when memory allocation, DMA Mapping or other ^^^^^^ -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] dm mpath: fix passing integrity data

2018-03-15 Thread Martin K. Petersen
Steffen, > After v4.12 commit e2460f2a4bc7 ("dm: mark targets that pass integrity > data"), dm-multipath, e.g. on DIF+DIX SCSI disk paths, does not support > block integrity any more. So add it to the whitelist. Ugh. Reviewed-by: Martin K. Petersen <martin.peter...@ora

Re: [dm-devel] [PATCH RFC] scsi: devinfo: remove dasd devices from the scsi subsystem

2018-03-19 Thread Martin K. Petersen
Xose, > Only present through ccw bus. Applied to 4.17/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] scsi: devinfo: remove DF arrays from HP

2018-03-19 Thread Martin K. Petersen
Xose, > Matthias did confirm that there are no such devices. Applied to 4.17/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v4 02/11] scsi: sd_zbc: Reduce boot device scan and revalidate time

2018-10-15 Thread Martin K. Petersen
ce execution time. > > Using a 14 TB ZBC disk, these simple changes reduce device scan time at > boot from about 3.5s down to about 900ms. Disk revalidate times are also > reduced from about 450ms down to 230ms. Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux E

Re: [dm-devel] [PATCH v4 03/11] scsi: sd_zbc: Fix sd_zbc_check_zones() error checks

2018-10-15 Thread Martin K. Petersen
er to > avoid overflowing the signed 32 return value. Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v4 01/11] scsi: sd_zbc: Rearrange code

2018-10-15 Thread Martin K. Petersen
page, rename it to > sd_zbc_check_zoned_characteristics(). Also fix the error message > displayed when reading that VPD page fails. Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v4 11/11] block: Introduce blk_revalidate_disk_zones()

2018-10-15 Thread Martin K. Petersen
r of zones through sysfs, a call to > blk_revalidate_disk_zones() is added to dm_table_set_restrictions(). > > The zone bitmaps allocated and initialized with > blk_revalidate_disk_zones() are freed automatically from > __blk_release_queue() using the block internal function > blk_que

Re: [dm-devel] [PATCH v4 10/11] block: add a report_zones method

2018-10-15 Thread Martin K. Petersen
dded to the dm-linear and > dm-flakey targets. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v4 00/11] Zoned block device support improvements

2018-10-24 Thread Martin K. Petersen
ould be properly documented if there is a preferred way to order things... -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v4 00/11] Zoned block device support improvements

2018-10-23 Thread Martin K. Petersen
The rest of the kernel appears to be either arbitrary ordering or favoring author SoB as the first tag. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] scsi: add new RDAC LENOVO/DE_Series device

2019-04-03 Thread Martin K. Petersen
Xose, > Blacklist "Universal Xport" LUN, it's used for in-band storage array > management. And add it to the rdac dh family. Applied to 5.1/scsi-fixes, thanks. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.re

Re: [dm-devel] block: Fix a WRITE SAME BUG_ON

2019-02-13 Thread Martin K. Petersen
zhangxiaoxu, > Any progress about the problme? > Should we disable the write same when stack the different LBA disks? Yes, please. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] block: Fix a WRITE SAME BUG_ON

2019-02-19 Thread Martin K. Petersen
? If we stick with the UINT_MAX check, the comment should at least point out why it's there. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] block: Fix a WRITE SAME BUG_ON

2019-01-28 Thread Martin K. Petersen
load being the ZERO_PAGE), it may be worthwhile to remove REQ_OP_WRITE_SAME. I think drbd is the only user relying on a non-zero payload. The target code ends up manually iterating, if I remember correctly... -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] block: Fix a WRITE SAME BUG_ON

2019-01-30 Thread Martin K. Petersen
pretty slow. I don't have any problems keeping WRITE_SAME around if people are actually using it. It just seemed like most active users only cared about writing zeroes. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH V6 1/4] block: Allow mapping of vmalloc-ed buffers

2019-07-11 Thread Martin K. Petersen
by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH V6 4/4] block: Limit zone array allocation size

2019-07-11 Thread Martin K. Petersen
d of allocating contiguous pages with alloc_pages(). Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH V6 3/4] sd_zbc: Fix report zones buffer allocation

2019-07-11 Thread Martin K. Petersen
s and KMALLOC_MAX_SIZE (4MB) and succeeds on boot (no > memory fragmentation), but often fail at run time (e.g. hot-plug > event). This causes the disk revalidation to fail and the disk > capacity to be changed to 0. Probably easiest to funnel this through block with the rest of the series. Acked

Re: [dm-devel] [PATCH V6 2/4] block: Kill gfp_t argument of blkdev_report_zones()

2019-07-11 Thread Martin K. Petersen
lloc_noio_save/restore() where > necessary (block layer zone revalidation and dm-zoned I/O error path). LGTM. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [PATCH 1/2] scsi: core: fix missing .cleanup_rq for SCSI hosts without request batching

2019-09-18 Thread Martin K. Petersen
ext. Thanks for the heads-up! -- Martin K. Petersen Oracle Linux Engineering

Re: [dm-devel] [PATCH 1/2] scsi: core: fix missing .cleanup_rq for SCSI hosts without request batching

2019-08-07 Thread Martin K. Petersen
oth land linus tree. I'll set up an amalgamated for-next branch tomorrow. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 6/8] scsi: sd_zbc: add zone open, close, and finish support

2019-11-01 Thread Martin K. Petersen
Damien, > Implement REQ_OP_ZONE_OPEN, REQ_OP_ZONE_CLOSE and REQ_OP_ZONE_FINISH > support to allow explicit control of zone states. > > Contains contributions from Matias Bjorling, Hans Holmberg, > Keith Busch and Damien Le Moal. Looks fine. Reviewed-by: Martin K. Petersen

Re: [dm-devel] [PATCH 3/8] scsi: sd_zbc: Fix sd_zbc_complete()

2019-11-01 Thread Martin K. Petersen
in the case of > REQ_OP_ZONE_RESET, excluding REQ_OP_ZONE_RESET_ALL. > > Since REQ_OP_ZONE_RESET is the only request handled by > sd_zbc_complete(), also simplify the code using a simple if statement. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- dm-dev

Re: [dm-devel] [PATCH 0/8] Zone management commands support

2019-11-04 Thread Martin K. Petersen
Damien, > Can you take patch 3 now ? Yep. Applied to 5.4/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] block: fix an integer overflow in logical block size

2020-01-15 Thread Martin K. Petersen
Mikulas, > This patch changes the logical block size from unsigned short to > unsigned int to avoid the overflow. Looks fine. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/m

Re: [dm-devel] [LSF/MM/BFP ATTEND] [LSF/MM/BFP TOPIC] Storage: Copy Offload

2020-01-09 Thread Martin K. Petersen
aka LID1). I don't think LID1 vs LID4 is particularly interesting for the Linux use case. It's just an additional command tag since the copy manager is a third party. > * Microsoft, which uses ODX (aka LID4 because it has a four-byte length > ID). Microsoft uses the token commands. -- Mar

Re: [dm-devel] [PATCH v7 0/6] block: Introduce REQ_ALLOCATE flag for REQ_OP_WRITE_ZEROES

2020-03-25 Thread Martin K. Petersen
eroing when provisioning blocks or not? -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v7 0/6] block: Introduce REQ_ALLOCATE flag for REQ_OP_WRITE_ZEROES

2020-03-26 Thread Martin K. Petersen
sulting code duplication acceptable. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH V8 02/11] block: add helper for copying request

2020-04-24 Thread Martin K. Petersen
Ming, > Add one new helper of blk_rq_copy_request() to copy request, and the > helper will be used in this patch for re-submitting request, so make > it as a block layer internal helper. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering --

Re: [dm-devel] [PATCH V8 01/11] block: clone nr_integrity_segments and write_hint in blk_rq_prep_clone

2020-04-24 Thread Martin K. Petersen
> have been cloned too. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCHv5 00/14] dm-zoned: metadata version 2

2020-05-13 Thread Martin K. Petersen
when each I/O is limited to a single logical block? -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCHv5 00/14] dm-zoned: metadata version 2

2020-05-13 Thread Martin K. Petersen
/Os larger than this value. Setting io_opt to the logical block size kind of defeats that intent. That said, we should probably handle the case where the pbs gets scaled up but io_opt doesn't more gracefully. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@r

Re: [dm-devel] [PATCH v7 0/6] block: Introduce REQ_ALLOCATE flag for REQ_OP_WRITE_ZEROES

2020-03-19 Thread Martin K. Petersen
d around "allocate this block and zero it if you can" than "zero this block and do not deallocate it". But maybe that's just me. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] block: Improve io_opt limit stacking

2020-05-22 Thread Martin K. Petersen
instance, doesn't produce the expected result. So I think I'd prefer not to set io_opt at all if it isn't consistent across all the stacked devices. Let me chew on it for a bit... -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] block: Improve io_opt limit stacking

2020-05-22 Thread Martin K. Petersen
5.8. Setting io_opt to the physical block size is not correct. -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel