Srinivasan Ramani <srinivas.ram...@oracle.com> is the correct address.
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Mike> should be: q->limits.discard_granularity = 1 * logical_block_size;
*blush*
Will fix.
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
patch set from Mike Christie that cleans all this
up. Please use that as baseline.
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Failure to do this causes
Darrick> other errors in other parts of the block layer or the SCSI
Darrick> layer because disks don't support partial logical block writes.
Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
>>>>> "Darrick" == Darrick J Wong <darrick.w...@oracle.com> writes:
Darrick> Invalidate the page cache (as a regular O_DIRECT write would
Darrick> do) to avoid returning stale cache contents at a later time.
Reviewed-by: Martin K. Petersen <martin.pete
>>>>> "Xose" == Xose Vazquez Perez <xose.vazq...@gmail.com> writes:
Xose> "Universal Xport" LUN is used for in-band storage array
Xose> management.
Applied to 4.8/scsi-fixes.
--
Martin K. Petersen Oracle Linux Engineering
--
hecking for the flush flags in __get_request.
Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
o a bit heavy on the else brackets a couple of places. But no biggie.
Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
nd share the code to
Christoph> allocate the sense buffers as well as the sense buffer slab
Christoph> caches between the legacy and blk-mq path.
Acked-by: Martin K. Petersen <martin.peter...@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@r
no point passing
Christoph> the kmalloc-family only GFP_DMA flag to kmem_cache_alloc.
Christoph> Drop all the infrastructure for doing so.
Acked-by: Martin K. Petersen <martin.peter...@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@r
>>>>> "Christoph" == Christoph Hellwig <h...@lst.de> writes:
Christoph> There is no need for GFP_DMA allocations of the scsi_cmnd
Christoph> structures themselves, all that might be DMAed to or from is
Christoph> the actual payload, or the sens
lock to the caller as
Christoph> passing them as argument doesn't simplify anything. While
Christoph> we're at it also remove two pointless NULL assignments, given
Christoph> that the request structure is zeroed on allocation.
Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com>
will set
Christoph> REQ_QUIET and REQ_PREEMPT, but this is okay as we're
Christoph> evaluating the errors anyway and should be able to send the
Christoph> command even if the device is quiesced.
Acked-by: Martin K. Petersen <martin.peter...@oracle.com>
--
Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig <h...@lst.de> writes:
Christoph> Instead do an internal export of __scsi_init_queue for the
Christoph> transport classes that export BSG nodes.
Acked-by: Martin K. Petersen <martin.peter...@oracle.com>
--
Marti
>>>>> "Christoph" == Christoph Hellwig <h...@lst.de> writes:
Christoph> Rely on the new block layer functionality to allocate
Christoph> additional driver specific data behind struct request instead
Christoph> of implementing it in SCSI itѕelf.
Ac
>>>>> "Christoph" == Christoph Hellwig <h...@lst.de> writes:
Christoph> These days we have the proper flags set since request
Christoph> allocation time.
Acked-by: Martin K. Petersen <martin.peter...@oracle.com>
--
Martin K. Petersen Oracle Lin
it to contain the minimum max_sectors from below. It was really only
envisioned as a LLD limit but it may be useful in this case.
queue_max_sectors_store() already enforces it.
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
>>>>> "Xose" == Xose Vazquez Perez <xose.vazq...@gmail.com> writes:
Xose> At drivers/scsi/device_handler/scsi_dh_emc.c it was defined as:
Xose> #define CLARIION_NAME "emc"
Applied to 4.9/scsi-fixes.
--
Martin K. Petersen Oracle Linux
>>>>> "Xose" == Xose Vazquez Perez <xose.vazq...@gmail.com> writes:
Xose> NetApp did confirm this is not required.
Applied to 4.10/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Mike Snitzer <snit...@redhat.com> writes:
> Would be very useful, particularly for testing, if
> drivers/scsi/scsi_debug.c were updated to support WRITE ZEROES.
There is no WRITE ZEROES in SCSI. You should be able to get the right
behavior with lbpws=1 lbprz=1.
--
Martin
et's make sure our semantics match the hardware ditto.
- So write zeroes should behave deterministically and explicitly handle
any blocks that can't be cleared via deprovisioning.
- And discard can work at the discard granularity in a
non-deterministic fashion.
--
Martin K. Petersen
and if the device has too many sectors that will already cause
> discard to fail,
I'm not sure I understand what you mean by that?
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
this variable (as opposed to the
ioctl).
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
pecified write operation to that LBA;"
I.e. With WRITE SAME it is the responsibility of the device server to
write any LBAs described by the command that were not successfully
unmapped.
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
RITE_ZEROES path in addition to the DISCARD path.
Oh, I see. We only had the LBA sanity check in place for write same, not
for discard.
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
til I finish the token stuff.
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Paolo,
> Should this be conditional on lbprz, lbpws, lbpws10 and max_ws_blocks?
It is intentional that things can be overridden from userland for
devices that report the "wrong" thing. We do the same for discard so
people can set up udev rules.
--
Martin K. Petersen
Christoph Hellwig <h...@lst.de> writes:
> This passes on the scsi_cmnd result field to users of passthrough
> requests. Currently we abuse req->errors for this purpose, but that
> field will go away in its current form.
Reviewed-by: Martin K. Petersen <martin.peter..
em to recall that the reason for the revalidate hook was that either
NVMe or nvdimm had to register an integrity profile prior to the actual
format being known.
So while I am OK with the change from a SCSI perspective, I think we
need Keith and Dan to ack it.
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
ying device if its logical block size
> conflicts with the underlying device's logical block size.
Looks good!
Acked-by: Martin K. Petersen <martin.peter...@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
integrity
interval be explicitly specified in the integrity template for all
callers. Maybe with a fallback to qlbs if it's set to 0.
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Christoph Hellwig <h...@lst.de> writes:
> Now that we use the proper REQ_OP_WRITE_ZEROES operation everywhere we
> can kill this hack.
Oh yeah!
Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mai
onfiguration for most storage devices.
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
ite same functions for the upcoming scsi implementation of the Write Zeroes
> operation.
Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com>
Minor nit: Patch header should be "sd: ..." instead of " d: ...".
--
Martin K. Petersen Oracle Linux Engineerin
Christoph Hellwig <h...@lst.de> writes:
> Make life easy for implementations that needs to send a data buffer
> to the device (e.g. SCSI) by numbering it as a data out command.
Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com>
--
Martin K. Petersen Oracle
Christoph Hellwig <h...@lst.de> writes:
> Copy and past the REQ_OP_WRITE_SAME code to prepare to implementations
> that limit the write zeroes size.
Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
--
dm-dev
Christoph Hellwig <h...@lst.de> writes:
Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Christoph Hellwig <h...@lst.de> writes:
> We'll always use the WRITE ZEROES code for zeroing now.
Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.red
for a static function
> that would have become even more out of data with this change.
Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Christoph Hellwig <h...@lst.de> writes:
> Turn the existin discard flag into a new BLKDEV_ZERO_UNMAP flag with
g
> similar semantics, but without referring to diѕcard.
s
Reviewed-by: Martin K. Petersen <martin.pete
Christoph Hellwig <h...@lst.de> writes:
> This gets us support for non-discard efficient write of zeroes
> (e.g. NVMe) and prepare for removing the discard_zeroes_data flag.
s
Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com>
--
Christoph Hellwig <h...@lst.de> writes:
> This avoids fallbacks to explicit zeroing in (__)blkdev_issue_zeroout
> if the caller doesn't want them.
>
> Also clean up the convoluted check for the return condition that this
> new flag is added to.
Reviewed-by: Martin K. P
Christoph Hellwig <h...@lst.de> writes:
> Try to use a write same with unmap bit variant if the device supports it
> and the caller allows for it.
Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mai
Christoph Hellwig <h...@lst.de> writes:
> But now for the real NVMe Write Zeroes yet, just to get rid of the
> discard abuse for zeroing. Also rename the quirk flag to be a bit
> more self-explanatory.
Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com>
-
-EOPNOTSUPP is returned, the caller
should retry the blkdev_issue_zeroout() and the fallback path will be
used."
Otherwise OK.
Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
he fallback to a zeroout command is to do a regular write. So
if DM doesn't zero the blocks, the block layer is going to it.
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
hat approach to reverting Christoph's commit.
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
driver or HBA firmware.
So the verification is designed to be done by the top level entity that
attaches the protection information to the bio. In this case
bio_integrity_prep().
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redh
the endio function).
Anyway. So I think that the BLK_INTEGRITY_VERIFY logic needs to be
carried over to __bio_integrity_endio()...
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Christoph,
> Found these while coming up with the fixes just sent.
Also OK.
Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
s from one address space to
the other. In addition, some HBA hardware allows us to program the PI
engine with the seed value. So the submitter value to LBA conversion can
be done on the fly in hardware.
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-deve
Christoph,
> We will only have sense data if the command exectured and got a SCSI
> result, so this is pointless.
"executed"
Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-
Christoph,
> Any chance to get a sneak preview of that work?
I have been on the road since LSF/MM and just got back home. I'll make
it a priority.
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
plied to 4.16/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
BLK_STS_SOURCE, for example, when memory allocation, DMA Mapping or other
^^^^^^
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Steffen,
> After v4.12 commit e2460f2a4bc7 ("dm: mark targets that pass integrity
> data"), dm-multipath, e.g. on DIF+DIX SCSI disk paths, does not support
> block integrity any more. So add it to the whitelist.
Ugh.
Reviewed-by: Martin K. Petersen <martin.peter...@ora
Xose,
> Only present through ccw bus.
Applied to 4.17/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Xose,
> Matthias did confirm that there are no such devices.
Applied to 4.17/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
ce execution time.
>
> Using a 14 TB ZBC disk, these simple changes reduce device scan time at
> boot from about 3.5s down to about 900ms. Disk revalidate times are also
> reduced from about 450ms down to 230ms.
Acked-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux E
er to
> avoid overflowing the signed 32 return value.
Acked-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
page, rename it to
> sd_zbc_check_zoned_characteristics(). Also fix the error message
> displayed when reading that VPD page fails.
Acked-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
r of zones through sysfs, a call to
> blk_revalidate_disk_zones() is added to dm_table_set_restrictions().
>
> The zone bitmaps allocated and initialized with
> blk_revalidate_disk_zones() are freed automatically from
> __blk_release_queue() using the block internal function
> blk_que
dded to the dm-linear and
> dm-flakey targets.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
ould be properly documented if there is a preferred
way to order things...
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
The rest of the kernel appears to be either arbitrary
ordering or favoring author SoB as the first tag.
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Xose,
> Blacklist "Universal Xport" LUN, it's used for in-band storage array
> management. And add it to the rdac dh family.
Applied to 5.1/scsi-fixes, thanks.
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.re
zhangxiaoxu,
> Any progress about the problme?
> Should we disable the write same when stack the different LBA disks?
Yes, please.
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
?
If we stick with the UINT_MAX check, the comment should at least point
out why it's there.
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
load being the ZERO_PAGE), it may be worthwhile
to remove REQ_OP_WRITE_SAME. I think drbd is the only user relying on a
non-zero payload. The target code ends up manually iterating, if I
remember correctly...
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
pretty slow.
I don't have any problems keeping WRITE_SAME around if people are
actually using it. It just seemed like most active users only cared
about writing zeroes.
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
d of allocating contiguous pages with alloc_pages().
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
s and KMALLOC_MAX_SIZE (4MB) and succeeds on boot (no
> memory fragmentation), but often fail at run time (e.g. hot-plug
> event). This causes the disk revalidation to fail and the disk
> capacity to be changed to 0.
Probably easiest to funnel this through block with the rest of the
series.
Acked
lloc_noio_save/restore() where
> necessary (block layer zone revalidation and dm-zoned I/O error path).
LGTM.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
ext.
Thanks for the heads-up!
--
Martin K. Petersen Oracle Linux Engineering
oth land linus tree.
I'll set up an amalgamated for-next branch tomorrow.
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Damien,
> Implement REQ_OP_ZONE_OPEN, REQ_OP_ZONE_CLOSE and REQ_OP_ZONE_FINISH
> support to allow explicit control of zone states.
>
> Contains contributions from Matias Bjorling, Hans Holmberg,
> Keith Busch and Damien Le Moal.
Looks fine.
Reviewed-by: Martin K. Petersen
in the case of
> REQ_OP_ZONE_RESET, excluding REQ_OP_ZONE_RESET_ALL.
>
> Since REQ_OP_ZONE_RESET is the only request handled by
> sd_zbc_complete(), also simplify the code using a simple if statement.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
--
dm-dev
Damien,
> Can you take patch 3 now ?
Yep. Applied to 5.4/scsi-fixes.
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Mikulas,
> This patch changes the logical block size from unsigned short to
> unsigned int to avoid the overflow.
Looks fine.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/m
aka LID1).
I don't think LID1 vs LID4 is particularly interesting for the Linux use
case. It's just an additional command tag since the copy manager is a
third party.
> * Microsoft, which uses ODX (aka LID4 because it has a four-byte length
> ID).
Microsoft uses the token commands.
--
Mar
eroing when provisioning blocks or not?
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
sulting code duplication acceptable.
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Ming,
> Add one new helper of blk_rq_copy_request() to copy request, and the
> helper will be used in this patch for re-submitting request, so make
> it as a block layer internal helper.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
--
> have been cloned too.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
when each
I/O is limited to a single logical block?
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
/Os larger than this value. Setting io_opt to the logical block
size kind of defeats that intent.
That said, we should probably handle the case where the pbs gets scaled
up but io_opt doesn't more gracefully.
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@r
d around "allocate this block and zero it if you can" than "zero
this block and do not deallocate it". But maybe that's just me.
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
instance, doesn't produce the expected result. So I think I'd
prefer not to set io_opt at all if it isn't consistent across all the
stacked devices.
Let me chew on it for a bit...
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
5.8.
Setting io_opt to the physical block size is not correct.
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
e201a scsi: core: Set sc_data_direction to DMA_NONE for no-transfer
commands
9120ac54cce6 scsi: sr: Initialize ->cmd_len
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
' isn't a multiple of 'physical_block_size'
> then it is a bug in the driver and the device should be flagged as
> 'misaligned'.
Looks good.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat
ers that need a non power-of-2 chunk_sectors.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Christoph,
> Inherit the optimal I/O size setting just like the readahead window,
> as any reason to do larger I/O does not apply to just readahead.
Looks fine.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redh
Christoph,
> The raid5 and raid10 drivers currently update the read-ahead size, but
> not the optimal I/O size on reshape. To prepare for deriving the
> read-ahead size from the optimal I/O size make sure it is updated as
> well.
Reviewed-by: Martin K. Petersen
--
Martin
me scheme based on
> max_sectors. To ensure the limits work well for stacking drivers a
> new helper is added to update the readahead limits from the block
> limits, which is also called from disk_stack_limits.
Looks good!
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle
Christoph,
> aoe forces a larger readahead size, but any reason to do larger I/O is
> not limited to readahead. Also set the optimal I/O size, and remove
> the local constants in favor of just using SZ_2G.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux En
ting whole-disk device policy. The
current behavior violates the principle of least surprise by letting the
user think they write protected the whole disk when they actually
didn't.
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
oblem (if at all)...
--
Martin K. Petersen Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Christoph,
> Unconditionally call set_disk_ro now that it only updates the hardware
> state. This allows to properly set up the Linux devices read-only when
> the controller turns a previously writable namespace read-only.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen
1 - 100 of 159 matches
Mail list logo
