Re: [dm-devel] [PATCH 1/7] multipath: fix tur checker locking

2018-02-08 Thread Bart Van Assche
On Thu, 2018-02-08 at 13:27 -0600, Benjamin Marzinski wrote: > On Thu, Feb 08, 2018 at 06:19:32PM +, Bart Van Assche wrote: > > On Wed, 2018-02-07 at 16:49 -0600, Benjamin Marzinski wrote: > > > Commit 6e2423fd fixed a bug where the tur checker could cancel a > > > detached thread after it had

Re: [dm-devel] [PATCH 1/7] multipath: fix tur checker locking

2018-02-08 Thread Benjamin Marzinski
On Thu, Feb 08, 2018 at 06:19:32PM +, Bart Van Assche wrote: > On Wed, 2018-02-07 at 16:49 -0600, Benjamin Marzinski wrote: > > Commit 6e2423fd fixed a bug where the tur checker could cancel a > > detached thread after it had exitted. However in fixing this, the new > > code grabbed a mutex (to

Re: [dm-devel] [PATCH 1/7] multipath: fix tur checker locking

2018-02-08 Thread Bart Van Assche
On Wed, 2018-02-07 at 16:49 -0600, Benjamin Marzinski wrote: > Commit 6e2423fd fixed a bug where the tur checker could cancel a > detached thread after it had exitted. However in fixing this, the new > code grabbed a mutex (to call condlog) while holding a spin_lock. To > deal with that, and to try

Re: [dm-devel] [PATCH 1/7] multipath: fix tur checker locking

2018-02-08 Thread Bart Van Assche
On Thu, 2018-02-08 at 11:52 -0600, Benjamin Marzinski wrote: > On Thu, Feb 08, 2018 at 09:49:20AM +0100, Martin Wilck wrote: > > On Wed, 2018-02-07 at 16:49 -0600, Benjamin Marzinski wrote: > > > + } else { > > > + /* locking here solely to make static > > > analyzers happy

Re: [dm-devel] [PATCH 1/7] multipath: fix tur checker locking

2018-02-08 Thread Benjamin Marzinski
On Thu, Feb 08, 2018 at 09:49:20AM +0100, Martin Wilck wrote: > Hello Ben, > > On Wed, 2018-02-07 at 16:49 -0600, Benjamin Marzinski wrote: > > Commit 6e2423fd fixed a bug where the tur checker could cancel a > > detached thread after it had exitted. However in fixing this, the new > > code grabbe

Re: [dm-devel] [PATCH 1/7] multipath: fix tur checker locking

2018-02-08 Thread Martin Wilck
Hello Ben, On Wed, 2018-02-07 at 16:49 -0600, Benjamin Marzinski wrote: > Commit 6e2423fd fixed a bug where the tur checker could cancel a > detached thread after it had exitted. However in fixing this, the new > code grabbed a mutex (to call condlog) while holding a spin_lock. To > deal with that

[dm-devel] [PATCH 1/7] multipath: fix tur checker locking

2018-02-07 Thread Benjamin Marzinski
Commit 6e2423fd fixed a bug where the tur checker could cancel a detached thread after it had exitted. However in fixing this, the new code grabbed a mutex (to call condlog) while holding a spin_lock. To deal with that, and to try to keep with the maixim "lock data, not code", I've changed how the