Re: [dm-devel] [PATCH] block: fix an integer overflow in logical block size

2020-06-02 Thread Eric Biggers
On Wed, Jan 15, 2020 at 08:35:25AM -0500, Mikulas Patocka wrote: > Logical block size has type unsigned short. That means that it can be at > most 32768. However, there are architectures that can run with 64k pages > (for example arm64) and on these architectures, it may be possible to > create

Re: [dm-devel] [PATCH] block: fix an integer overflow in logical block size

2020-01-15 Thread Jens Axboe
On 1/15/20 6:35 AM, Mikulas Patocka wrote: > Logical block size has type unsigned short. That means that it can be at > most 32768. However, there are architectures that can run with 64k pages > (for example arm64) and on these architectures, it may be possible to > create block devices with 64k

Re: [dm-devel] [PATCH] block: fix an integer overflow in logical block size

2020-01-15 Thread Ming Lei
On Wed, Jan 15, 2020 at 08:35:25AM -0500, Mikulas Patocka wrote: > Logical block size has type unsigned short. That means that it can be at > most 32768. However, there are architectures that can run with 64k pages > (for example arm64) and on these architectures, it may be possible to > create

Re: [dm-devel] [PATCH] block: fix an integer overflow in logical block size

2020-01-15 Thread Martin K. Petersen
Mikulas, > This patch changes the logical block size from unsigned short to > unsigned int to avoid the overflow. Looks fine. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com