Re: [dm-devel] [PATCH] multipath-tools tests: fix stringop-overflow build errors with gcc 11
On Wed, 2021-02-10 at 15:18 +0100, Martin Wilck wrote: > > I'm told that this issue is related to this glibc bug: > https://sourceware.org/bugzilla/show_bug.cgi?id=26647 > > and should be fixed in glibc 2.33. Yet adding this patch doesn't hurt > us and can serve as a workaround for environments with gcc 11. Christophe, I've pushed this to my "fixes" branch. Regards Martin -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
Re: [dm-devel] [PATCH] multipath-tools tests: fix stringop-overflow build errors with gcc 11
On Wed, 2021-02-10 at 13:24 +0100, mwi...@suse.com wrote: > From: Martin Wilck > > gcc-11 throws an error compiling alias.c and dmevents.c: > > In file included from ../libmultipath/checkers.h:4, > from ../libmultipath/prio.h:7, > from ../libmultipath/structs.h:8, > from dmevents.c:29: > ../multipathd/dmevents.c: In function 'dmevent_loop': > ../multipathd/dmevents.c:357:17: error: '__sigsetjmp' accessing 200 > bytes in a region of size 72 [-Werror=stringop-overflow=] > 357 | pthread_cleanup_push(cleanup_lock, > >vecs->lock); > | ^~~~ > ../multipathd/dmevents.c:357:17: note: referencing argument 1 of type > 'struct __jmp_buf_tag *' > /usr/include/pthread.h:734:12: note: in a call to function > '__sigsetjmp' > 734 | extern int __sigsetjmp (struct __jmp_buf_tag *__env, int > __savemask) __THROWNL; > | ^~~ > > The reason seems to be a mismatch between the __sigsetjmp() prototype > in and . Until this is fixed in the toolchain, > work around it by including first. > > Signed-off-by: Martin Wilck I'm told that this issue is related to this glibc bug: https://sourceware.org/bugzilla/show_bug.cgi?id=26647 and should be fixed in glibc 2.33. Yet adding this patch doesn't hurt us and can serve as a workaround for environments with gcc 11. Regards Martin -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
Re: [dm-devel] [PATCH] multipath-tools tests: fix stringop-overflow build errors with gcc 11
On Wed, Feb 10, 2021 at 01:24:57PM +0100, mwi...@suse.com wrote: > From: Martin Wilck > > gcc-11 throws an error compiling alias.c and dmevents.c: > > In file included from ../libmultipath/checkers.h:4, > from ../libmultipath/prio.h:7, > from ../libmultipath/structs.h:8, > from dmevents.c:29: > ../multipathd/dmevents.c: In function 'dmevent_loop': > ../multipathd/dmevents.c:357:17: error: '__sigsetjmp' accessing 200 bytes in > a region of size 72 [-Werror=stringop-overflow=] > 357 | pthread_cleanup_push(cleanup_lock, > >vecs->lock); > | ^~~~ > ../multipathd/dmevents.c:357:17: note: referencing argument 1 of type 'struct > __jmp_buf_tag *' > /usr/include/pthread.h:734:12: note: in a call to function '__sigsetjmp' > 734 | extern int __sigsetjmp (struct __jmp_buf_tag *__env, int __savemask) > __THROWNL; > |^~~ > > The reason seems to be a mismatch between the __sigsetjmp() prototype > in and . Until this is fixed in the toolchain, > work around it by including first. > Reviewed-by: Benjamin Marzinski > Signed-off-by: Martin Wilck > --- > tests/alias.c| 1 + > tests/dmevents.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/tests/alias.c b/tests/alias.c > index 0311faa..5e0bfea 100644 > --- a/tests/alias.c > +++ b/tests/alias.c > @@ -1,3 +1,4 @@ > +#include > #include > #include > #include > diff --git a/tests/dmevents.c b/tests/dmevents.c > index b7c5122..29eaa6d 100644 > --- a/tests/dmevents.c > +++ b/tests/dmevents.c > @@ -16,6 +16,7 @@ > * > */ > > +#include > #include > #include > #include > -- > 2.29.2 -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
