Re: [dm-devel] [PATCH v3 1/7] libmultipath: fix tur checker locking

2018-02-13 Thread Benjamin Marzinski
On Tue, Feb 13, 2018 at 11:20:39AM +0100, Hannes Reinecke wrote: > On 02/13/2018 04:42 AM, Benjamin Marzinski wrote: > I would rather set 'ct->running' from within the thread; otherwise there > is a chance that pthread_create() returns without error, but the thread > itself hasn't been run yet.

Re: [dm-devel] [PATCH v3 1/7] libmultipath: fix tur checker locking

2018-02-13 Thread Hannes Reinecke
On 02/13/2018 04:42 AM, Benjamin Marzinski wrote: > Commit 6e2423fd fixed a bug where the tur checker could cancel a > detached thread after it had exitted. However in fixing this, the new > code grabbed a mutex (to call condlog) while holding a spin_lock. To > deal with this, I've done away with

Re: [dm-devel] [PATCH v3 1/7] libmultipath: fix tur checker locking

2018-02-13 Thread Martin Wilck
On Mon, 2018-02-12 at 21:42 -0600, Benjamin Marzinski wrote: > Commit 6e2423fd fixed a bug where the tur checker could cancel a > detached thread after it had exitted. However in fixing this, the new > code grabbed a mutex (to call condlog) while holding a spin_lock. To > deal with this, I've