Re: [dnsdist] reqresp.cpp:265:13: warning: duplicated 'if' condition [-Wduplicated-cond]

2019-01-30 Thread Remi Gacogne
Hello David, On 1/30/19 9:52 AM, David Binderman wrote: > Source code is > [...] > Suggest code rework. Thank you but YaHTTP is a third-party library and we try to stay in sync with upstream, you might want to send your suggestion to [1]. [1]: https://github.com/cmouse/yahttp Best regards, --

[dnsdist] reqresp.cpp:265:13: warning: duplicated 'if' condition [-Wduplicated-cond]

2019-01-30 Thread David Binderman
Hello there, Source code is if (kind == YAHTTP_TYPE_REQUEST) { bool first = true; os << "Cookie: "; for(strcookie_map_t::const_iterator i = jar.cookies.begin(); i != jar.cookies.end(); i++) { if (first) first = false; else