Re: [Dnsmasq-discuss] [PATCH] Add support for unique TFTP root per MAC

2017-04-09 Thread Floris Bos
On 04/09/2017 11:28 PM, Simon Kelley wrote: Patch accepted, with one change snprintf(daemon->namebuff+oldlen, sizeof(daemon->namebuff)-oldlen, "%.2x-%.2x-%.2x-%.2x-%.2x-%.2x/", daemon->namebuff is a char *, so sizeof(daemon->namebuff) is 4 or 8 and sizeof(daemon->namebuff)-oldlen

Re: [Dnsmasq-discuss] [PATCH v2] Add --dhcp-reply-delay option to delay DHCP replies

2017-04-09 Thread Simon Kelley
On 30/03/17 12:38, Floris Bos wrote: > Adds option to delay replying to DHCP packets by one or more seconds. > This provides a workaround for a PXE boot firmware implementation > that has a bug causing it to fail if it receives a (proxy) DHCP > reply instantly. > > On Linux it looks up the exact

Re: [Dnsmasq-discuss] [PATCH] Add support for unique TFTP root per MAC

2017-04-09 Thread Simon Kelley
Patch accepted, with one change > snprintf(daemon->namebuff+oldlen, sizeof(daemon->namebuff)-oldlen, > "%.2x-%.2x-%.2x-%.2x-%.2x-%.2x/", daemon->namebuff is a char *, so sizeof(daemon->namebuff) is 4 or 8 and sizeof(daemon->namebuff)-oldlen is a negative number which is a large

Re: [Dnsmasq-discuss] dnsmasq & fingerbank.org

2017-04-09 Thread Simon Kelley
The current tree already has this functionality, though the code which implements it is somewhat different. It certainly provides a DNSMASQ_REQUESTED_OPTIONS variable containing a comma-separated list of decimal numbers. Best to look at the current code, and submit a patch if it doesn't behave as

Re: [Dnsmasq-discuss] dnsmasq treats Islands of Security as bogus

2017-04-09 Thread Simon Kelley
On 08/04/17 17:33, Patryk Szczygłowski wrote: > 2017-04-04 22:24 GMT+01:00 Simon Kelley : > >> Which version of dnsmasq are you using? I just tested this domain using >> the development code, and got the correct result. >> > > > dnsmasq - 2.73-3 > > This is the version

Re: [Dnsmasq-discuss] bug: trunk DHCP offer/replies being ignored by some devices

2017-04-09 Thread Simon Kelley
On 08/04/17 12:01, Floris Bos wrote: > On 04/08/2017 12:00 AM, Simon Kelley wrote: >> >> But RFC 6842 assures us that no clients are broken by this change :) >> >> The options here, as I see it are >> >> 1) revert the change and don't support 6842 >> 2) provide a way to disable the client-id reply

[Dnsmasq-discuss] dnsmasq & fingerbank.org

2017-04-09 Thread Denton Gentry
https://fingerbank.org/about.html is a database of OS signatures based on the DHCP options populated and the order in which they appear. So for example, an Android device will typically send '1,33,3,6,15,26,28,51,58,59' while iOS sends '1,3,6,15,119,252'. We modified dnsmasq to export DHCP OS