Re: [Dnsmasq-discuss] Is wrapping close() in retry_send() required ?

2019-03-29 Thread Simon Kelley
On 26/03/2019 19:33, Pali Rohár wrote: > On Wednesday 27 February 2019 17:07:21 Simon Kelley wrote: >> On 27/02/2019 15:06, Bogdan Harjoc wrote: >>> There are 50 calls to close() in dnsmasq-2.80, and 10 of them are >>> wrapped in retry_send(). >>> >>> "man close" has this paragraph in the section

Re: [Dnsmasq-discuss] Is wrapping close() in retry_send() required ?

2019-03-26 Thread Pali Rohár
On Wednesday 27 February 2019 17:07:21 Simon Kelley wrote: > On 27/02/2019 15:06, Bogdan Harjoc wrote: > > There are 50 calls to close() in dnsmasq-2.80, and 10 of them are > > wrapped in retry_send(). > > > > "man close" has this paragraph in the section "Dealing with error > > returns from

Re: [Dnsmasq-discuss] Is wrapping close() in retry_send() required ?

2019-02-27 Thread Simon Kelley
On 27/02/2019 15:06, Bogdan Harjoc wrote: > There are 50 calls to close() in dnsmasq-2.80, and 10 of them are > wrapped in retry_send(). > > "man close" has this paragraph in the section "Dealing with error > returns from close": > > "Retrying the close() after a failure return is the wrong

[Dnsmasq-discuss] Is wrapping close() in retry_send() required ?

2019-02-27 Thread Bogdan Harjoc
There are 50 calls to close() in dnsmasq-2.80, and 10 of them are wrapped in retry_send(). "man close" has this paragraph in the section "Dealing with error returns from close": "Retrying the close() after a failure return is the wrong thing to do, since this may cause a reused file descriptor