Re: [Dnsmasq-discuss] [PATCH] Fix parsing of IPv6 addresses with peer from netlink

2022-05-27 Thread Simon Kelley
The patch looks good to me. Applied. Cheers, Simon. On 19/05/2022 10:43, Beniamino Galvani wrote: On Wed, May 18, 2022 at 04:10:52PM +0200, Geert Stappers via Dnsmasq-discuss wrote: There new lines and one old line + if (rta->rta_type == IFA_LOCAL) +

Re: [Dnsmasq-discuss] [PATCH] Fix parsing of IPv6 addresses with peer from netlink

2022-05-19 Thread Beniamino Galvani
On Wed, May 18, 2022 at 04:10:52PM +0200, Geert Stappers via Dnsmasq-discuss wrote: > There new lines and one old line > > + if (rta->rta_type == IFA_LOCAL) > > + addrp = ((struct in6_addr *)(rta+1)); > > + else if (rta->rta_type ==

Re: [Dnsmasq-discuss] [PATCH] Fix parsing of IPv6 addresses with peer from netlink

2022-05-18 Thread Geert Stappers via Dnsmasq-discuss
On Wed, May 18, 2022 at 02:48:09PM +0200, Beniamino Galvani wrote: > --- a/src/netlink.c > +++ b/src/netlink.c > @@ -258,7 +258,9 @@ int iface_enumerate(int family, void *parm, int > (*callback)()) > > while (RTA_OK(rta, len1)) > { > -

[Dnsmasq-discuss] [PATCH] Fix parsing of IPv6 addresses with peer from netlink

2022-05-18 Thread Beniamino Galvani
In the most common case, an IPv6 address doesn't have a peer and the IFA_ADDRESS netlink attribute contains the address itself. But if the address has a peer (typically for point to point links), then IFA_ADDRESS contains the peer address and IFA_LOCAL contains the address [1]. [1]