Re: [Dnsmasq-discuss] code style, decision

2019-09-12 Thread Kristoffel Pirard
My 5 cents: 1. It saved my team a lot of discussion when we enforced a code formatter (e.g. clang-format). 2. 5 levels of indentation is way deeper than most humans can have in their heads simultaneously - functions are a great tool to alleviate this. On Thu, Sep 12, 2019 at 10:36 AM Dominik

Re: [Dnsmasq-discuss] code style, decision

2019-09-12 Thread Jan Psota
> If at all, I'd vote for converting the existing tabstops to 8 spaces > and keep the indentation step of 2 spaces per level. As Simon wrote, it is unnecessary. He uses 2-space indentation, as I can see, and every 8 spaces (32) are put with 1 tab (09). Nothing can go wrong if only editor is set

Re: [Dnsmasq-discuss] code style, decision

2019-09-12 Thread Dominik
If we change anything at all, we should not solely use tabspace. Imagine only when we're at level 5 in the code, this works mean 5*8=40 (useless) indentation space before the actual code starts. This makes the code rather unreadable when editing with CLI tools like vim where there is typically

Re: [Dnsmasq-discuss] code style, decision

2019-09-12 Thread Geert Stappers
On Wed, Sep 11, 2019 at 03:09:31PM -0700, Shota Hino wrote: > On Wed, Sep 11, 2019 at 2:49 PM Simon Kelley wrote: > > On 11/09/2019 22:12, Shota Hino wrote: > > > On Wed, Sep 11, 2019 at 2:05 PM Simon Kelley wrote: > > > > On 07/09/2019 18:21, john doe wrote: > > > > > some earlier postings: > >