Re: [Dnsmasq-discuss] patch review request, why

2019-11-10 Thread Kurt H Maier
On Mon, Nov 11, 2019 at 12:19:39AM +0100, Geert Stappers wrote: > > The assumption of harmless white space is wrong. Tooling > such as `git` warns about trailing spaces. Do This is bizarre logic. What makes git an authority on code formatting? Who elected the git maintainers into the style

Re: [Dnsmasq-discuss] patch review request, why

2019-11-10 Thread Geert Stappers
On Sun, Nov 10, 2019 at 01:01:35PM -0800, Kurt H Maier wrote: > On Sun, Nov 10, 2019 at 11:33:44AM +0100, Patch Submitter wrote: > > > > Imagine an open software project gets a patch submitted. > > Substantive patches tend to get more attention. At this point you've > sent one email for each

Re: [Dnsmasq-discuss] patch review request

2019-11-10 Thread Kurt H Maier
On Sun, Nov 10, 2019 at 11:33:44AM +0100, Patch Submitter wrote: > > Hi, > > Imagine an open software project gets a patch submitted. Substantive patches tend to get more attention. At this point you've sent one email for each harmless whitespace character you've proposed to delete. Why are

[Dnsmasq-discuss] Can dnsmasq use as standalone DNS server without any upstream DNS ?

2019-11-10 Thread Daein Park
Hi team, I'm testing whether dnsmasq can use standalone local DNS server. I'm consist with primary/secondary DNS using dnsmasq, but if one of any dnsmasq servers has been stopped, it's always delayed (5 timeout). When I configured DNS using bind(named), DNS latency has not been occurred. I also

[Dnsmasq-discuss] patch review request

2019-11-10 Thread Patch Submitter
Hi, Imagine an open software project gets a patch submitted. Project members are busy and decide to review the patch latter. And because busy people tend to be busy, the patch gets reviewed latter. The patch submitter is fully aware of it and waits somewhat longer. Then retransmitts happen.

[Dnsmasq-discuss] empty tailing lines

2019-11-10 Thread Geert Stappers
For which reason do have some .c files empty tailing lines? In-Reply-To: <1571002635-29803-1-git-send-email-stapp...@alpaca.gpm.stappers.nl> > > diff --git a/src/arp.c b/src/arp.c > index 6cfe014..66ecfb5 100644 > --- a/src/arp.c > +++ b/src/arp.c > @@ -230,5 +230,3 @@ int

Re: [Dnsmasq-discuss] dhcp-name-match ?

2019-11-10 Thread Geert Stappers
On Wed, Oct 30, 2019 at 09:32:14PM +, Simon Kelley wrote: > On 28/10/2019 02:45, James Feeney wrote: > > Hey Simon > > > > Thanks for that. Yes, that's it. > > > > I tried simply removing the dhcp-host hostname, and then the tag is > > added, as expected. > > > > Yes, that does not seem to be