Re: [Dnsmasq-discuss] space two point eighty one

2020-03-08 Thread Geert Stappers
On Sun, Mar 08, 2020 at 05:40:13PM +, Simon Kelley wrote: > On 05/03/2020 21:05, Geert Stappers wrote: > > > > ... "Removed useless whitespace" ... > > > > > > I just spent a couple of hours playing with the options to GNU ident, to > see if I could get it to clean up not just

Re: [Dnsmasq-discuss] space two point eighty one

2020-03-08 Thread Simon Kelley
On 05/03/2020 21:05, Geert Stappers wrote: > `git diff` is huge, almost 22000 lines. Yes, a huge clean-up. > > > I love to see that in the 2.81 release of dnsmasq. > > git commit -am "Removed useless whitespace" --author "Geert Stappers > " > > I just spent a couple of hours playing with

Re: [Dnsmasq-discuss] Patches DHCPv6

2020-03-08 Thread Geert Stappers
In-Reply-To: <20200207220832.dsvb5gtd5g2by4ob@pali> On Fri, Feb 07, 2020 at 11:08:32PM +0100, Pali Rohár wrote: > Hello Simon! > > Could you please review / comment this patch? > > I would like to know what is needed to be fixed or changed, > so patch could be finally merged. Other DHCPv6

Re: [Dnsmasq-discuss] Regarding: space two point eighty one, take 2

2020-03-08 Thread john doe
On 3/8/2020 5:17 PM, Geert Stappers wrote: > > Hello John, > > > On Sun, Mar 08, 2020 at 01:35:11PM +0100, john doe wrote: >> On 3/8/2020 12:33 PM, Geert Stappers wrote: >>> On Sat, Mar 07, 2020 at 10:01:30PM +0100, Geert Stappers wrote: In-Reply-To:

Re: [Dnsmasq-discuss] [PATCH] Add DHCPv6 NTP server option handling

2020-03-08 Thread Simon Kelley
On 07/03/2020 00:02, Vladislav Grishenko wrote: > Hi, Simon > > There was discussion in the past regarding DHCPv6 NTP server option which > needs special subclassing per RFC5908. > Patch adds support for unicast, multicast IPv6 address and for FQDN string, > preserving possibly used (as

Re: [Dnsmasq-discuss] [PATCH] DHCPv6 - List or Range reservation for single host

2020-03-08 Thread Simon Kelley
On 06/03/2020 22:10, Petr Menšík wrote: > Hi Simon, > > I have been adapting this feature to earlier releases and discovered one > error with prefixed address assignment. When it is calculating number of > addresses from prefixlen, it rotates only 32bit int instead of 64b uint. > Only result is

Re: [Dnsmasq-discuss] dnsmasq-2.81rc2 findings on macos

2020-03-08 Thread Simon Kelley
On 06/03/2020 09:52, Kevin 'ldir' Darbyshire-Bryant wrote: > Hi Simon, > > Some findings for you when building on 2.81rc2 on MacOS Catalina. Don’t know > how much of this is new as I only tried it as an experiment :-) > > This definitely looks wrong :-) > > rfc3315.c:1711:28: warning: use of

Re: [Dnsmasq-discuss] space two point eighty one, take 2

2020-03-08 Thread john doe
On 3/8/2020 12:33 PM, Geert Stappers wrote: > On Sat, Mar 07, 2020 at 10:01:30PM +0100, Geert Stappers wrote: >> In-Reply-To: <1255b7ff-351f-46d7-f811-ac3373102...@thekelleys.org.uk> >> On Thu, Mar 05, 2020 at 10:34:29PM +, Simon Kelley wrote: >>> On 05/03/2020 21:05, Geert Stappers wrote:

Re: [Dnsmasq-discuss] space two point eighty one, take 2

2020-03-08 Thread Geert Stappers
On Sat, Mar 07, 2020 at 10:01:30PM +0100, Geert Stappers wrote: > In-Reply-To: <1255b7ff-351f-46d7-f811-ac3373102...@thekelleys.org.uk> > On Thu, Mar 05, 2020 at 10:34:29PM +, Simon Kelley wrote: > > On 05/03/2020 21:05, Geert Stappers wrote: > > > On Thu, Mar 05, 2020 at 09:46:21PM +0100,