Re: [Dnsmasq-discuss] Fwd: no-ping

2024-02-20 Thread Simon Kelley
OK I committed to patch to this effect. https://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=commit;h=9adbf009a6df76d9ae5be2b93a90e210e9aa8216 Cheers, Simon. On 21/02/2024 00:13, Martin Ivičič wrote: I tested all the combinations:  - just --no-ping: dnsmasq: process is missing required

Re: [Dnsmasq-discuss] erroneously filtering A records after calling "SetFilterA false" over dbus

2024-02-20 Thread Simon Kelley
On 20/02/2024 19:06, Clayton Craft via Dnsmasq-discuss wrote: Using dnsmasq 2.90 + the patch to fix the infinite loop, it seems like filtering is applied when calling e.g., "SetFilterA false" over dbus. In the script below, the first lookup succeeds but subsequent lookups after the initial

Re: [Dnsmasq-discuss] Fwd: no-ping

2024-02-20 Thread Simon Kelley
That would work, I think. Please try it and report back. Simon. On 20/02/2024 23:53, Martin Ivičič wrote: Our intent is to run tests in CI where we can't use root user or set any capabilities (eventually we'll be running with --dhcp-alternate-port=1067,1068 as well) What do you think about

Re: [Dnsmasq-discuss] Fwd: no-ping

2024-02-20 Thread Martin Ivičič
I tested all the combinations: - just --no-ping: dnsmasq: process is missing required capability NET_ADMIN - --no-ping + --dhcp-broadcast=mgmt: dnsmasq: process is missing required capability NET_ADMIN - --no-ping + --dhcp-broadcast: works fine Best regards, Martin On Wed, Feb 21, 2024 at

Re: [Dnsmasq-discuss] Fwd: no-ping

2024-02-20 Thread Martin Ivičič
Our intent is to run tests in CI where we can't use root user or set any capabilities (eventually we'll be running with --dhcp-alternate-port=1067,1068 as well) What do you think about the following? diff --git a/src/dnsmasq.c b/src/dnsmasq.c index 30fb419..5969e01 100644 --- a/src/dnsmasq.c +++

Re: [Dnsmasq-discuss] Similar to bfefd6e38c6e, fix error introduced in 51471cafa5a4

2024-02-20 Thread Simon Kelley
Patch applied. Thanks. Simon. On 20/02/2024 08:32, renmingshuai via Dnsmasq-discuss wrote: From 81ed4df0eb1d70fc1ac5f94b5839f8cb45602ed0 Mon Sep 17 00:00:00 2001 From: renmingshuai Date: Tue, 20 Feb 2024 16:13:11 +0800 Subject: [PATCH] Fix error introduced in

[Dnsmasq-discuss] erroneously filtering A records after calling "SetFilterA false" over dbus

2024-02-20 Thread Clayton Craft via Dnsmasq-discuss
Using dnsmasq 2.90 + the patch to fix the infinite loop, it seems like filtering is applied when calling e.g., "SetFilterA false" over dbus. In the script below, the first lookup succeeds but subsequent lookups after the initial application of the filter fail to return anything.

Re: [Dnsmasq-discuss] Fwd: no-ping

2024-02-20 Thread Simon Kelley
Ah, this is working because you include --dhcp-broadcast, which avoids the ARP-cache access. I'm not clear why you want to avoid CAP_NET_ADMIN, but a correct patch to do that would only not set need_cap_netadmin when --broadcast is set, and only when it's set unconditionally, without tags.

[Dnsmasq-discuss] Similar to bfefd6e38c6e, fix error introduced in 51471cafa5a4

2024-02-20 Thread renmingshuai via Dnsmasq-discuss
>From 81ed4df0eb1d70fc1ac5f94b5839f8cb45602ed0 Mon Sep 17 00:00:00 2001 From: renmingshuai Date: Tue, 20 Feb 2024 16:13:11 +0800 Subject: [PATCH] Fix error introduced in 51471cafa5a4fa44d6fe490885d9910bd72a5907 Signed-off-by: renmingshuai --- src/dnssec.c | 4 ++-- 1 file changed, 2