Re: [Dnsmasq-discuss] code style
How do you feel about the mix usage of tab and leading white spaces? The code is mangled because some liens use a tab and some use white spaces. I do not think the choice of tab vs white spaces is code representation. On Wed, Sep 11, 2019 at 2:05 PM Simon Kelley wrote: > There seems to be confusion here between code style, and code > representation. > > Code style, ie layout, indent width, is not negotiable. > > Code representation is the use of tab characters at 8-character stops. > If your IDE or other device doesn't use 8 characher stops, it will > mangle code. That doesn't mean the code is badly formatted, it means > your display method is incompatible. > > It's quite possible to get around this by running expand on every > commit, so that only spaces are used in the repo. It's even possible to > run expand on every existing file, at the expense of polluting the logs. > I don't think there are any other downsides to this. > > Or people could configure IDEs and editors to use sane tab stops. > > Cheers, > > Simon. > > On 07/09/2019 18:21, john doe wrote: > > On 9/7/2019 6:25 PM, Shota Hino wrote: > >> Whatever the width of the tab is, converting all tabs to whitespaces (or > >> the other way around) would be better. > >> If code formatting was forced at the time of each commit, there would > be no > >> need for anybody to set the tab width on their editor. > >> Consistent coding style will help more developers in the future. > >> > >> > >> > > > > I agree, consistent code is best, clear guideline could be usefull for > > new code. > > Simon Kelley, the belligerent dictator of the Dnsmasq project will need > > to way in on such changes though. > > > > -- > > John Doe > > > > ___ > > Dnsmasq-discuss mailing list > > Dnsmasq-discuss@lists.thekelleys.org.uk > > http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss > > > > ___ > Dnsmasq-discuss mailing list > Dnsmasq-discuss@lists.thekelleys.org.uk > http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss > ___ Dnsmasq-discuss mailing list Dnsmasq-discuss@lists.thekelleys.org.uk http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss
Re: [Dnsmasq-discuss] code style
> > With tab stops set to 8, a single tab or eight spaces are just alternate > representations of the same thing, surely? Yes. But what I am asking in this thread is to use either tabs or white spaces (not both). If only one is used, the width of tab in IDE does not matter. Hence, I think this is a code style question request. *Shota Hino*Connectivity Software *m* 650-476-9668 *e* sh...@eero.com *eero LLC *660 3rd St, 4th Floor San Francisco, CA 94107 On Wed, Sep 11, 2019 at 2:49 PM Simon Kelley wrote: > On 11/09/2019 22:12, Shota Hino wrote: > > How do you feel about the mix usage of tab and leading white spaces? > > The code is mangled because some liens use a tab and some use white > spaces. > > I do not think the choice of tab vs white spaces is code representation. > > With tab stops set to 8, a single tab or eight spaces are just alternate > representations of the same thing, surely? > > > Simon > > > > > > > > > On Wed, Sep 11, 2019 at 2:05 PM Simon Kelley > <mailto:si...@thekelleys.org.uk>> wrote: > > > > There seems to be confusion here between code style, and code > > representation. > > > > Code style, ie layout, indent width, is not negotiable. > > > > Code representation is the use of tab characters at 8-character > stops. > > If your IDE or other device doesn't use 8 characher stops, it will > > mangle code. That doesn't mean the code is badly formatted, it means > > your display method is incompatible. > > > > It's quite possible to get around this by running expand on every > > commit, so that only spaces are used in the repo. It's even possible > to > > run expand on every existing file, at the expense of polluting the > logs. > > I don't think there are any other downsides to this. > > > > Or people could configure IDEs and editors to use sane tab stops. > > > > Cheers, > > > > Simon. > > > > On 07/09/2019 18:21, john doe wrote: > > > On 9/7/2019 6:25 PM, Shota Hino wrote: > > >> Whatever the width of the tab is, converting all tabs to > > whitespaces (or > > >> the other way around) would be better. > > >> If code formatting was forced at the time of each commit, there > > would be no > > >> need for anybody to set the tab width on their editor. > > >> Consistent coding style will help more developers in the future. > > >> > > >> > > >> > > > > > > I agree, consistent code is best, clear guideline could be usefull > for > > > new code. > > > Simon Kelley, the belligerent dictator of the Dnsmasq project will > > need > > > to way in on such changes though. > > > > > > -- > > > John Doe > > > > > > ___ > > > Dnsmasq-discuss mailing list > > > Dnsmasq-discuss@lists.thekelleys.org.uk > > <mailto:Dnsmasq-discuss@lists.thekelleys.org.uk> > > > http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss > > > > > > > ___ > > Dnsmasq-discuss mailing list > > Dnsmasq-discuss@lists.thekelleys.org.uk > > <mailto:Dnsmasq-discuss@lists.thekelleys.org.uk> > > http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss > > > > ___ Dnsmasq-discuss mailing list Dnsmasq-discuss@lists.thekelleys.org.uk http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss
Re: [Dnsmasq-discuss] code style
http://uncrustify.sourceforge.net/ is one, but any reasonable code formatter should be able to replace leading white-spaces with tabs or vice versa. I am surprised that nobody complained about this. On Fri, Sep 6, 2019 at 11:42 PM Geert Stappers wrote: > On Fri, Sep 06, 2019 at 10:09:51PM -0700, Shota Hino wrote: > > It seems the use of tabs are not consistent. > > On some IDE, the lines are misaligned and very difficult to read. > > > > Could you please run code formatter? > > Which code formatter have you in mind? > Does it have a default setting? > > > Groeten > Geert Stappers > -- > Leven en laten leven > > ___ > Dnsmasq-discuss mailing list > Dnsmasq-discuss@lists.thekelleys.org.uk > http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss > ___ Dnsmasq-discuss mailing list Dnsmasq-discuss@lists.thekelleys.org.uk http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss
[Dnsmasq-discuss] code style
It seems the use of tabs are not consistent. On some IDE, the lines are misaligned and very difficult to read. Could you please run code formatter? ___ Dnsmasq-discuss mailing list Dnsmasq-discuss@lists.thekelleys.org.uk http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss
Re: [Dnsmasq-discuss] code style
Whatever the width of the tab is, converting all tabs to whitespaces (or the other way around) would be better. If code formatting was forced at the time of each commit, there would be no need for anybody to set the tab width on their editor. Consistent coding style will help more developers in the future. On Sat, Sep 7, 2019 at 8:11 AM Geert Stappers wrote: > On Sat, Sep 07, 2019 at 10:41:34AM +0200, Dominik wrote: > > On Fri, 2019-09-06 at 22:09 -0700, Shota Hino wrote: > > > It seems the use of tabs are not consistent. > > > On some IDE, the lines are misaligned and very difficult to read. > > > > > > Could you please run code formatter? > > > > > Set your tab width to 8. With this setting, I'm not seeing > > inconsistencies in the dnsmasq codebase. > > :-) > > > The very same size of 8 characters for tab is documented > in the coding style of the Linux kernel. > > With > wget > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/plain/Documentation/process/coding-style.rst > we could (and should) add coding style definition to this project. > > Main reason is ending discussion on coding style is > to get more time on discussion how and where to improve Dnsmasq. > > > Cheers > Geert Stappers > > > ___ > Dnsmasq-discuss mailing list > Dnsmasq-discuss@lists.thekelleys.org.uk > http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss > ___ Dnsmasq-discuss mailing list Dnsmasq-discuss@lists.thekelleys.org.uk http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss
