Re: [Dnsmasq-discuss] [PATCH] Accept PKG_CONFIG from environment

2020-07-23 Thread John Ericson
On Wed, Jul 15, 2020, at 9:52 AM, Petr Menšík wrote: > Did you know both BSD make and GNU make allows to override variables on > command line? Yeah we are just going with that, based on the feedback so far. > However, should not be this updated > just by different PATH order? we have a prefixed

Re: [Dnsmasq-discuss] Fwd: [PATCH] Makefile: make variables overridable

2020-07-12 Thread John Ericson
On Sun, Jul 12, 2020, at 5:22 PM, Pali Rohár wrote: > > But why is this change needed at all? Are there some bugs in GNU make so > that macros/variables initialized by '=' cannot be overridden and > initialization with '?=' is fixing those bugs? Definitions with = can still be overridden on the

Re: [Dnsmasq-discuss] Fwd: [PATCH] Makefile: make variables overridable

2020-07-12 Thread John Ericson
On Sun, Jul 12, 2020, at 3:05 PM, Pali Rohár wrote: > "FOO ?= foo" syntax is not supported by POSIX make: > https://pubs.opengroup.org/onlinepubs/9699919799/utilities/make.html > > And requires some GNU Make extension. > > I guess because dnsmasq is supported also on non-GNU Make systems, it >

Re: [Dnsmasq-discuss] Fwd: [PATCH] Makefile: make variables overridable

2020-07-12 Thread John Ericson
Hi, I am another NixOS maintainer. Yes, it is true that ?= in makefiles is somewhat rare, and that we can work around this other ways. But it was I who proposed the ?= change on our side[1], so let say why I think it's the right choice: Most C packages don't use "?=" and do FOO ?= foo but