Re: [Dnsmasq-discuss] code style, decision

2019-09-12 Thread Kristoffel Pirard
My 5 cents: 1. It saved my team a lot of discussion when we enforced a code formatter (e.g. clang-format). 2. 5 levels of indentation is way deeper than most humans can have in their heads simultaneously - functions are a great tool to alleviate this. On Thu, Sep 12, 2019 at 10:36 AM Dominik

Re: [Dnsmasq-discuss] code style, decision

2019-09-12 Thread Jan Psota
> If at all, I'd vote for converting the existing tabstops to 8 spaces > and keep the indentation step of 2 spaces per level. As Simon wrote, it is unnecessary. He uses 2-space indentation, as I can see, and every 8 spaces (32) are put with 1 tab (09). Nothing can go wrong if only editor is set

Re: [Dnsmasq-discuss] code style, decision

2019-09-12 Thread Dominik
If we change anything at all, we should not solely use tabspace. Imagine only when we're at level 5 in the code, this works mean 5*8=40 (useless) indentation space before the actual code starts. This makes the code rather unreadable when editing with CLI tools like vim where there is typically

Re: [Dnsmasq-discuss] code style, decision

2019-09-12 Thread Geert Stappers
On Wed, Sep 11, 2019 at 03:09:31PM -0700, Shota Hino wrote: > On Wed, Sep 11, 2019 at 2:49 PM Simon Kelley wrote: > > On 11/09/2019 22:12, Shota Hino wrote: > > > On Wed, Sep 11, 2019 at 2:05 PM Simon Kelley wrote: > > > > On 07/09/2019 18:21, john doe wrote: > > > > > some earlier postings: > >

Re: [Dnsmasq-discuss] code style

2019-09-11 Thread Shota Hino
> > With tab stops set to 8, a single tab or eight spaces are just alternate > representations of the same thing, surely? Yes. But what I am asking in this thread is to use either tabs or white spaces (not both). If only one is used, the width of tab in IDE does not matter. Hence, I think this

Re: [Dnsmasq-discuss] code style

2019-09-11 Thread Simon Kelley
On 11/09/2019 22:12, Shota Hino wrote: > How do you feel about the mix usage of tab and leading white spaces? > The code is mangled because some liens use a tab and some use white spaces. > I do not think the choice of tab vs white spaces is code representation. With tab stops set to 8, a single

Re: [Dnsmasq-discuss] code style

2019-09-11 Thread Shota Hino
How do you feel about the mix usage of tab and leading white spaces? The code is mangled because some liens use a tab and some use white spaces. I do not think the choice of tab vs white spaces is code representation. On Wed, Sep 11, 2019 at 2:05 PM Simon Kelley wrote: > There seems to be

Re: [Dnsmasq-discuss] code style

2019-09-11 Thread Simon Kelley
There seems to be confusion here between code style, and code representation. Code style, ie layout, indent width, is not negotiable. Code representation is the use of tab characters at 8-character stops. If your IDE or other device doesn't use 8 characher stops, it will mangle code. That

Re: [Dnsmasq-discuss] code style, a wish

2019-09-07 Thread Geert Stappers
On Sat, Sep 07, 2019 at 09:25:25AM -0700, Shota Hino wrote: > On Sat, Sep 7, 2019 at 8:11 AM Geert Stappers wrote: > > On Sat, Sep 07, 2019 at 10:41:34AM +0200, Dominik wrote: > > > On Fri, 2019-09-06 at 22:09 -0700, Shota Hino wrote: > > > > It seems the use of tabs are not consistent. > > > >

Re: [Dnsmasq-discuss] code style

2019-09-07 Thread john doe
On 9/7/2019 6:25 PM, Shota Hino wrote: > Whatever the width of the tab is, converting all tabs to whitespaces (or > the other way around) would be better. > If code formatting was forced at the time of each commit, there would be no > need for anybody to set the tab width on their editor. >

Re: [Dnsmasq-discuss] code style

2019-09-07 Thread Kurt H Maier
On Sat, Sep 07, 2019 at 12:02:35AM -0700, Shota Hino wrote: > http://uncrustify.sourceforge.net/ is one, but any reasonable code > formatter should be able to replace leading white-spaces with tabs or vice > versa. > > I am surprised that nobody complained about this. Consider focusing on the

Re: [Dnsmasq-discuss] code style

2019-09-07 Thread Shota Hino
Whatever the width of the tab is, converting all tabs to whitespaces (or the other way around) would be better. If code formatting was forced at the time of each commit, there would be no need for anybody to set the tab width on their editor. Consistent coding style will help more developers in

Re: [Dnsmasq-discuss] code style

2019-09-07 Thread Geert Stappers
On Sat, Sep 07, 2019 at 10:41:34AM +0200, Dominik wrote: > On Fri, 2019-09-06 at 22:09 -0700, Shota Hino wrote: > > It seems the use of tabs are not consistent. > > On some IDE, the lines are misaligned and very difficult to read. > > > > Could you please run code formatter? > > > Set your tab

Re: [Dnsmasq-discuss] code style

2019-09-07 Thread Dominik
Set your tab width to 8. With this setting, I'm not seeing inconsistencies in the dnsmasq codebase. > In practice, settable tab stops were rather quickly replaced with fixed tab stops, de facto standardized at every multiple of 8 characters horizontally [...]

Re: [Dnsmasq-discuss] code style

2019-09-07 Thread M. Buecher
On 2019-09-07 09:02, Shota Hino wrote: >> On Fri, Sep 06, 2019 at 10:09:51PM -0700, Shota Hino wrote: >>> It seems the use of tabs are not consistent. >>> On some IDE, the lines are misaligned and very difficult to read. >>> >>> Could you please run code formatter? >> >> Which code formatter

Re: [Dnsmasq-discuss] code style

2019-09-07 Thread Shota Hino
http://uncrustify.sourceforge.net/ is one, but any reasonable code formatter should be able to replace leading white-spaces with tabs or vice versa. I am surprised that nobody complained about this. On Fri, Sep 6, 2019 at 11:42 PM Geert Stappers wrote: > On Fri, Sep 06, 2019 at 10:09:51PM

Re: [Dnsmasq-discuss] code style

2019-09-07 Thread Geert Stappers
On Fri, Sep 06, 2019 at 10:09:51PM -0700, Shota Hino wrote: > It seems the use of tabs are not consistent. > On some IDE, the lines are misaligned and very difficult to read. > > Could you please run code formatter? Which code formatter have you in mind? Does it have a default setting? Groeten