Re: [Dnsmasq-discuss] [PATCH] Logging of dhcp_script output

2017-05-10 Thread Petr Menšík
Dne 10.5.2017 v 00:14 Simon Kelley napsal(a): > On 09/05/17 18:49, Petr Menšík wrote: >> Hi Simon, >> >> sorry for a delay. We concluded that we do not like die on parse error >> even for dhcp script. It does always start up now unless script returns >> nonzero exit status. With this change, it

Re: [Dnsmasq-discuss] [PATCH] Logging of dhcp_script output

2017-05-09 Thread Simon Kelley
On 09/05/17 18:49, Petr Menšík wrote: > Hi Simon, > > sorry for a delay. We concluded that we do not like die on parse error > even for dhcp script. It does always start up now unless script returns > nonzero exit status. With this change, it would never start, until you > were able to figure out

Re: [Dnsmasq-discuss] [PATCH] Logging of dhcp_script output

2017-05-09 Thread Petr Menšík
Hi Simon, sorry for a delay. We concluded that we do not like die on parse error even for dhcp script. It does always start up now unless script returns nonzero exit status. With this change, it would never start, until you were able to figure out what is wrong with your script. Then fix the

Re: [Dnsmasq-discuss] [PATCH] Logging of dhcp_script output

2017-04-28 Thread Simon Kelley
On 24/04/17 15:42, Petr Mensik wrote: > Thank you for accepting that patches. I agree that some garbage is > far more likely to appear in dhcp-script mode. I would myself welcome > error log from wrong formatted lease file as well. If I understand it > well, that file will be overwritten after the

Re: [Dnsmasq-discuss] [PATCH] Logging of dhcp_script output

2017-04-24 Thread Petr Mensik
t;Simon Kelley" <si...@thekelleys.org.uk> > To: dnsmasq-discuss@lists.thekelleys.org.uk > Sent: Sunday, April 16, 2017 9:29:21 PM > Subject: Re: [Dnsmasq-discuss] [PATCH] Logging of dhcp_script output > > I like this. Yes, I know you can do it with shell magic, but this is

Re: [Dnsmasq-discuss] [PATCH] Logging of dhcp_script output

2017-04-23 Thread Simon Kelley
.org.uk> > To: dnsmasq-discuss@lists.thekelleys.org.uk > Sent: Sunday, April 16, 2017 9:29:21 PM > Subject: Re: [Dnsmasq-discuss] [PATCH] Logging of dhcp_script output > > I like this. Yes, I know you can do it with shell magic, but this is > easier and what I would expect to

Re: [Dnsmasq-discuss] [PATCH] Logging of dhcp_script output

2017-04-19 Thread Petr Mensik
- Original Message - From: "Simon Kelley" <si...@thekelleys.org.uk> To: dnsmasq-discuss@lists.thekelleys.org.uk Sent: Sunday, April 16, 2017 9:29:21 PM Subject: Re: [Dnsmasq-discuss] [PATCH] Logging of dhcp_script output I like this. Yes, I know you can do it

Re: [Dnsmasq-discuss] [PATCH] Logging of dhcp_script output

2017-04-16 Thread Simon Kelley
I like this. Yes, I know you can do it with shell magic, but this is easier and what I would expect to happen. I've changed the patch quite a lot: 1) Don't go to large effort to report "never happen" errors from pipe(), just silently handle them in the same way as fork() 2) Don't do any of this

Re: [Dnsmasq-discuss] [PATCH] Logging of dhcp_script output

2017-03-27 Thread Petr Mensik
, http://www.redhat.com/ email: pemen...@redhat.com PGP: 65C6C973 - Original Message - From: "Alex Xu" <alex_y...@yahoo.ca> To: dnsmasq-discuss@lists.thekelleys.org.uk Sent: Friday, March 24, 2017 7:19:04 PM Subject: Re: [Dnsmasq-discuss] [PATCH] Logging of dhcp_script ou

Re: [Dnsmasq-discuss] [PATCH] Logging of dhcp_script output

2017-03-24 Thread Alex Xu
On Fri, 24 Mar 2017 13:38:17 -0400 (EDT) Petr Mensik wrote: > Hi! > > Some guys using dnsmasq in virtual machines and OpenStack use custom > dhcp_script to manage leases of clients. However they complain if > there is anything wrong with them, then are just told broken pipe

[Dnsmasq-discuss] [PATCH] Logging of dhcp_script output

2017-03-24 Thread Petr Mensik
Hi! Some guys using dnsmasq in virtual machines and OpenStack use custom dhcp_script to manage leases of clients. However they complain if there is anything wrong with them, then are just told broken pipe and no information. We understand it should not produce any output under normal