Re: [Dnsmasq-discuss] [PATCH] cname no longer accepts trailing dot

2018-02-27 Thread Petr Menšík
Sure, I know it will accept any whitespace characted, not just spaces. But no whitespace character is allowed to be in a DNS name. Let alone begin with it. These spaces can be in configuration file, where TAB is not unusual thing. I want any of them to be ignored. If they are not, dnsmasq will

Re: [Dnsmasq-discuss] [PATCH] cname no longer accepts trailing dot

2018-02-26 Thread Pali Rohár
On Monday 26 February 2018 19:59:53 Petr Menšík wrote: > - for (arg += strlen(arg)+1; *arg == ' '; arg++); > + for (arg += arglen+1; *arg && isspace(*arg); arg++); Hi! Just one note about this change. Function isspace() is implemented according to current locale and basically

[Dnsmasq-discuss] [PATCH] cname no longer accepts trailing dot

2018-02-26 Thread Petr Menšík
Hi Simon, I got reported bug in Fedora [1], that cname is broken in new releases. At first I though this was false report, but there is still new regression in cname handling. Before, it accepted alias with trailing dot. Not it would accept only target, but not alias. cname=alias.,target is no