Re: [Dnsmasq-discuss] [PATCH v2] Change dhcp_release to use default address when no IP subnet matches

2019-10-07 Thread Simon Kelley
Petr's patch applied also. Simon. On 01/10/2019 15:24, Petr Mensik wrote: > Hi Brian and Simon, > > I have one objection here. I think the tool should never end without > sending the request or showing some error. There is still one case left, > where it would do nothing and still exit

Re: [Dnsmasq-discuss] [PATCH v2] Change dhcp_release to use default address when no IP subnet matches

2019-10-01 Thread Brian Haley
On 10/1/19 10:24 AM, Petr Mensik wrote: Hi Brian and Simon, I have one objection here. I think the tool should never end without sending the request or showing some error. There is still one case left, where it would do nothing and still exit without error. I admit it would be rare, as IPv4

Re: [Dnsmasq-discuss] [PATCH v2] Change dhcp_release to use default address when no IP subnet matches

2019-10-01 Thread Petr Mensik
Hi Brian and Simon, I have one objection here. I think the tool should never end without sending the request or showing some error. There is still one case left, where it would do nothing and still exit without error. I admit it would be rare, as IPv4 address has to be missing on given device.

Re: [Dnsmasq-discuss] [PATCH v2] Change dhcp_release to use default address when no IP subnet matches

2019-08-30 Thread Simon Kelley
That looks fine. Patch applied. Cheers, Simon. On 28/08/2019 21:13, haleyb@gmail.com wrote: > From: Brian Haley > > Currently, dhcp_release will only send a 'fake' release > when the address given is in the same subnet as an IP > on the interface that was given. > > This doesn't work

[Dnsmasq-discuss] [PATCH v2] Change dhcp_release to use default address when no IP subnet matches

2019-08-28 Thread haleyb . dev
From: Brian Haley Currently, dhcp_release will only send a 'fake' release when the address given is in the same subnet as an IP on the interface that was given. This doesn't work in an environment where dnsmasq is managing leases for remote subnets via a DHCP relay, as running dhcp_release