Re: [Dnsmasq-discuss] rr_on_list stuck in infinite loop, dnsmasq unresponsive

2024-02-19 Thread Clayton Craft
> https://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=commit;h=89aad014685161318318737dc0e350ee4dae982d > > should fix this. Nice, ya seems to fix it for me. Thanks a lot for the quick fix! -Clayton signature.asc Description: PGP signature ___

Re: [Dnsmasq-discuss] rr_on_list stuck in infinite loop, dnsmasq unresponsive

2024-02-19 Thread Simon Kelley
Wow, excellent bug report, thank you. Took me straight to the stupid error. src/dbus.c around line 834. The code block controlled by "if (!done)" should include the line "done = 1;" Same thing below for filter . I'll push the patch directly. Cheers, Simon. On 19/02/2024 21:29,

Re: [Dnsmasq-discuss] rr_on_list stuck in infinite loop, dnsmasq unresponsive

2024-02-19 Thread Simon Kelley
https://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=commit;h=89aad014685161318318737dc0e350ee4dae982d should fix this. Simon. On 19/02/2024 23:16, Simon Kelley wrote: Wow, excellent bug report, thank you. Took me straight to the stupid error. src/dbus.c around line 834. The code block

Re: [Dnsmasq-discuss] rr_on_list stuck in infinite loop, dnsmasq unresponsive

2024-02-19 Thread Clayton Craft
On Mon, 19 Feb 2024 13:29:44 -0800 Clayton Craft wrote: > The conditions to trigger this aren't well understood by me... it seems to > happen when we use dnsmasq's dbus interface to toggle filtering ("set_filter A > bool"). But I've had trouble reproducing it manually. We hit it a lot when >

[Dnsmasq-discuss] rr_on_list stuck in infinite loop, dnsmasq unresponsive

2024-02-19 Thread Clayton Craft
It seems like sometimes the rrlist given to rr_on_list can be a circular linked list: 0xbbf57044 in rr_on_list (list=0xbbfe1990 , rr=5) at util.c:120 120 while (list) (gdb) p list $1 = (struct rrlist *) 0xbbfe1990 (gdb) p list.next $3 = (struct