[Dnsmasq-discuss] Infinite(?) RTR-ADVERTs being sent out [in Ubuntu NetworkManager testuite]

2018-12-20 Thread Iain Lane
Hi there, Forgive my ignorance on all matters dnsmasq/ipv6 - I'm coming to this from the 'desktop' end and I've not got much experience here. We noticed in Ubuntu that our NetworkManager testsuite started failing once we had copied dnsmasq 2.80-1 from unstable. What this testsuite does (you can

Re: [Dnsmasq-discuss] Infinite(?) RTR-ADVERTs being sent out [in Ubuntu NetworkManager testuite]

2018-12-20 Thread Iain Lane
On Thu, Dec 20, 2018 at 01:06:30PM +, Iain Lane wrote: > dnsmasq-dhcp[2010]: RTR-ADVERT(veth42) 2600:: > > repeating over and over. You can view a log file including all the > dnsmasq log entries at [2] - it's huge though, so I suggest downloading > it and using a real text editor instead

Re: [Dnsmasq-discuss] Patch to cache SRV records - updated version (#3)

2018-12-20 Thread Donald Muller
I think this should be added to the code maybe with an option in the config file to turn on the caching of these records. > -Original Message- > From: Dnsmasq-discuss > On Behalf Of Jeremy Allison > Sent: Thursday, December 20, 2018 4:39 PM > To: dnsmasq-discuss@lists.thekelleys.org.uk

Re: [Dnsmasq-discuss] Patch to cache SRV records - updated version (#3)

2018-12-20 Thread Simon Kelley
This is worth having for the removal of the archaic 16-bit limit on the flags field in a cache record alone. I've been meaning to tackle that for some time. This time of year either frees up lots of time for coding, or yields none at all, and for me it's the later, but I will go through this and

Re: [Dnsmasq-discuss] Infinite(?) RTR-ADVERTs being sent out [in Ubuntu NetworkManager testuite]

2018-12-20 Thread Simon Kelley
Patch below is untested because I'm away from my test rig, but it would seem to do the right thing, ie set template->if_index _before_ calling ra_start_unsolicited() so that if we re-enter here via an async event it doesn't get called again. If you could test it in your harness, that would be

Re: [Dnsmasq-discuss] Patch to cache SRV records - updated version (#3)

2018-12-20 Thread Jeremy Allison
On 12/20/2018 12:20 PM, Jeremy Allison wrote: > On Thu, 20 Dec 2018 11:53:11 -0800 > > Jeremy Allison wrote: > >> I know dnsmasq doesn't cache SRV records by design: >> >> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=579536;msg=9 >> >> However, when used with Samba code (winbindd) and >>

Re: [Dnsmasq-discuss] Patch to cache SRV records - updated version.

2018-12-20 Thread Paul Smith
On Thu, 2018-12-20 at 12:20 -0800, Jeremy Allison wrote: > Sigh. Found a bug when testing. free_mx_srv_record() > wasn't checking for NULL pointers on free(), > which can be the case for negative cache > records. C has required free(NULL) to be a no-op since ANSI C 1989/ISO C 1990... Is dnsmasq