Hello,
As I'm reading through dnsmasq's codebase, something that bothers me is the
mix of tabs and spaces and also the trailing whitespace.
There are tools that make it easy to adhere to a coding style, so this
issue can be fixed quite easily.
For example, http://astyle.sourceforge.net/ could be u
On 9/26/2019 12:23 PM, kingarley . wrote:
> Hello,
>
> As I'm reading through dnsmasq's codebase, something that bothers me is the
> mix of tabs and spaces and also the trailing whitespace.
> There are tools that make it easy to adhere to a coding style, so this
> issue can be fixed quite easily.
>
Thanks, John
I've just read through it, I'm surprised there is no solution to it
especially since it's so easy to fix it and clearly I'm not the only one
bothered by this.
What about the issue regarding trailing whitespaces? There are empty lines
which have random tabs/spaces, also there are space
On Thu, Sep 26, 2019 at 03:10:00PM +0300, Ariel Miculas wrote:
> What about the issue regarding trailing whitespaces? There are empty lines
> which have random tabs/spaces, also there are spaces before newline
> characters.
> What is the rationale against removing trailing whitespaces?
This stuff
It's perfectly valid to have multiple distinct prefixes configured on an
interface, so just remembering one subnet isn't good enough in the
general case. Although it's certainly an improvement over a single address.
I think a complete fix would be to remember all (interface, prefix)
pairs th
On 26-09-2019 18:03, Kurt H Maier wrote:
On Thu, Sep 26, 2019 at 03:10:00PM +0300, Ariel Miculas wrote:
What about the issue regarding trailing whitespaces? There are empty lines
which have random tabs/spaces, also there are spaces before newline
characters.
What is the rationale against remov
On Thu, Sep 26, 2019 at 07:47:45PM +0200, Maarten de Vries wrote:
>
> On 26-09-2019 18:03, Kurt H Maier wrote:
>
> Which is my it matters for open source projects. There will be people
> with broken tooling that commit trailing whitespace.
The consequences of which range, of course, from absent
On 9/26/2019 7:47 PM, Maarten de Vries wrote:
>
> On 26-09-2019 18:03, Kurt H Maier wrote:
>> On Thu, Sep 26, 2019 at 03:10:00PM +0300, Ariel Miculas wrote:
>>> What about the issue regarding trailing whitespaces? There are empty
>>> lines
>>> which have random tabs/spaces, also there are spaces be