Re: [Dnsmasq-discuss] [PATCH] dnsmasq unit tests!

2020-05-12 Thread Geert Stappers
On Mon, May 04, 2020 at 05:02:38PM +0200, Petr Menšík wrote: > Hello everyone, > > we have merged support for multiple IPv6 addresses to our release in > RHEL. We tried to ensure it does not break anything and we failed. > > I made already some dnsmasq tests in separate repository [1], running in

Re: [Dnsmasq-discuss] Regression in 2.81 related to support for multiple IPv6 addresses - [PATCH 1/1] Fix regression in s_config_in_context() method

2020-05-12 Thread Geert Stappers
On Thu, May 07, 2020 at 04:14:03PM +0200, Petr Menšík wrote: > Checked this fix with help of my new unit test, it indeed fixes the > issue correctly. With significantly lower CPU usage than previous fixes. \o/ woot woot \o/ Yes twice. One for "unit test" the other for "lower CPU usage

[Dnsmasq-discuss] [PATCH] Fix regression in s_config_in_context() method

2020-05-12 Thread Geert Stappers
From: Harald Jensås Prior to commit 137286e9baecf6a3ba97722ef1b49c851b531810 a config would not be considered in context if: a) it has no address family flags set b) it has the address family flag of current context set Since above commit config is considered in context if the address family is

Re: [Dnsmasq-discuss] Regression in 2.81 related to support for multiple IPv6 addresses - [PATCH 1/1] Fix regression in s_config_in_context() method

2020-05-12 Thread Geert Stappers
On Tue, May 12, 2020 at 10:19:46PM +0200, Geert Stappers wrote: > On Thu, May 07, 2020 at 04:14:03PM +0200, Petr Menšík wrote: > > Please skip my previous patches in this thread and original Harald's > > patch. This one is one is correct. > > I'm forging something that is plain the git commit. O