When ubus_add_object fails, the ubus_connect object is not freed, so the
connection leaks. Add ubus_destroy to free the connection object.
Signed-off-by: Oldřich Jedlička
---
src/ubus.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/ubus.c b/src/ubus.c
index 79e2563..c7f6b19 100644
Hi,
This is my first patch here. I discovered one resource leak in ubus_init, when
ubus_add_object fails - the ubus connection stays open. I added a patch, see
follow-up email. (Hopefully git send-email sends it.)
Regards,
Oldrich.
Oldřich Jedlička (1):
Fixed resource leak on ubus_init
possible to change the registered name, like for the D-Bus case.
Tested on OpenWrt.
Regards,
Oldrich.
Oldřich Jedlička (1):
Allow overriding of ubus service name.
man/dnsmasq.8 | 7 +--
src/config.h | 1 +
src/dnsmasq.h | 1 +
src/option.c | 14 +++---
src/ubus.c| 3 ++-
5
Same as for the dbus, allow specifying ubus service name (namespace) on
the command line as an optional argument to --enable-ubus option.
Signed-off-by: Oldřich Jedlička
---
man/dnsmasq.8 | 7 +--
src/config.h | 1 +
src/dnsmasq.h | 1 +
src/option.c | 14 +++---
src/ubus.c
Great, thanks :-)
Oldrich.
so 28. 3. 2020 v 20:23 odesílatel Simon Kelley
napsal:
> Patch applied, thanks.
>
>
> Simon.
>
>
> On 20/03/2020 21:18, Oldřich Jedlička wrote:
> > Same as for the dbus, allow specifying ubus service name (namespace) on
> > the comman