Re: [Dnsmasq-discuss] [PATCH] Add new extensible D-Bus signal

2020-04-30 Thread Kostadin Rangelov
Von meinem iPhone gesendet ___ Dnsmasq-discuss mailing list Dnsmasq-discuss@lists.thekelleys.org.uk http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss

[Dnsmasq-discuss] [PATCH] Add new extensible D-Bus signal

2020-04-02 Thread Victorien Molle
For our usage, we need to have more informations sent over D-Bus such as the interface name, the vendor class identifier and the lease expiration time. To achieve this, we add a new D-Bus signal "DhcpLeaseNotification" which exports the requested informations as a dictionnary. It also has the

Re: [Dnsmasq-discuss] [PATCH] Add new extensible D-Bus signal

2020-04-02 Thread Victorien Molle
Hello Simon, sorry for the late reply, this subject has completely popped out of my mind since I faced medical issues a few days after your reply. Fortunately, I found a new patch on my computer that almost does what you want. I'll look at it today, test it and try to send it if everything is

Re: [Dnsmasq-discuss] [PATCH] Add new extensible D-Bus signal

2020-02-20 Thread Simon Kelley
On 13/02/2020 13:58, Victorien Molle wrote: > Hello Simon, > > this is not the final patch. I rewrote the way to build extensible dictionary > to be able to > add a vendorclass n times when in IPv6 mode. > > Moreover, as I don't really work with IPv6, I don't know if the IPv6 part of > the

[Dnsmasq-discuss] [PATCH] Add new extensible D-Bus signal

2020-02-13 Thread Victorien Molle
For our usage, we need to have more informations sent over D-Bus such as the interface name, the vendor class identifier and the lease expiration time. To achieve this, we add a new D-Bus signal "DhcpLeaseNotification" which exports the requested informations as a dictionnary. It also has the

Re: [Dnsmasq-discuss] [PATCH] Add new extensible D-Bus signal

2020-02-13 Thread Victorien Molle
Hello Simon, this is not the final patch. I rewrote the way to build extensible dictionary to be able to add a vendorclass n times when in IPv6 mode. Moreover, as I don't really work with IPv6, I don't know if the IPv6 part of the code is correct. I faced multiple issues: 1) I don't really

Re: [Dnsmasq-discuss] [PATCH] Add new extensible D-Bus signal

2020-01-16 Thread Victorien Molle
Hi Simon, it's OK for 1 and 2 but I need your feedback about point 3: Do you prefer to wrap lines that require scripting compilation option (e.g.: to obtain vendor_class information)? Or do I leave the DBus code as is (including fixes of steps 1 and 2) and add "|| HAVE_DBUS" to all necessary

Re: [Dnsmasq-discuss] [PATCH] Add new extensible D-Bus signal

2020-01-10 Thread Simon Kelley
I'm happy with this in principle, a few things need to be looked at 1) lease->last_interface to interface name conversion should be done using indextoname(), see helper.c line 779 as an example. 2) the addition of the new signal to the introspection data should be inside the #ifdef HAVE_DHCP,

Re: [Dnsmasq-discuss] [PATCH] Add new extensible D-Bus signal

2020-01-09 Thread Florent Fourcot
Hello, On 09/01/2020 12:10, Pali Rohár wrote: Hello! I looked at this API, but is has same problems as old one. It is not possible to extend it in future (if it would be needed). Could you please design API in way that can be extended in future? (See my previous email with details how to

Re: [Dnsmasq-discuss] [PATCH] Add new extensible D-Bus signal

2020-01-09 Thread Pali Rohár
On Thursday 09 January 2020 12:17:52 Florent Fourcot wrote: > Hello, > > On 09/01/2020 12:10, Pali Rohár wrote: > > Hello! I looked at this API, but is has same problems as old one. It is > > not possible to extend it in future (if it would be needed). Could you > > please design API in way that

Re: [Dnsmasq-discuss] [PATCH] Add new extensible D-Bus signal

2020-01-09 Thread Pali Rohár
On Thursday 09 January 2020 11:15:09 Florent Fourcot wrote: > Hello Simon, > > On 06/12/2019 10:53, Victorien Molle wrote: > > For our usage, we need to have more informations sent over D-Bus such as > > the interface > > name, the vendor class identifier and the lease expiration time. > > > >

Re: [Dnsmasq-discuss] [PATCH] Add new extensible D-Bus signal

2020-01-09 Thread Florent Fourcot
Hello Simon, On 06/12/2019 10:53, Victorien Molle wrote: For our usage, we need to have more informations sent over D-Bus such as the interface name, the vendor class identifier and the lease expiration time. To achieve this, we add a new D-Bus signal "DhcpLeaseNotification" which exports

[Dnsmasq-discuss] [PATCH] Add new extensible D-Bus signal

2019-12-06 Thread Victorien Molle
For our usage, we need to have more informations sent over D-Bus such as the interface name, the vendor class identifier and the lease expiration time. To achieve this, we add a new D-Bus signal "DhcpLeaseNotification" which exports the requested informations as a dictionnary. It also has the