Re: [Dnsmasq-discuss] [PATCH] Add support for unique TFTP root per MAC

2017-04-11 Thread Simon Kelley
On 10/04/17 00:09, Floris Bos wrote: > On 04/09/2017 11:28 PM, Simon Kelley wrote: >> Patch accepted, with one change >> >> >>> snprintf(daemon->namebuff+oldlen, >>> sizeof(daemon->namebuff)-oldlen, "%.2x-%.2x-%.2x-%.2x-%.2x-%.2x/", >> >> daemon->namebuff is a char *, so

Re: [Dnsmasq-discuss] [PATCH] Add support for unique TFTP root per MAC

2017-04-09 Thread Floris Bos
On 04/09/2017 11:28 PM, Simon Kelley wrote: Patch accepted, with one change snprintf(daemon->namebuff+oldlen, sizeof(daemon->namebuff)-oldlen, "%.2x-%.2x-%.2x-%.2x-%.2x-%.2x/", daemon->namebuff is a char *, so sizeof(daemon->namebuff) is 4 or 8 and sizeof(daemon->namebuff)-oldlen

Re: [Dnsmasq-discuss] [PATCH] Add support for unique TFTP root per MAC

2017-04-09 Thread Simon Kelley
Patch accepted, with one change > snprintf(daemon->namebuff+oldlen, sizeof(daemon->namebuff)-oldlen, > "%.2x-%.2x-%.2x-%.2x-%.2x-%.2x/", daemon->namebuff is a char *, so sizeof(daemon->namebuff) is 4 or 8 and sizeof(daemon->namebuff)-oldlen is a negative number which is a large