Re: [Dnsmasq-discuss] [PATCH] Fix some errors and warnings from clang-analyzer

2017-10-19 Thread Rosen Penev
Zombie revive: I was checking a different project with clang-analyzer which reminded me of this. Line in question that it complained about was this one: strncat (build_opts_new, " -cl-opt-disable", sizeof (build_opts_new) - 1); The error was: Potential buffer overflow. Replace with 'sizeof(bui

Re: [Dnsmasq-discuss] [PATCH] Fix some errors and warnings from clang-analyzer

2017-10-05 Thread rosenp
On Thu, 2017-10-05 at 09:48 +0200, Pali Rohár wrote: > On Wednesday 04 October 2017 19:22:11 Rosen Penev wrote: > > diff --git a/src/cache.c b/src/cache.c > > index 4f43246..88851e7 100644 > > --- a/src/cache.c > > +++ b/src/cache.c > > @@ -572,7 +572,7 @@ struct crec *cache_insert(char *name, stru

Re: [Dnsmasq-discuss] [PATCH] Fix some errors and warnings from clang-analyzer

2017-10-05 Thread Pali Rohár
On Wednesday 04 October 2017 19:22:11 Rosen Penev wrote: > diff --git a/src/cache.c b/src/cache.c > index 4f43246..88851e7 100644 > --- a/src/cache.c > +++ b/src/cache.c > @@ -572,7 +572,7 @@ struct crec *cache_insert(char *name, struct all_addr > *addr, > } > >if (name) > -strcpy(c

Re: [Dnsmasq-discuss] [PATCH] Fix some errors and warnings from clang-analyzer

2017-10-05 Thread Pali Rohár
On Thursday 05 October 2017 01:41:02 ros...@gmail.com wrote: > On Thu, 2017-10-05 at 09:48 +0200, Pali Rohár wrote: > > On Wednesday 04 October 2017 19:22:11 Rosen Penev wrote: > > > diff --git a/src/cache.c b/src/cache.c > > > index 4f43246..88851e7 100644 > > > --- a/src/cache.c > > > +++ b/src/c