Re: [Dnsmasq-discuss] Announce: dnsmasq-2.76
On 21/05/16 11:53, Matthias Andree wrote:
> Good to know, and thanks for looking.
>
> I took a false positive into account especially on the FreeBSD 9.3
> warnings that are gone on 10.1; FreeBSD 9.3 uses a pretty old GCC
> version ("cc (GCC) 4.2.1 20070831 patched [FreeBSD]", ISTR it branched
> off before a license change), while FreeBSD 10.1 and 10.3 use clang
> 3.4.1. We can use other compilers, but I find it unnecessary to do for
> most projects written in C, it's more interesting for computing business
> when you're into OpenMP, C++11 or newer and the likes.
gcc 4.84 with the same flags doesn't generate any warnings.
>
>
>> Coverity builds under Linux, so the BSD-only code in the tree is not
>> checked that way, unfortunately.
>
> How much code is that, aside from a few API calls?
> I never bothered to take a closer look.
The whole of src/bpf.c and src/tables.c are BSD-specific.
Cheers,
Simon.
>
>> Thanks for committing 2.76.
>
> My pleasure.
>
> Cheers,
> Matthias
>
> ___
> Dnsmasq-discuss mailing list
> Dnsmasq-discuss@lists.thekelleys.org.uk
> http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss
>
___
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss
Re: [Dnsmasq-discuss] Announce: dnsmasq-2.76
Am 20.05.2016 um 23:03 schrieb Simon Kelley:
> Apologies for jumping the gun on you. As a general thing, a quick email
> in reply to an rc1 announcement is enough to hold things until an issue
> has been addressed.
>
> I checked those warnings, and they're all false positives. The static
> analysis is clever, but not clever enough.
Hi Simon,
Good to know, and thanks for looking.
I took a false positive into account especially on the FreeBSD 9.3
warnings that are gone on 10.1; FreeBSD 9.3 uses a pretty old GCC
version ("cc (GCC) 4.2.1 20070831 patched [FreeBSD]", ISTR it branched
off before a license change), while FreeBSD 10.1 and 10.3 use clang
3.4.1. We can use other compilers, but I find it unnecessary to do for
most projects written in C, it's more interesting for computing business
when you're into OpenMP, C++11 or newer and the likes.
> This release of dnsmasq has gone through a coverity scan, which is the
> ultimate static analysis, AFAIK. Even that generates lots of false
> positives, and rather then warp the code to make the analysis work, I
> adopted a policy of marking warnings as "not an issue".
Yeah, although in some cases an unneeded " = 0" or "= {0}"
initialization calms all static analyzers at the same time. ;-)
> Coverity builds under Linux, so the BSD-only code in the tree is not
> checked that way, unfortunately.
How much code is that, aside from a few API calls?
I never bothered to take a closer look.
> Thanks for committing 2.76.
My pleasure.
Cheers,
Matthias
___
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss
Re: [Dnsmasq-discuss] Announce: dnsmasq-2.76
Apologies for jumping the gun on you. As a general thing, a quick email in reply to an rc1 announcement is enough to hold things until an issue has been addressed. I checked those warnings, and they're all false positives. The static analysis is clever, but not clever enough. This release of dnsmasq has gone through a coverity scan, which is the ultimate static analysis, AFAIK. Even that generates lots of false positives, and rather then warp the code to make the analysis work, I adopted a policy of marking warnings as "not an issue". Coverity builds under Linux, so the BSD-only code in the tree is not checked that way, unfortunately. Thanks for committing 2.76. Cheers, Simon. On 18/05/16 23:24, Matthias Andree wrote: > Am 18.05.2016 um 17:44 schrieb Simon Kelley: >> I've just released dnsmasq 2.76. >> >> Download from http://thekelleys.org.uk/dnsmasq/dnsmasq-2.76.tar.gz >> >> It's more than nine months since the last release, so get the new code >> quick, there's lots to go at. > > Hi Simon, > > that was fast after the long test phase and the hint there might be a > few more rcs, so I didn't prioritize these properly during the -rc > phase, but had been sitting on them for a few days. Sorry about that. > Here we go: > > FreeBSD compilation of the rcs, and 2.76 proper, yields these warnings > on 9.3 (using some older GCC) > >> edns0.c: In function 'calc_subnet_opt': >> edns0.c:307: warning: 'addrp' may be used uninitialized in this function >> dnssec.c: In function 'prove_non_existence': >> dnssec.c:1670: warning: 'hash' may be used uninitialized in this function >> dnssec.c:1670: note: 'hash' was declared here > > and this on 10.1 (using clang): > >> rfc2131.c:829:25: warning: data argument not used by format string >> [-Wformat-extra-args] >>service->basename, layer); >> ^ > > I will mail the full build logs off-liste. > > Let me know if you need more details for debugging. I am compiling > without DBUS and Lua, but with IPv6, NLS (full internationalization) and > DNSSEC, and this is a sample compiler command line makes from its > defaults and my overrides: > >> cc -O2 -pipe -march=athlon64 -Wall -Wno-unused-value -Wno-unused-parameter >> -DHAVE_DNSSEC -fstack-protector -fno-strict-aliasing -O2 -pipe >> -march=athlon64 -Wall -Wno-unused-value -Wno-unused-parameter -DHAVE_DNSSEC >> -fstack-protector -fno-strict-aliasing >> -DLOCALEDIR='"/usr/local/share/locale"' -DVERSION='"2.76"' >> -I/usr/local/include -I/usr/local/include -I/usr/local/include -c >> dhcp-common.c > > I have committed v2.76 to the FreeBSD ports trunk. > > Best regards, > Matthias > > ___ > Dnsmasq-discuss mailing list > Dnsmasq-discuss@lists.thekelleys.org.uk > http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss > ___ Dnsmasq-discuss mailing list Dnsmasq-discuss@lists.thekelleys.org.uk http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss
Re: [Dnsmasq-discuss] Announce: dnsmasq-2.76
Am 18.05.2016 um 17:44 schrieb Simon Kelley: > I've just released dnsmasq 2.76. > > Download from http://thekelleys.org.uk/dnsmasq/dnsmasq-2.76.tar.gz > > It's more than nine months since the last release, so get the new code > quick, there's lots to go at. Hi Simon, that was fast after the long test phase and the hint there might be a few more rcs, so I didn't prioritize these properly during the -rc phase, but had been sitting on them for a few days. Sorry about that. Here we go: FreeBSD compilation of the rcs, and 2.76 proper, yields these warnings on 9.3 (using some older GCC) > edns0.c: In function 'calc_subnet_opt': > edns0.c:307: warning: 'addrp' may be used uninitialized in this function > dnssec.c: In function 'prove_non_existence': > dnssec.c:1670: warning: 'hash' may be used uninitialized in this function > dnssec.c:1670: note: 'hash' was declared here and this on 10.1 (using clang): > rfc2131.c:829:25: warning: data argument not used by format string > [-Wformat-extra-args] >service->basename, layer); > ^ I will mail the full build logs off-liste. Let me know if you need more details for debugging. I am compiling without DBUS and Lua, but with IPv6, NLS (full internationalization) and DNSSEC, and this is a sample compiler command line makes from its defaults and my overrides: > cc -O2 -pipe -march=athlon64 -Wall -Wno-unused-value -Wno-unused-parameter > -DHAVE_DNSSEC -fstack-protector -fno-strict-aliasing -O2 -pipe > -march=athlon64 -Wall -Wno-unused-value -Wno-unused-parameter -DHAVE_DNSSEC > -fstack-protector -fno-strict-aliasing > -DLOCALEDIR='"/usr/local/share/locale"' -DVERSION='"2.76"' > -I/usr/local/include -I/usr/local/include -I/usr/local/include -c > dhcp-common.c I have committed v2.76 to the FreeBSD ports trunk. Best regards, Matthias ___ Dnsmasq-discuss mailing list Dnsmasq-discuss@lists.thekelleys.org.uk http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss
Re: [Dnsmasq-discuss] Announce: dnsmasq 2.76 release-candidate.
> I've just pushed 2.76rc1 to the usual places. Wait for pl.po! :-) (tomorrow night I'll prepare it) -- jasiu ___ Dnsmasq-discuss mailing list Dnsmasq-discuss@lists.thekelleys.org.uk http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss
