On 3/8/2020 5:17 PM, Geert Stappers wrote: > > Hello John, > > > On Sun, Mar 08, 2020 at 01:35:11PM +0100, john doe wrote: >> On 3/8/2020 12:33 PM, Geert Stappers wrote: >>> On Sat, Mar 07, 2020 at 10:01:30PM +0100, Geert Stappers wrote: >>>> In-Reply-To: <1255b7ff-351f-46d7-f811-ac3373102...@thekelleys.org.uk> >>>> >>>> Now spliting previous change request into two parts: >>>> * Removing trailing white_space_only_lines >>> >>> Done, see >>> http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2020q1/013866.html >>> >>> Removed lines don't show up in `git blame`. >>> >>> >>>> * Emptying the empty lines >>> >>> Execute: >>> >>> sed --in-place -e 's/^[ \t]*$//' src/*.c src/*.h >>> >>> <screenshot with="some counting and calculation"> > ... >>> </screenshot> >>> >>> To prevent that 8% of the lines in future `git blame` >>> will distract us by reminding us on this clean-up. >>> >>> Execute: >>> >>> git commit -am "Removed useless white space" --author="Simon Kelley >>> <si...@thekelleys.org.uk>" >>> >>> <sample/> >>> >> >> Please use gitsend-email as you are known to be able to use it with the >> '--reroll-count=..' for a new reroll. > > Thanks for telling. I'll use it > in stead of the 'take 2' in the current subject. >
Your git send-email command should also include '--in-reply-to' in addition to the '--reroll-count', see also (1) before using those options. When committing, don't forget to "sign-off" ('-s'). > >> So Simon knows which set of patches to consider. > > Looking forward on your help > with > http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2020q1/013864.html > See (2). 1) https://git-scm.com/docs/git-send-email 2) https://git-scm.com/book/en/v2/Git-Basics-Git-Aliases -- John Doe _______________________________________________ Dnsmasq-discuss mailing list Dnsmasq-discuss@lists.thekelleys.org.uk http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss