Re: [Dnsmasq-discuss] fix entries in /etc/hosts disabling static leases, segfaults

2019-01-15 Thread Geert Stappers
On Tue, Jan 15, 2019 at 10:39:36PM +0100, Geert Stappers wrote:
> On Tue, Jan 15, 2019 at 02:31:56PM -0600, Kaas Baichtal wrote:
> > >
> > > Patch applied. (
> > > http://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=commitdiff;h=18eac67c0a15b673c8d27002c248651b308093e4
> > > )
> > >
> > 
> > I tried to install this patch manually to my 2.80 and got a segfault that
> > prevented dnsmasq running. I also tried git cloning the master and
> > installing that instead but got the same result.
> 
> FWIW  I can reproduce the segfault.
> 
> Syslog:
> Jan 15 22:23:00 nero dnsmasq[27580]: started, version 2.80-30-g18eac67 DNS 
> disabled
> Jan 15 22:23:00 nero dnsmasq[27580]: compile time options: IPv6 GNU-getopt 
> no-DBus no-i18n no-IDN DHCP DHCPv6 no-Lua TFTP no-conntrack ipset auth 
> no-DNSSEC loop-detect inotify dumpfile
> Jan 15 22:23:00 nero dnsmasq-dhcp[27580]: DHCP, proxy on subnet 172.24.0.63
> Jan 15 22:23:00 nero dnsmasq-tftp[27580]: TFTP root is /srv/tftpd 
> Jan 15 22:23:00 nero kernel: [1481741.304294] dnsmasq[27580]: segfault at 0 
> ip 0043328f sp 7fff6f19a348 error 4 in dnsmasq[40+4d000]
> 
> Running in gdb yielded nothing:
> # gdb /usr/sbin/dnsmasq
> GNU gdb (Debian 7.7.1+dfsg-5) 7.7.1
>...
> Reading symbols from /usr/sbin/dnsmasq...(no debugging symbols found)...done.
> (gdb) run
> Starting program: /usr/sbin/dnsmasq 
> [Inferior 1 (process 30650) exited normally]
> (gdb)
> 

Revert that last commit gets me a working  dnsmasq 
Single line from syslog, from the short git commit hash:
Jan 15 22:49:04 nero dnsmasq[31064]: started, version 2.80-29-gf8c77ed DNS 
disabled


Groeten
Geert Stappers
-- 
Leven en laten leven

___
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss


Re: [Dnsmasq-discuss] fix entries in /etc/hosts disabling static leases, segfaults

2019-01-15 Thread Geert Stappers
On Tue, Jan 15, 2019 at 02:31:56PM -0600, Kaas Baichtal wrote:
> Simon Kelley Sun, 13 Jan 2019 15:32:43 -0800
> > On 12/01/2019 21:55, Steven Siloti wrote:
> >> It is possible for a config entry to have one address family specified by a
> >> dhcp-host directive and the other added from /etc/hosts. This is especially
> >> common on OpenWrt because it uses odhcpd for DHCPv6 and IPv6 leases are
> >> imported into dnsmasq via a hosts file.
> >> 
> >> To handle this case there need to be separate *_HOSTS flags for IPv4 and 
> >> IPv6.
> >> Otherwise when the hosts file is reloaded it will clear the CONFIG_ADDR(6) 
> >> flag which was set by the dhcp-host directive.
> >
> > Patch applied.
> >
> 
> I tried to install this patch manually to my 2.80 and got a segfault that
> prevented dnsmasq running. I also tried git cloning the master and
> installing that instead but got the same result.

FWIW  I can reproduce the segfault.

Syslog:
Jan 15 22:23:00 nero dnsmasq[27580]: started, version 2.80-30-g18eac67 DNS 
disabled
Jan 15 22:23:00 nero dnsmasq[27580]: compile time options: IPv6 GNU-getopt 
no-DBus no-i18n no-IDN DHCP DHCPv6 no-Lua TFTP no-conntrack ipset auth 
no-DNSSEC loop-detect inotify dumpfile
Jan 15 22:23:00 nero dnsmasq-dhcp[27580]: DHCP, proxy on subnet 172.24.0.63
Jan 15 22:23:00 nero dnsmasq-tftp[27580]: TFTP root is /srv/tftpd 
Jan 15 22:23:00 nero kernel: [1481741.304294] dnsmasq[27580]: segfault at 0 ip 
0043328f sp 7fff6f19a348 error 4 in dnsmasq[40+4d000]

Running in gdb yielded nothing:
# gdb /usr/sbin/dnsmasq
GNU gdb (Debian 7.7.1+dfsg-5) 7.7.1
   ...
Reading symbols from /usr/sbin/dnsmasq...(no debugging symbols found)...done.
(gdb) run
Starting program: /usr/sbin/dnsmasq 
[Inferior 1 (process 30650) exited normally]
(gdb)


Groeten
Geert Stappers
-- 
Leven en laten leven

___
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss