Re: [Dnsmasq-discuss] ubus and metrics

Hi Kelley, I rebase my branches on top of the current master. Please check them out: https://github.com/digineo/dnsmasq/compare/enums https://github.com/digineo/dnsmasq/compare/metrics Regards, Julian Kornberger

Re: [Dnsmasq-discuss] ubus and metrics

On 26.04.2018 19:03, Simon Kelley wrote: General questions: - Is there any reason to not use the `enum` for definition lists like `LOPT_*`? No strong ones, just habit I guess. Can

Re: [Dnsmasq-discuss] ubus and metrics

Looking at the patch again, I think there's a problem with the original Ubus patch. Because of where the ubus code is called in log_packet, Ubus broadcasts will be suppressed by --quiet-dhcp. I doubt that's intended behaviour. It should at least be noted the both the UBus and metrics patches are

Re: [Dnsmasq-discuss] ubus and metrics

On 24/04/18 08:30, Julian Kornberger wrote: > On 24.04.2018 01:07, Simon Kelley wrote: >>> Where does the DBUS raise a fatal error if support is missing? I >>> couldn't find anything in the code. >> src/dnsmasq.c: > Ok, I only searched in src/option.c > >>> General questions: >>> - Is there any

Re: [Dnsmasq-discuss] ubus and metrics

On 24.04.2018 01:07, Simon Kelley wrote: Where does the DBUS raise a fatal error if support is missing? I couldn't find anything in the code. src/dnsmasq.c: Ok, I only searched in src/option.c General questions: - Is there any reason to not use the `enum` for definition lists like `LOPT_*`?

Re: [Dnsmasq-discuss] ubus and metrics

> On 24 Apr 2018, at 04:52, Kurt H Maier wrote: > > On Tue, Apr 24, 2018 at 12:07:09AM +0100, Simon Kelley wrote: >> >> I edit using emacs, and never see a problem. A massive edit would >> generate a huge number of spurious changes in the git repository. I use >> "git blame"

Re: [Dnsmasq-discuss] ubus and metrics

On Tue, Apr 24, 2018 at 12:07:09AM +0100, Simon Kelley wrote: > > I edit using emacs, and never see a problem. A massive edit would > generate a huge number of spurious changes in the git repository. I use > "git blame" quite often and don't want to find that it tells me half the > lines were

Re: [Dnsmasq-discuss] ubus and metrics

On 23/04/18 23:52, Julian Kornberger wrote: > Thanks for your comments. > > I have added a `--enable-dbus` flag. It compiles but is not tested yet. Thanks. > > Where does the DBUS raise a fatal error if support is missing? I > couldn't find anything in the code. src/dnsmasq.c: if

Re: [Dnsmasq-discuss] ubus and metrics

Thanks for your comments. I have added a `--enable-dbus` flag. It compiles but is not tested yet. Where does the DBUS raise a fatal error if support is missing? I couldn't find anything in the code. General questions: - Is there

Re: [Dnsmasq-discuss] ubus and metrics

That's great. Thank you. Can I make another request? It would be good (and consistent) to have a dnsmasq option for UBus analogous to --enable-dbus, called --enable-ubus so that dnsmasq doesn't try and connect to the Ubus unless that's explicitly requested, even if the code is compiled in. Like

Re: [Dnsmasq-discuss] ubus and metrics

Comments, in no particular order. 1) Conditional compilation. Every HAVE_ doubles the number of combinations of compile-time selections, and increases the chances that some set of selections will fail to compile or be buggy. I'm not sure that HAVE_METRICS passes the test for needing control at