Re: [Dnsmasq-discuss] unittests

2021-10-20 Thread Dominik Derigs
Hey Petr, On Wed, 2021-10-20 at 19:15 +0200, Petr Menšík wrote: > What do you think? Should we try to reuse some parts for both > projects > or just copy interesting stuff out and mostly forget its > original source? > > [1] https://github.com/pemensik/FTL/tree/tests/test/dnsmasq It might be

Re: [Dnsmasq-discuss] unittests

2021-10-20 Thread Petr Menšík
Hi! I have played with those tests a bit. I have realized dnsmasq should be able to do all authoritative data too, so I made a modification to run with dnsmasq directly [1]. I found out ANY queries are not handled by authoritative server. Fixed basic support for it, it now gives any.ftl results

Re: [Dnsmasq-discuss] unittests

2021-10-11 Thread Dominik Derigs
Hey Petr, On Tue, 2021-10-12 at 04:40 +0200, Petr Menšík wrote: > Hi Dominik, > > those tests look great. Something like that is exactly what I had > on > mind for dnsmasq itself. Would you mind if I borrow few things > and try > to make some dnsmasq-only parts, not dependent on pihole? Go

Re: [Dnsmasq-discuss] unittests

2021-10-05 Thread Hamish Moffatt
On 6/10/21 09:11, Petr Menšík wrote: On 10/5/21 20:28, john doe wrote: Those tools are not standards, for instance on OpenWRT. dig is quite standard thing for troubleshooting DNS. If it is not available for OpenWRT, it should be fixed. I am bind9 maintainer too, it might get surprising to me.

Re: [Dnsmasq-discuss] unittests

2021-10-05 Thread Dominik Derigs
Hey Petr and others, On Tue, 2021-10-05 at 17:13 +0200, Petr Menšík wrote: > It would be beneficial to have also behavior tests. it may be the time to mention that we do exactly this for Pi-hole FTL which embeds the full dnsmasq for the DNS part. On every commit, a virtual machine is started

Re: [Dnsmasq-discuss] unittests

2021-10-05 Thread john doe
On 10/5/2021 5:13 PM, Petr Menšík wrote: Hey Geert, On 10/2/21 14:40, Geert Stappers via Dnsmasq-discuss wrote: In-Reply-To: <8a018620-25a7-a292-c951-dd2017d54...@redhat.com> On Mon, May 03, 2021 at 12:53:39PM +0200, Petr Menšík wrote: On 4/30/21 12:42 AM, Simon Kelley wrote: On 14/04/2021

Re: [Dnsmasq-discuss] unittests

2021-10-05 Thread Petr Menšík
Hey Geert, On 10/2/21 14:40, Geert Stappers via Dnsmasq-discuss wrote: > In-Reply-To: <8a018620-25a7-a292-c951-dd2017d54...@redhat.com> > On Mon, May 03, 2021 at 12:53:39PM +0200, Petr Menšík wrote: >> On 4/30/21 12:42 AM, Simon Kelley wrote: >>> On 14/04/2021 18:35, Petr Menšík wrote: Hi

Re: [Dnsmasq-discuss] unittests

2021-04-30 Thread Geert Stappers via Dnsmasq-discuss
On Thu, Apr 29, 2021 at 11:42:06PM +0100, Simon Kelley wrote: > On 14/04/2021 18:35, Petr Menšík wrote: > > ... I am sending my dnsmasq unit tests. ... > > ... ... > > > > First is attempt to refactor, the second is what evolved into more > > complex set of tests. > > ... > > >