Re: [Dnssec-trigger] dnssec-trigger 0.16 released

2018-06-25 Thread Martin Sehnoutka
I think you should release this fix straight away, because the infinite loop is very likely to happen. My additional patch can wait a little longer. Regards, Martin On 06/22/2018 11:52 AM, W.C.A. Wijngaards wrote: > Hi Martin, > > Oops that was not supposed to happen. I'll import some part of

Re: [Dnssec-trigger] dnssec-trigger 0.16 released

2018-06-22 Thread W.C.A. Wijngaards
Hi Martin, Oops that was not supposed to happen. I'll import some part of your fixes, they are now mixed with your patch. This is what that looks like (move to next at front of loop and zone used to get the string contents): Is this something for release straight away, or something that can

Re: [Dnssec-trigger] dnssec-trigger 0.16 released

2018-06-22 Thread Martin Sehnoutka
Hi, be careful, there is an unfortunate bug in this loop: https://github.com/NLnetLabs/dnssec-trigger/blob/master/riggerd/svr.c#L934 Since it was changed from the iterator macro, it needs to do the step iter=iter->next regardless of the branch it takes. Right now it will most likely end up in an

[Dnssec-trigger] dnssec-trigger 0.16 released

2018-06-21 Thread W.C.A. Wijngaards
Hi, dnssec-trigger 0.16 is available: https://nlnetlabs.nl/downloads/dnssec-trigger/dnssec-trigger-0.16.tar.gz sha256 e80aab8fd52074638f782a608bf433cbaa507cad087bcc5fb433353db9d057cb pgp https://nlnetlabs.nl/downloads/dnssec-trigger/dnssec-trigger-0.16.tar.gz.asc windows