Re: [Dovecot] PATCH: Deliver looses mail and DSN if Return-Path is missing

2007-05-09 Thread Steffen Kaiser
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Wed, 9 May 2007, Matthias Andree wrote: No, the "any" MTA - excluding qmail and other incompatible stuff(*) - will act upon sysexits.h values, not errno values (which are often OK, no objection -> sysexit.h. Bye, - -- Steffen Kaiser -BE

Re: [Dovecot] PATCH: Deliver looses mail and DSN if Return-Path is missing

2007-05-09 Thread Matthias Andree
Steffen Kaiser schrieb: > BTW: Would it be possible to return the errno of the failed system call > to the MTA via the main() return value? I believe that any MTA will act > upon these codes and the postmaster can setup the preferred way handling > bounces. No, the "any" MTA - excluding qmail and

Re: [Dovecot] PATCH: Deliver looses mail and DSN if Return-Path is missing

2007-05-09 Thread Steffen Kaiser
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Wed, 9 May 2007, Timo Sirainen wrote: Oh, right, return_address = NULL also if the address isn't valid. In those cases I think it should return 0, because there just isn't anything to be done. So EX_TEMPFAIL should only be returned if the whole R

Re: [Dovecot] PATCH: Deliver looses mail and DSN if Return-Path is missing

2007-05-09 Thread Timo Sirainen
On Wed, 2007-05-09 at 11:40 +0300, Timo Sirainen wrote: > On Wed, 2007-05-09 at 10:05 +0200, Steffen Kaiser wrote: > > > - --- src/deliver/mail-send.c (revision 47) > > +++ src/deliver/mail-send.c (working copy) > > @@ -42,7 +42,7 @@ > > i_info("msgid=%s: Return-Path missing, rejectio

Re: [Dovecot] PATCH: Deliver looses mail and DSN if Return-Path is missing

2007-05-09 Thread Timo Sirainen
On Wed, 2007-05-09 at 10:05 +0200, Steffen Kaiser wrote: > - --- src/deliver/mail-send.c (revision 47) > +++ src/deliver/mail-send.c (working copy) > @@ -42,7 +42,7 @@ > i_info("msgid=%s: Return-Path missing, rejection reason: %s", > orig_msgid == NULL ? "" : str_s

[Dovecot] PATCH: Deliver looses mail and DSN if Return-Path is missing

2007-05-09 Thread Steffen Kaiser
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello, Dovecot v1.0.0 if there is no Return-Path in the message and Deliver cannot deliver the message, no DSN is sent _and_ the MTA is returned 0 (aka success) return code, which leads to mail loss. This is not the case, when the message actual