Re: Bug in IDLE implementation for virtual mailbox

2018-12-17 Thread Pali Rohár
On Monday 17 December 2018 10:50:16 Timo Sirainen wrote: > On 17 Dec 2018, at 10.44, Pali Rohár wrote: > > > > On Sunday 16 December 2018 21:55:23 Timo Sirainen wrote: > >> On 16 Dec 2018, at 21.26, Pali Rohár wrote: > >>> > >>> Hello! > >

Re: Bug in IDLE implementation for virtual mailbox

2018-12-17 Thread Pali Rohár
On Sunday 16 December 2018 21:55:23 Timo Sirainen wrote: > On 16 Dec 2018, at 21.26, Pali Rohár wrote: > > > > Hello! > > > > I found bug in Dovecot's IDLE implementation when virtual mailbox is in > > use. IDLE does not notify about new emails when email app

Bug in IDLE implementation for virtual mailbox

2018-12-16 Thread Pali Rohár
was delivered (as it collects emails from all - * - mailboxes). But dovecot for some unknown reason does not notify via IDLE that there is a new email. To get notifications, it is needed to re-open that "All" mailbox again. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: PGP signature

Re: [PATCH] lib-mail: Set missing invalid_syntax to TRUE

2017-10-02 Thread Pali Rohár
On Saturday 12 August 2017 14:36:31 Pali Rohár wrote: > route is already set to "INVALID_ROUTE" when fill_missing is true, but > setting invalid_syntax was not done yet. > --- > src/lib-mail/message-address.c |1 + > 1 file changed, 1 insertion(+) > > di

[PATCH] lib-mail: Set missing invalid_syntax to TRUE

2017-08-12 Thread Pali Rohár
route is already set to "INVALID_ROUTE" when fill_missing is true, but setting invalid_syntax was not done yet. --- src/lib-mail/message-address.c |1 + 1 file changed, 1 insertion(+) diff --git a/src/lib-mail/message-address.c b/src/lib-mail/message-address.c index 29cac2b..96584e2 100644

[PATCH v2 7/7] lib-mail: Update tests for message address

2016-06-05 Thread Pali Rohár
--- src/lib-mail/test-message-address.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/lib-mail/test-message-address.c b/src/lib-mail/test-message-address.c index 9bbf29e..bf85806 100644 --- a/src/lib-mail/test-message-address.c +++

[PATCH v2 6/7] lib-mail: message_address_write: Quote and escape strings if needed

2016-06-05 Thread Pali Rohár
ATEXT characters must be properly quoted when are in phrase. Test case: { name = "test\"test", mailbox = "user", domain = "host" } converts to: "test\"test" --- src/lib-mail/message-address.c | 66 +--- 1 file changed, 62 insertions(+), 4

[PATCH v2 3/7] lib-mail: parse_addr_spec: Like in rfc822_skip_comment() check if last_comment is not NULL

2016-06-05 Thread Pali Rohár
This will fix possible NULL pointer dereference when caller does not set last_comment. --- src/lib-mail/message-address.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/lib-mail/message-address.c b/src/lib-mail/message-address.c index 9ce4a55..4e86185

[PATCH v2 1/7] lib-mail: message_address_write: Fix generating empty group list

2016-06-05 Thread Pali Rohár
Empty group list ends with ": " not with ", ". Test case: { { name = NULL, mailbox = "group", domain = NULL }, { name = NULL, mailbox = NULL, domain = NULL } } converts to: group:; --- src/lib-mail/message-address.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff

[PATCH v2 4/7] lib-mail: parse_addr_spec: Email address without local-part is invalid

2016-06-05 Thread Pali Rohár
Add explicit invalid_syntax flag also when end of input occure because address is without domain invalid and in this case it was not correctly propagated. --- src/lib-mail/message-address.c |4 1 file changed, 4 insertions(+) diff --git a/src/lib-mail/message-address.c

[PATCH v2 5/7] lib-mail: parse_mailbox: Set display name instead mailbox when parsing failed

2016-06-05 Thread Pali Rohár
It does not make sense to set mailbox without domain on incorrect input. Rather set display name which is more likely useable value. Test case: test is parsed as: { name = "test", mailbox = NULL, domain = NULL } --- src/lib-mail/message-address.c |4 1 file changed, 4

[PATCH v2 2/7] lib-mail: message_address_write: Fix generating group list with empty name

2016-06-05 Thread Pali Rohár
Empty name for group list must be quoted. Test case: { { name = NULL, mailbox = "", domain = NULL }, { name = NULL, mailbox = NULL, domain = NULL } } converts to: "":; --- src/lib-mail/message-address.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[PATCH v2 0/7] Fixes for lib-mail message-address

2016-06-05 Thread Pali Rohár
modules it is a lot of easier for me. [1] - https://github.com/pali/Email-Address-XS [2] - https://github.com/pali/Email-Address-XS/blob/master/t/Email-Address-XS.t Changes since v1: * Updated description with test example * Rebased on top of master branch Pali Rohár (7): lib-mail: message_address_wr

Re: [PATCH 0/7] Fixes for lib-mail message-address

2016-05-30 Thread Pali Rohár
On Thursday 12 May 2016 13:24:36 Pali Rohár wrote: > On Thursday 21 April 2016 14:24:09 Timo Sirainen wrote: > > On 11 Apr 2016, at 13:44, Pali Rohár <pali.ro...@gmail.com> wrote: > > > > > > On Thursday 07 April 2016 16:11:12 Timo Sirainen wrote: > >

Re: [PATCH 0/7] Fixes for lib-mail message-address

2016-05-12 Thread Pali Rohár
On Thursday 21 April 2016 14:24:09 Timo Sirainen wrote: > On 11 Apr 2016, at 13:44, Pali Rohár <pali.ro...@gmail.com> wrote: > > > > On Thursday 07 April 2016 16:11:12 Timo Sirainen wrote: > >> On 06 Apr 2016, at 17:29, Pali Rohár <pali.ro...@gmail.com> wrote:

Re: [PATCH 0/7] Fixes for lib-mail message-address

2016-04-21 Thread Pali Rohár
On Monday 11 April 2016 12:44:02 Pali Rohár wrote: > On Thursday 07 April 2016 16:11:12 Timo Sirainen wrote: > > On 06 Apr 2016, at 17:29, Pali Rohár <pali.ro...@gmail.com> wrote: > > > > > > On Monday 04 April 2016 19:35:22 Pali Rohár wrote: > > >

Re: [PATCH 0/7] Fixes for lib-mail message-address

2016-04-11 Thread Pali Rohár
On Thursday 07 April 2016 16:11:12 Timo Sirainen wrote: > On 06 Apr 2016, at 17:29, Pali Rohár <pali.ro...@gmail.com> wrote: > > > > On Monday 04 April 2016 19:35:22 Pali Rohár wrote: > >> On Monday 04 April 2016 19:31:06 aki.tu...@dovecot.fi wrote: > >>&g

Re: [PATCH 0/7] Fixes for lib-mail message-address

2016-04-06 Thread Pali Rohár
On Monday 04 April 2016 19:35:22 Pali Rohár wrote: > On Monday 04 April 2016 19:31:06 aki.tu...@dovecot.fi wrote: > > Can you please send them directly to me, please? > > --- > > Aki Tuomi > > Sent. Received? Are patches OK now? -- Pali Rohár pali.ro...@gmail.com

Re: [PATCH 0/7] Fixes for lib-mail message-address

2016-04-04 Thread Pali Rohár
On Monday 04 April 2016 19:31:06 aki.tu...@dovecot.fi wrote: > Can you please send them directly to me, please? > --- > Aki Tuomi Sent. -- Pali Rohár pali.ro...@gmail.com

Re: [PATCH 0/7] Fixes for lib-mail message-address

2016-04-04 Thread Pali Rohár
On Monday 04 April 2016 19:12:56 Pali Rohár wrote: > Hello, > > I borrowed dovecot parser for email addresses and going to use it in new > perl module as replacement for Email::Address. During implementation and > testing I found bugs in dovecot parser & generator. So I'm s

Re: [PATCH 0/7] Fixes for lib-mail message-address

2016-04-03 Thread Pali Rohár
On Sunday 03 April 2016 12:45:23 aki.tu...@dovecot.fi wrote: > > On April 2, 2016 at 6:58 PM Pali Rohár <pali.ro...@gmail.com> > > wrote: > > > > > > Hello, > > > > I borrowed dovecot parser for email addresses and going to use it > > in new

[PATCH 0/7] Fixes for lib-mail message-address

2016-04-02 Thread Pali Rohár
Hello, I borrowed dovecot parser for email addresses and going to use it in new perl module as replacement for Email::Address. During implementation and testing I found bugs in dovecot parser & generator. So I'm sending my patches together with tests. Pali Rohár (7): lib-

Re: Dovecot mbox other programs

2015-06-09 Thread Pali Rohár
the claims. That communication form is usually intentional to provoke discussion. Further CCing to his/her email should stop, s/he can just subscribe. Am 06.06.2015 um 19:01 schrieb Pali Rohár: What is correct way to read those mboxes? And what is correct way to modify that mbox file

Re: Dovecot mbox other programs

2015-06-09 Thread Pali Rohár
/snapshot read of mbox file should be ok (when lock is not acquired by dovecot). Or not? And which emails in mbox are used only internally by dovecot? Only those which have X-IMAPbase header? Or are there any other emails which should I ignore when I parse mbox file (for read access)? -- Pali Rohár

Re: Dovecot mbox other programs

2015-06-08 Thread Pali Rohár
/body) -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: Dovecot mbox other programs

2015-06-08 Thread Pali Rohár
On Monday 08 June 2015 23:06:26 Marcus Rueckert wrote: On 2015-06-08 14:48:12 +0200, Pali Rohár wrote: On Monday 08 June 2015 02:45:52 Marcus Rueckert wrote: IMHO ... Maildir is a better format. Really? I do not think so! Having half of million (small) files in one directory is killer

Re: Dovecot mbox other programs

2015-06-08 Thread Pali Rohár
just want to know: How to correctly read dovecot mboxes and how to correctly write to them. Thats all. In your email I did not find this information :-( PS: I'm not subscribed to this list, so please CC me! -- Pali Rohár pali.ro...@gmail.com

Re: Dovecot mbox other programs

2015-06-08 Thread Pali Rohár
) consume lot of CPU cycles... PS: I'm not subscribed to this list, so please CC me! -- Pali Rohár pali.ro...@gmail.com

Dovecot mbox other programs

2015-06-07 Thread Pali Rohár
localhost). It is possible without any data/message damage? [1] - http://wiki2.dovecot.org/MailboxFormat/mbox -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.