Re: gcc -> clang

2019-01-07 Thread Timo Sirainen
The unit test problems aren't clang issues, they're OSX issues. So: test-net.c:79: Assert failed: strcmp(net_ip2addr(), "::5") == 0 test-net.c:83: Assert failed: strcmp(net_ip2addr(), "::5") == 0 This is because OSX writes the address out as "::0.0.0.5" instead of "::5". I don't remember if the

Re: Fwd: Re: gcc -> clang

2019-01-05 Thread Rupert Gallagher via dovecot
Same problem with 2.3.4. configure lacks debug flags. No joy with gdb breakpoint in mallock_error_break on make test. On Thu, Jan 3, 2019 at 13:58, Aki Tuomi wrote: > The arithmetic stuff has already been fixed in master with > > https://github.com/dovecot/core/commit >

Re: Fwd: Re: gcc -> clang

2019-01-03 Thread Aki Tuomi
The arithmetic stuff has already been fixed in master with https://github.com/dovecot/core/commit /5cccb4af850bb3ba81e73a8fb4f6881c3e1d4046.patch https://github.com/dovecot/core/commit /ac7aa955db4c77bbb169baa5d104a4c128674646.patch I have not seen the second error ever, it would need more

Re: gcc -> clang

2019-01-03 Thread Sami Ketola
> On 3 Jan 2019, at 14.04, Ruben Safir wrote: > > On 1/3/19 4:50 AM, Rupert Gallagher via dovecot wrote: >> Please, use clang instead of gcc. Code quality can only profit from it. I >> just compiled 2.3.4 and compiler stderr is full of interesting problems. >> > > > oh please This is

Re: gcc -> clang

2019-01-03 Thread Bernd Petrovitsch
Hi all! On 03/01/2019 10:50, Rupert Gallagher via dovecot wrote: > Please, use clang instead of gcc. Code quality can only profit from it. > I just compiled 2.3.4 and compiler stderr is full of interesting problems.  But obviously not interesting enough to share the clang command line and the

Re: gcc -> clang

2019-01-03 Thread Ruben Safir
On 1/3/19 4:50 AM, Rupert Gallagher via dovecot wrote: > Please, use clang instead of gcc. Code quality can only profit from it. I > just compiled 2.3.4 and compiler stderr is full of interesting problems. > oh please

Re: gcc -> clang

2019-01-03 Thread Aki Tuomi
We compile all core code with both gcc and clang. What sort of interesting things did you find? Aki On 03 January 2019 at 11:50 Rupert Gallagher via dovecot < dovecot@dovecot.org> wrote: Please, use clang

gcc -> clang

2019-01-03 Thread Rupert Gallagher via dovecot
Please, use clang instead of gcc. Code quality can only profit from it. I just compiled 2.3.4 and compiler stderr is full of interesting problems.