Re: (output) encoding support in doxia-sink-api

2008-11-07 Thread Vincent Siveton
Hi, 2008/11/7 Hervé BOUTEMY [EMAIL PROTECTED]: Hi folks, For the next 1.0-beta-1 version, 2 methods have been added to SinkFactory interface to improve encoding support: - Sink createSink( File outputDir, String outputName, String encoding ) - Sink createSink( Writer writer ) See [1] for

Re: (output) encoding support in doxia-sink-api

2008-11-07 Thread Vincent Siveton
Hi Benjamin 2008/11/7 Benjamin Bentmann [EMAIL PROTECTED]: [SNIP] It might however be convenient to create an AbstractTextSinkFactory from which all/most text-based sinks could inherit. For instance, XhtmlSinkFactory and XdocSinkFactory look pretty much the same. In more detail, how about

Re: (output) encoding support in doxia-sink-api

2008-11-07 Thread Vincent Siveton
Other comments which maybe related to this thread: * Parser needs at least 2 parsing: one for macro and another one for processing, and now a third one to validate XML (DOXIA-263) * Sink uses some time StringWriter to play with the writed content and to create a valid content (DOXIA-177) So,

Re: (output) encoding support in doxia-sink-api

2008-11-07 Thread Benjamin Bentmann
Vincent Siveton wrote: Then I think Sink createSink( Writer writer ) should be removed. I prefer deprecated for backward compatibility issue. The source code says @since 1.0-beta-1, i.e. this method was never part of a released Doxia version, right? Then we should be able to safely

Re: (output) encoding support in doxia-sink-api

2008-11-07 Thread Vincent Siveton
2008/11/7 Benjamin Bentmann [EMAIL PROTECTED]: Vincent Siveton wrote: Then I think Sink createSink( Writer writer ) should be removed. I prefer deprecated for backward compatibility issue. The source code says @since 1.0-beta-1, i.e. this method was never part of a released Doxia version,