Re: [DPP-Devel] Gerrit push privileges

2015-04-27 Thread Holger S.
The interface was a bit confusing. I think I just added you to the right group, so please try again :-) > Hi, > > I recently posted a patch to https://sourceforge.net/p/dpp/bugs/844/ but > after double checking the new developer guide it seems I could just push > my > code to gerrit and have it re

Re: [DPP-Devel] Gerrit push privileges

2015-04-27 Thread Holger S.
True there was that. Do you have a Gerrit account, quentin? Maybe I can unlock it too. > IIRC you can only register an account with no Gerrit push privileges. > > Normally Franz has to manually "unlock" the account. > > On 27.04.2015 13:11, Holger S. wrote: >> Hi Quentin, >> >> great to see the pa

Re: [DPP-Devel] Gerrit push privileges

2015-04-27 Thread Stefan Rossbach
IIRC you can only register an account with no Gerrit push privileges. Normally Franz has to manually "unlock" the account. On 27.04.2015 13:11, Holger S. wrote: > Hi Quentin, > > great to see the patch! But you are right, normally we do code review on > gerrit. You do not need to do anything spec

Re: [DPP-Devel] Gerrit push privileges

2015-04-27 Thread Holger S.
Hi Quentin, great to see the patch! But you are right, normally we do code review on gerrit. You do not need to do anything special to get push priviliges there, just follow our getting started guide, including the part where you set up SSH keys for use with Gerrit: http://www.saros-project.org/s

[DPP-Devel] Gerrit push privileges

2015-04-26 Thread Quentin Fulsher
Hi, I recently posted a patch to https://sourceforge.net/p/dpp/bugs/844/ but after double checking the new developer guide it seems I could just push my code to gerrit and have it reviewed there. I'm just asking for push privileges to upload my patch and get it reviewed. Regards, Quentin