Re: [PATCH] i915: disable framebuffer compression on GeminiLake

2019-04-24 Thread Chris Wilson
Quoting Jian-Hong Pan (2019-04-23 10:28:10) > From: Daniel Drake > > On many (all?) the Gemini Lake systems we work with, there is frequent > momentary graphical corruption at the top of the screen, and it seems > that disabling framebuffer compression can avoid this. > > The ticket was

Re: [Intel-gfx] [PATCH] dma-buf: Remove unused sync_dump()

2019-04-23 Thread Chris Wilson
Quoting Daniel Vetter (2019-04-23 09:21:16) > On Fri, Apr 19, 2019 at 07:19:04PM +0100, Chris Wilson wrote: > > sync_dump() is an unused, unexported, function that adds 64k to the > > kernel image and doesn't even provide locking around the global array it > > uses. > >

[PATCH] dma-buf: Remove unused sync_dump()

2019-04-19 Thread Chris Wilson
198 --198 sync_dump_buf 65536 - -65536 Signed-off-by: Chris Wilson Cc: Sumit Semwal Cc: Gustavo Padovan --- drivers/dma-buf/sync_debug.c | 26 -- drivers/dma-buf/sync_debug.h | 1 - 2 files changed, 27

Re: [PATCH] drm: increase drm mmap_range size to 1TB

2019-04-18 Thread Chris Wilson
Quoting Thomas Zimmermann (2019-04-18 08:29:39) > Hi > > Am 18.04.19 um 00:16 schrieb Kuehling, Felix: > > Adding dri-devel > > > > On 2019-04-17 6:15 p.m., Yang, Philip wrote: > >> After patch "drm: Use the same mmap-range offset and size for GEM and > >> TTM", application failed to create bo

Re: [Intel-gfx] [PATCH 1/2] drm/i915: remove DRM_AUTH from IOCTLs which also have DRM_RENDER_ALLOW

2019-04-17 Thread Chris Wilson
Reviewed-by: Chris Wilson -Chris ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH v6 2/2] drm/i915: Add a missed update of edid property of drm connector

2019-04-12 Thread Chris Wilson
Quoting Gwan-gyeong Mun (2019-04-12 15:06:17) > After suspend/resume process, hotplug detection is handled by > i915_hpd_poll_init_work() workqueue. While intel_hdmi_detect() or > intel_dp_detect() are called, intel_hdmi_set_edid() or intel_dp_set_edid() > only update an internal detect_edid

Re: [PATCH v2] dma-fence: Propagate errors to dma-fence-array container

2019-04-08 Thread Chris Wilson
Quoting Chris Wilson (2019-03-25 08:07:33) > When one of the array of fences is signaled, propagate its errors to the > parent fence-array (keeping the first error to be raised). > > v2: Opencode cmpxchg_local to avoid compiler freakout. > > Signed-off-by: Chris Wilson > C

Re: [RFC PATCH] drm/i915: Don't panic on non-empty list of free cachelines

2019-04-05 Thread Chris Wilson
Quoting Janusz Krzysztofik (2019-04-05 13:13:31) > From: Janusz Krzysztofik > > If there are active users of a device during driver unbind, the driver > now panics on non-empty list of free cachelines. This panic is there to say that fini is being called with active contexts, that it is being

Re: [PATCH] drm/i915: Use drm_dev_unplug()

2019-04-05 Thread Chris Wilson
Quoting Janusz Krzysztofik (2019-04-05 09:11:54) > On Fri, 2019-04-05 at 08:41 +0100, Chris Wilson wrote: > > Quoting Janusz Krzysztofik (2019-04-05 08:26:57) > > > From: Janusz Krzysztofik > > > > > > The driver does not currently support unbinding from

Re: [PATCH] drm/i915: Use drm_dev_unplug()

2019-04-05 Thread Chris Wilson
Quoting Janusz Krzysztofik (2019-04-05 08:26:57) > From: Janusz Krzysztofik > > The driver does not currently support unbinding from a device which is > in use. Since open file descriptors may still be pointing into kernel > memory where the device structures used to be, entirely correct kernel

Re: [Intel-gfx] [PATCH] drm/i915: Fix context IDs not released on driver hot unbind

2019-04-04 Thread Chris Wilson
Quoting Janusz Krzysztofik (2019-04-04 11:50:14) > On Thu, 2019-04-04 at 11:43 +0100, Chris Wilson wrote: > > Quoting Janusz Krzysztofik (2019-04-04 11:40:24) > > > On Thu, 2019-04-04 at 11:28 +0100, Chris Wilson wrote: > > > > Quoting Janusz Krzysztofik (2019-

Re: [Intel-gfx] [PATCH] drm/i915: Fix context IDs not released on driver hot unbind

2019-04-04 Thread Chris Wilson
Quoting Janusz Krzysztofik (2019-04-04 11:40:24) > On Thu, 2019-04-04 at 11:28 +0100, Chris Wilson wrote: > > Quoting Janusz Krzysztofik (2019-04-04 11:24:45) > > > From: Janusz Krzysztofik > > > > > > In case the driver gets unbound while a device is open, ke

Re: [Intel-gfx] [PATCH] drm/i915: Fix context IDs not released on driver hot unbind

2019-04-04 Thread Chris Wilson
Quoting Janusz Krzysztofik (2019-04-04 11:24:45) > From: Janusz Krzysztofik > > In case the driver gets unbound while a device is open, kernel panic > may be forced if a list of allocated context IDs is not empty. > > When a device is open, the list may happen to be not empty because a >

Re: [PATCH v2 2/3] drm: Add a drm_gem_objects_lookup helper

2019-04-01 Thread Chris Wilson
Quoting Daniel Vetter (2019-04-01 14:06:48) > On Mon, Apr 1, 2019 at 9:47 AM Rob Herring wrote: > > +{ > > + int i, ret = 0; > > + struct drm_gem_object *obj; > > + > > + spin_lock(>table_lock); > > + > > + for (i = 0; i < count; i++) { > > + /* Check if we

Re: [PATCH] drm/i915/selftests: Fix an IS_ERR() vs NULL check

2019-03-26 Thread Chris Wilson
Quoting Mika Kuoppala (2019-03-26 09:30:57) > Dan Carpenter writes: > > > The live_context() function returns error pointers. It never returns > > NULL. > > > > Fixes: 9c1477e83e62 ("drm/i915/selftests: Exercise adding requests to a > > full GGTT") > > Signed-off-by: Dan Carpenter > >

Re: [PATCH] drm/i915: Fix an error code in i915_gem_context_open()

2019-03-25 Thread Chris Wilson
Quoting Dan Carpenter (2019-03-25 09:23:49) > If gem_context_register() fails then "ctx" is a valid pointer, not an > error pointer. We should just return "err". > > Fixes: 3aa9945a528e ("drm/i915: Separate GEM context construction and > registration to userspace") > Signed-off-by: Dan

[PATCH v2] dma-fence: Propagate errors to dma-fence-array container

2019-03-25 Thread Chris Wilson
When one of the array of fences is signaled, propagate its errors to the parent fence-array (keeping the first error to be raised). v2: Opencode cmpxchg_local to avoid compiler freakout. Signed-off-by: Chris Wilson Cc: Sumit Semwal Cc: Gustavo Padovan --- drivers/dma-buf/dma-fence-array.c

[PATCH 2/2] dma-fence: Report the composite sync_file status

2019-03-24 Thread Chris Wilson
Same as for the individual fences, we want to report the actual status of the fence when queried. Reported-by: Petri Latvala Signed-off-by: Chris Wilson Cc: Sumit Semwal Cc: Gustavo Padovan Cc: Petri Latvala --- drivers/dma-buf/sync_file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 1/2] dma-fence: Propagate errors to dma-fence-array container

2019-03-24 Thread Chris Wilson
When one of the array of fences is signaled, propagate its errors to the parent fence-array (keeping the first error to be raised). Signed-off-by: Chris Wilson Cc: Sumit Semwal Cc: Gustavo Padovan --- drivers/dma-buf/dma-fence-array.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [Intel-gfx] [PATCH v2 1/2] drm/selftests/mm: Switch to bitmap_zalloc()

2019-03-20 Thread Chris Wilson
Quoting Chris Wilson (2019-03-04 09:43:43) > Quoting Andy Shevchenko (2019-03-04 09:29:07) > > Switch to bitmap_zalloc() to show clearly what we are allocating. > > Besides that it returns pointer of bitmap type instead of opaque void *. > > > > Signed-off-by:

Re: [PATCH] gpu: i915: fix a missing check of get_free_page

2019-03-09 Thread Chris Wilson
Quoting Kangjie Lu (2019-03-09 04:24:50) > If the allocation fails, return false to avoid potential > NULL pointer dereference No. If we fail to allocate c->tmp, we do uncached reads instead. -Chris ___ dri-devel mailing list

Re: [Intel-gfx] [PATCH] drm/i915: Zero initialize this_cpu in busywait_stop

2019-03-08 Thread Chris Wilson
Quoting Nathan Chancellor (2019-03-08 01:20:24) > When building with -Wsometimes-uninitialized, Clang warns: > > drivers/gpu/drm/i915/i915_request.c:1032:6: warning: variable 'this_cpu' > is used uninitialized whenever '&&' condition is false > [-Wsometimes-uninitialized] > > time_after expands

Re: [Intel-gfx] [PATCH v1 1/2] drm/selftests/mm: Switch to bitmap_zalloc()

2019-03-05 Thread Chris Wilson
Quoting Andy Shevchenko (2019-03-05 10:20:31) > On Tue, Mar 05, 2019 at 11:28:36AM +0200, Joonas Lahtinen wrote: > > I take it that both instances are supposed to call bitmap_zalloc? > > > > If you can send a v2 that compiles, I can merge it after it passes the > > CI. > > v2 had been sent

Re: [Intel-gfx] [PATCH v2 2/2] drm: i915: Switch to bitmap_zalloc()

2019-03-04 Thread Chris Wilson
Quoting Andy Shevchenko (2019-03-04 09:54:46) > On Mon, Mar 04, 2019 at 09:41:34AM +0000, Chris Wilson wrote: > > Quoting Andy Shevchenko (2019-03-04 09:29:08) > > > Switch to bitmap_zalloc() to show clearly what we are allocating. > > > Besides that it returns poi

Re: [Intel-gfx] [PATCH v2 1/2] drm/selftests/mm: Switch to bitmap_zalloc()

2019-03-04 Thread Chris Wilson
Quoting Andy Shevchenko (2019-03-04 09:29:07) > Switch to bitmap_zalloc() to show clearly what we are allocating. > Besides that it returns pointer of bitmap type instead of opaque void *. > > Signed-off-by: Andy Shevchenko Reviewed-by: Chris Wi

Re: [Intel-gfx] [PATCH v2 2/2] drm: i915: Switch to bitmap_zalloc()

2019-03-04 Thread Chris Wilson
NGS(), even though I do not see why the bitmap_[z]alloc and bitmap_free are not inlines... And for this is not the overflow protection of kcalloc silly? We start with a large value, factorise it, then check that the two factors do not overflow? If it were to overflow, it would overflow in the BITS

Re: big conflict in drm-tip (amdgpu)

2019-02-28 Thread Chris Wilson
Quoting Alex Deucher (2019-02-28 17:25:41) > On Thu, Feb 28, 2019 at 4:54 AM Chris Wilson wrote: > > > > Quoting Daniel Vetter (2019-02-28 09:49:51) > > > On Thu, Feb 28, 2019 at 5:30 AM Dave Airlie wrote: > > > > > > > > I merged some f

[PATCH] drm: Slightly quieten bad EDID messages

2019-02-28 Thread Chris Wilson
Bad EDID are a fact of life when dealing with random monitors. We only spam the logs when debugging is enabled, but we only need to raise notice and not set off the warning bells. Signed-off-by: Chris Wilson Cc: Maarten Lankhorst --- drivers/gpu/drm/drm_edid.c | 11 +-- 1 file changed

Re: [Intel-gfx] [PATCH] drm/i915/fence: Do not use TIMER_IRQSAFE

2019-02-28 Thread Chris Wilson
Quoting Thomas Gleixner (2019-02-28 10:09:26) > On Thu, 28 Feb 2019, Chris Wilson wrote: > > > Quoting Sebastian Andrzej Siewior (2019-02-26 16:00:38) > > > On 2019-02-12 17:28:57 [+0100], To linux-ker...@vger.kernel.org wrote: > > > > The timer is initialized

Re: [Intel-gfx] [PATCH] drm/i915/fence: Do not use TIMER_IRQSAFE

2019-02-28 Thread Chris Wilson
Quoting Sebastian Andrzej Siewior (2019-02-26 16:00:38) > On 2019-02-12 17:28:57 [+0100], To linux-ker...@vger.kernel.org wrote: > > The timer is initialized with TIMER_IRQSAFE flag. It does look like the > > timer callback requires this flag at all. Its sole purpose is to ensure > >

Re: big conflict in drm-tip (amdgpu)

2019-02-28 Thread Chris Wilson
Quoting Daniel Vetter (2019-02-28 09:49:51) > On Thu, Feb 28, 2019 at 5:30 AM Dave Airlie wrote: > > > > I merged some fixes into drm-fixes, pushed it out, then saw tip > > breaking, but I'm needed elsewhere, so if anyone can fix tip up or > > tell me why I got a super messy commit, I'll owe you.

Re: [PATCH] drm: Wake up next in drm_read() chain if we are forced to putback the event

2019-02-27 Thread Chris Wilson
Quoting Chris Wilson (2019-02-27 10:17:15) > Quoting Daniel Vetter (2017-08-07 10:28:58) > > On Fri, Aug 04, 2017 at 09:23:28AM +0100, Chris Wilson wrote: > > > After an event is sent, we try to copy it into the user buffer of the > > > first waiter in drm_read() and

Re: [PATCH] drm: Wake up next in drm_read() chain if we are forced to putback the event

2019-02-27 Thread Chris Wilson
Quoting Daniel Vetter (2017-08-07 10:28:58) > On Fri, Aug 04, 2017 at 09:23:28AM +0100, Chris Wilson wrote: > > After an event is sent, we try to copy it into the user buffer of the > > first waiter in drm_read() and if the user buffer doesn't have enough > > room we put

Re: [PATCH] drm/vkms: fix use-after-free when drm_gem_handle_create() fails

2019-02-26 Thread Chris Wilson
mb operations") > Cc: Rodrigo Siqueira > Cc: Haneen Mohammed > Cc: Daniel Vetter > Cc: Chris Wilson > Cc: sta...@vger.kernel.org > Signed-off-by: Eric Biggers Reviewed-by: Chris Wilson -Chris ___ dri-devel mailing list dri-devel@l

Re: [PATCH] drm/vgem: fix use-after-free when drm_gem_handle_create() fails

2019-02-26 Thread Chris Wilson
quot;drm/vgem: Enable dmabuf import interfaces") Cc: Chris Wilson Cc: Laura Abbott Cc: Daniel Vetter Sadly I reviewed it so I'm still culpable, but the fix is correct as the put purposely frees it on error. > Cc: sta...@vger.kernel.org > Signed-off-by: Eric Biggers > --- >

Re: [PATCH] drm/i915: remove redundant likely/unlikely annotation

2019-02-21 Thread Chris Wilson
Quoting Chris Wilson (2019-02-21 12:03:18) > Quoting Chengguang Xu (2019-02-21 02:08:19) > > unlikely has already included in IS_ERR(), so just > > remove redundant likely/unlikely annotation. > > > > Signed-off-by: Chengguang Xu > Reviewed-by: Chris Wilson An

Re: [PATCH] drm/i915: remove redundant likely/unlikely annotation

2019-02-21 Thread Chris Wilson
Quoting Chengguang Xu (2019-02-21 02:08:19) > unlikely has already included in IS_ERR(), so just > remove redundant likely/unlikely annotation. > > Signed-off-by: Chengguang Xu Reviewed-by: Chris Wilson -Chris ___ dri-devel mailing li

Re: [PATCH][next] drm/i915/selftests: fix memory leak of 'spin'

2019-02-19 Thread Chris Wilson
gned-off-by: Colin Ian King I hope already fixed by commit 2a4a2754039594c60b58b02b6781428a85f6d745 Author: Chris Wilson Date: Fri Feb 15 19:50:10 2019 + drm/i915/selftests: Always free spinner on __sseu_prepare error Thanks, -Chris ___ d

[PATCH i-g-t] i915/gem_exec_big: Add a single shot test

2019-02-13 Thread Chris Wilson
CI complains that the exhaustive test of trying every size up to the limit is too slow, so add a simple test that tries to submit one extreme batch buffer and check all the relocations land. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=10 Signed-off-by: Chris Wilson --- Continue

Re: [PATCH 2/3] drm: Add basic helper to allow precise pageflip timestamps in vrr.

2019-02-13 Thread Chris Wilson
Quoting Daniel Vetter (2019-02-13 09:50:55) > On Tue, Feb 12, 2019 at 10:32:31PM +0100, Mario Kleiner wrote: > > I think all kms drivers try to call drm_crtc_handle_vblank() at start > > of vblank to give Mesa the most time for frontbuffer rendering for > > classic X. But vblank events are also

[PATCH i-g-t] i915/gem_exec_big: Add a single shot test

2019-02-13 Thread Chris Wilson
CI complains that the exhaustive test of trying every size up to the limit is too slow, so add a simple test that tries to submit one extreme batch buffer and check all the relocations land. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=10 Signed-off-by: Chris Wilson --- tests/i915

[PATCH] drm/amdgpu: Transfer fences to dmabuf importer

2019-01-30 Thread Chris Wilson
the fence array. v4: Drop the fence array ref after assigning to reservation_object Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107341 Testcase: igt/amd_prime/amd-to-i915 References: 8e94a46c1770 ("drm/amdgpu: Attach exclusive fence to prime exported bo's. (v5)") Signed-off

Re: [PATCH v3 1/3] drm/i915: Block fbdev HPD processing during suspend

2019-01-29 Thread Chris Wilson
g us from > actually processing any hotplug events we receive until it's safe. > > This fixes the wakeref leak observed on the T480s and as such, also > fixes suspend/resume with MST topologies connected on this machine. > > Changes since v2: > *

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Block fbdev HPD processing during suspend

2019-01-29 Thread Chris Wilson
Quoting Lyude Paul (2019-01-28 20:56:01) > When resuming, we check whether or not any previously connected > MST topologies are still present and if so, attempt to resume them. If > this fails, we disable said MST topologies and fire off a hotplug event > so that userspace knows to reprobe. > >

Re: [PATCH] dma-buf: Enhance dma-fence tracing

2019-01-29 Thread Chris Wilson
Quoting Michael Sartain (2019-01-29 01:52:12) > On Mon, Jan 21, 2019, at 4:20 PM, Chris Wilson wrote: > > Rather than every backend and GPU driver reinventing the same wheel for > > user level debugging of HW execution, the common dma-fence framework > > should include the t

Re: [PATCH v2] drm/i915: Disable -Wuninitialized

2019-01-26 Thread Chris Wilson
itly disable the warning like commit 46e2068081e9 ("drm/i915: > > > Disable some extra clang warnings"). > > > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/220 > > > Signed-off-by: Nathan Chancellor > > > > Reviewed-by: Nick Desaulnier

Re: [PATCH] dma-buf: Enhance dma-fence tracing

2019-01-22 Thread Chris Wilson
Quoting Daniel Vetter (2019-01-22 09:11:53) > On Tue, Jan 22, 2019 at 10:06 AM Chris Wilson > wrote: > > > > Quoting Koenig, Christian (2019-01-22 08:49:30) > > > Am 22.01.19 um 00:20 schrieb Chris Wilson: > > > > Rather than every backend an

Re: [PATCH] dma-buf: Enhance dma-fence tracing

2019-01-22 Thread Chris Wilson
Quoting Koenig, Christian (2019-01-22 08:49:30) > Am 22.01.19 um 00:20 schrieb Chris Wilson: > > Rather than every backend and GPU driver reinventing the same wheel for > > user level debugging of HW execution, the common dma-fence framework > > should include the tracing in

[PATCH] dma-buf: Enhance dma-fence tracing

2019-01-21 Thread Chris Wilson
ique dma_fence_ops, and preferring to have descriptors for the whole fence context). strings do not pack as well into the ftrace ringbuffer and we would prefer to reduce the amount of indirect callbacks required for frequent tracepoint emission. Signed-off-by: Chris Wilson Cc: Joonas Lahtinen Cc: Tvrtko

Re: [RESEND PATCH v2] drm/gem: Mark pinned pages as unevictable

2019-01-09 Thread Chris Wilson
gt; [1]: > https://patchwork.freedesktop.org/patch/msgid/20181106132324.17390-1-ch...@chris-wilson.co.uk > > Signed-off-by: Kuo-Hsin Yang > Cc: Daniel Vetter > Cc: Chris Wilson > Reviewed-by: Chris Wilson No objections, so pushed to drm-misc-next. Let the screaming begin. Thanks for the patc

Re: [PATCH] drm: Reorder set_property_atomic to avoid returning with an active ww_ctx

2019-01-03 Thread Chris Wilson
Quoting Maarten Lankhorst (2019-01-03 09:03:27) > Op 30-12-2018 om 13:28 schreef Chris Wilson: > > Delay the drm_modeset_acquire_init() until after we check for an > > allocation failure so that we can return immediately upon error without > > having to unwind. > >

[PATCH] drm: Reorder set_property_atomic to avoid returning with an active ww_ctx

2018-12-30 Thread Chris Wilson
("drm: Handle properties in the core for atomic drivers") Signed-off-by: Chris Wilson Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Sean Paul Cc: David Airlie Cc: # v4.14+ --- drivers/gpu/drm/drm_mode_object.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/d

Re: [PATCH] drm/i915_request.h: Remove duplicate header

2018-12-27 Thread Chris Wilson
Quoting Brajeswar Ghosh (2018-12-25 13:23:40) > Remove i915_scheduler.h which is included more than once > > Signed-off-by: Brajeswar Ghosh Thanks for the patch, pushed to dinq. -Chris ___ dri-devel mailing list dri-devel@lists.freedesktop.org

Re: [PATCH] drm/i915: Fix i915_gem_wait_for_idle oops due to active_requests check

2018-12-20 Thread Chris Wilson
Quoting Bin Yang (2018-12-20 08:01:35) > Normally, i915_request_alloc() and i915_request_add() will be called > in sequence with drm.struct_mutex locked. But in > intel_vgpu_create_workload(), it will pre-allocate the request and > call i915_request_add() in the workload thread for performance >

Re: [PATCH v2] drm/gem: Mark pinned pages as unevictable

2018-12-18 Thread Chris Wilson
pages as unevictable to avoid the premature oom-killer > invocation. See also similar patch on i915 driver [1]. > > [1]: > https://patchwork.freedesktop.org/patch/msgid/20181106132324.17390-1-ch...@chris-wilson.co.uk > > Signed-off-by: Kuo-Hsin Yang &

Re: [PATCH] drm/i915: Disable -Wuninitialized for intel_breadcrumbs.o

2018-12-18 Thread Chris Wilson
Quoting Nick Desaulniers (2018-10-25 23:20:58) > On Thu, Oct 25, 2018 at 12:36 PM Nathan Chancellor > wrote: > > > > This warning is disabled by default in scripts/Makefile.extrawarn when > > W= is not provided but this Makefile adds -Wall after this warning is > > disabled so it shows up in the

Re: [PATCH] drm/gem: Mark pinned pages as unevictable

2018-12-14 Thread Chris Wilson
Quoting Kuo-Hsin Yang (2018-12-14 10:09:11) > On Fri, Dec 14, 2018 at 5:51 PM Chris Wilson wrote: > > > > Quoting Kuo-Hsin Yang (2018-12-14 09:33:19) > > > On Fri, Dec 14, 2018 at 4:59 PM Chris Wilson > > > wrote: > > > > > > > > &

Re: [PATCH] drm/gem: Mark pinned pages as unevictable

2018-12-14 Thread Chris Wilson
Quoting Kuo-Hsin Yang (2018-12-14 09:33:19) > On Fri, Dec 14, 2018 at 4:59 PM Chris Wilson wrote: > > > > > > Do you have a driver in mind (msm?) to demonstrate the use case? > > On Samsung Chromebook Plus, the drm/rockchip driver may call > rockchip_gem_get_page

Re: [PATCH] drm/gem: Mark pinned pages as unevictable

2018-12-14 Thread Chris Wilson
Quoting Kuo-Hsin Yang (2018-12-14 08:41:35) > The gem drivers use shmemfs to allocate backing storage for gem objects. > These shmemfs pages can be pinned by shmem_read_mapping_page_gfp(). Mark > these pinned pages as unevictable to speed up vmscan. See also similar > patch on i915 driver [1].

Re: [Intel-gfx] [PATCH 06/10] drm/syncobj: use the timeline point in drm_syncobj_find_fence v3

2018-12-13 Thread Chris Wilson
Quoting Koenig, Christian (2018-12-13 12:11:10) > Am 13.12.18 um 12:37 schrieb Chris Wilson: > > Quoting Chunming Zhou (2018-12-11 10:34:45) > >> From: Christian König > >> > >> Implement finding the right timeline point in drm_syncobj_find_fence. > &g

Re: [Intel-gfx] [PATCH 06/10] drm/syncobj: use the timeline point in drm_syncobj_find_fence v3

2018-12-13 Thread Chris Wilson
Quoting Chunming Zhou (2018-12-11 10:34:45) > From: Christian König > > Implement finding the right timeline point in drm_syncobj_find_fence. > > v2: return -EINVAL when the point is not submitted yet. > v3: fix reference counting bug, add flags handling as well > > Signed-off-by: Christian

Re: [Intel-gfx] [PATCH 01/10] dma-buf: add new dma_fence_chain container v4

2018-12-13 Thread Chris Wilson
Quoting Chunming Zhou (2018-12-11 10:34:40) > From: Christian König > > Lockless container implementation similar to a dma_fence_array, but with > only two elements per node and automatic garbage collection. > > v2: properly document dma_fence_chain_for_each, add > dma_fence_chain_find_seqno,

Re: [PATCH] drm/i915/selftests: Compile fix for 64b dma-fence seqno

2018-12-07 Thread Chris Wilson
Quoting Chris Wilson (2018-12-07 12:22:40) > Many errs of the form: > drivers/gpu/drm/i915/selftests/intel_hangcheck.c: In function > ‘__igt_reset_evict_vma’: > ./include/linux/kern_levels.h:5:18: error: format ‘%x’ expects argument of > type ‘unsigned int’, but argum Wait, there

[PATCH] drm/i915/selftests: Compile fix for 64b dma-fence seqno

2018-12-07 Thread Chris Wilson
t;) Signed-off-by: Chris Wilson Cc: Christian König Cc: Chunming Zhou Cc: Mika Kuoppala Cc: Joonas Lahtinen --- drivers/gpu/drm/i915/selftests/intel_hangcheck.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/selftests/intel_hangcheck.c b/d

Re: [PATCH] dma-buf: fix debugfs versus rcu and fence dumping v2

2018-12-06 Thread Chris Wilson
Quoting jgli...@redhat.com (2018-12-06 15:47:04) > From: Jérôme Glisse > > The debugfs take reference on fence without dropping them. Also the > rcu section are not well balance. Fix all that ... Wouldn't the code be a lot simpler (and a consistent snapshot) if it used

Re: [PATCH 1/2] drm: Only #define DEBUG if CONFIG_DYNAMIC_DEBUG is disabled

2018-12-06 Thread Chris Wilson
Quoting Michel Dänzer (2018-12-06 09:21:40) > On 2018-12-06 10:12 a.m., Chris Wilson wrote: > > Quoting Zhang, Jerry(Junwei) (2018-12-06 02:40:42) > >> On 12/6/18 12:56 AM, Michel Dänzer wrote: > >>> From: Michel Dänzer > >>> > >>> The foll

Re: [PATCH 1/2] drm: Only #define DEBUG if CONFIG_DYNAMIC_DEBUG is disabled

2018-12-06 Thread Chris Wilson
Quoting Zhang, Jerry(Junwei) (2018-12-06 02:40:42) > On 12/6/18 12:56 AM, Michel Dänzer wrote: > > From: Michel Dänzer > > > > The following cases are possible for pr_debug(): > > > > 1. CONFIG_DYNAMIC_DEBUG disabled > > a) DEBUG not defined: pr_debug() translates to no_printk(...), i.e. > >

Re: [PATCH 01/10] dma-buf: make fence sequence numbers 64 bit v2

2018-12-04 Thread Chris Wilson
Quoting Chris Wilson (2018-12-04 12:52:15) > Quoting Christian König (2018-12-04 11:59:39) > > -static inline bool __dma_fence_is_later(u32 f1, u32 f2) > > +static inline bool __dma_fence_is_later(u64 f1, u64 f2) > > { > > - return (int)(f1 - f2) > 0; >

Re: [PATCH 01/10] dma-buf: make fence sequence numbers 64 bit v2

2018-12-04 Thread Chris Wilson
Quoting Christian König (2018-12-04 11:59:39) > -static inline bool __dma_fence_is_later(u32 f1, u32 f2) > +static inline bool __dma_fence_is_later(u64 f1, u64 f2) > { > - return (int)(f1 - f2) > 0; > + /* This is for backward compatibility with drivers which can only > handle > +

Re: [PATCH v2] drm/i915: change i915_sw_fence license to MIT

2018-12-04 Thread Chris Wilson
> > Besides some mechanical tree wide changes Chris Wilson is the sole > > author of these files with Intel holding the copyright. > > > > Intel's legal team have given permission to change the license according > > to Joonas Lahtinen. > > > > v2: expan

Re: [PATCH 1/3] dma-buf: add dma_fence_get_stub

2018-12-03 Thread Chris Wilson
Quoting Christian König (2018-12-03 16:12:14) > Am 03.12.18 um 17:08 schrieb Eric Anholt: > > Christian König writes: > > > >> Extract of useful code from the timeline work. This provides a function > >> to return a stub or dummy fence which is always signaled. > >> > >> Signed-off-by: Christian

Re: [PATCH 1/3] dma-buf: add dma_fence_get_stub

2018-12-03 Thread Chris Wilson
Quoting Eric Anholt (2018-12-03 16:08:40) > Christian König writes: > > > Extract of useful code from the timeline work. This provides a function > > to return a stub or dummy fence which is always signaled. > > > > Signed-off-by: Christian König > > --- > > drivers/dma-buf/dma-fence.c | 36

Re: [PATCH 1/3] dma-buf: add dma_fence_get_stub

2018-12-03 Thread Chris Wilson
Quoting Alex Deucher (2018-12-03 15:53:21) > On Mon, Dec 3, 2018 at 8:40 AM Christian König > wrote: > > > > Am 03.12.18 um 14:33 schrieb Chunming Zhou: > > > The series is Reviewed-by: Chunming Zhou > > > > > > for patch#2, please remove my Signed-off-by, it's new when using stub > > > from

Re: [PATCH 2/3] drm/syncobj: use dma_fence_get_stub

2018-12-03 Thread Chris Wilson
Quoting Christian König (2018-12-03 13:07:58) > Extract of useful code from the timeline work. Let's use just a single > stub fence instance instead of allocating a new one all the time. > > Signed-off-by: Chunming Zhou > Signed-off-by: Christian König Reviewed-by: Chris

Re: [PATCH 1/3] dma-buf: add dma_fence_get_stub

2018-12-03 Thread Chris Wilson
Quoting Christian König (2018-12-03 13:07:57) > Extract of useful code from the timeline work. This provides a function > to return a stub or dummy fence which is always signaled. > > Signed-off-by: Christian König Reviewed-by: Chris Wi

Re: [PATCH 02/11] dma-buf: add new dma_fence_chain container v2

2018-11-29 Thread Chris Wilson
Quoting Christian König (2018-11-28 14:50:12) > +/** > + * dma_fence_chain_for_each - iterate over all fences in chain > + * @fence: starting point as well as current fence > + * > + * Iterate over all fences in the chain. We keep a reference to the current > + * fence while inside the loop which

Re: [PATCH] Return only active connectors for GET_RESOURCES

2018-11-28 Thread Chris Wilson
Quoting Stanislav Lisovskiy (2018-11-28 13:52:10) > Currently kernel might allocate different connector ids > for the same outputs in case of DP MST, which seems to > confuse userspace. There are can be different connector > ids in the list, which could be assigned to the same > output, while

Re: [Intel-gfx] [PATCH 3/3] mm, notifier: Add a lockdep map for invalidate_range_start

2018-11-27 Thread Chris Wilson
Quoting Daniel Vetter (2018-11-27 17:28:43) > On Tue, Nov 27, 2018 at 5:50 PM Chris Wilson wrote: > > > > Quoting Daniel Vetter (2018-11-27 07:49:18) > > > On Thu, Nov 22, 2018 at 05:51:06PM +0100, Daniel Vetter wrote: > > > > This is a similar idea to th

Re: [Intel-gfx] [PATCH 3/3] mm, notifier: Add a lockdep map for invalidate_range_start

2018-11-27 Thread Chris Wilson
Quoting Daniel Vetter (2018-11-27 07:49:18) > On Thu, Nov 22, 2018 at 05:51:06PM +0100, Daniel Vetter wrote: > > This is a similar idea to the fs_reclaim fake lockdep lock. It's > > fairly easy to provoke a specific notifier to be run on a specific > > range: Just prep it, and then munmap() it. >

Re: [PATCH] drm: should return upon the best size(v3)

2018-11-27 Thread Chris Wilson
Quoting Monk Liu (2018-11-27 03:10:34) > v2: > amend description: > for RB tree traveler we don't need to travel to > the bottom level if already found the equal size node, > thus the search performance can get improved. > > v3: > split "<=" to "<" case and "==" case > > Tested-by: Rex Zhu >

RE: FW: [PATCH] drm: should break if already get the best size

2018-11-23 Thread Chris Wilson
Quoting Liu, Monk (2018-11-23 09:11:02) > What do you mean the first in the chain ? and also can you explain the " > perfect match." ? thanks > > Assume there is couple nodes equal to the size you requested, without this > patch it will traveler to the bottom level of the RB tree and gives you

Re: FW: [PATCH] drm: should break if already get the best size

2018-11-23 Thread Chris Wilson
Quoting Liu, Monk (2018-11-23 08:02:11) > > > -Original Message- > From: amd-gfx On Behalf Of Monk Liu > Sent: Thursday, November 22, 2018 8:33 PM > To: amd-...@lists.freedesktop.org > Cc: Liu, Monk > Subject: [PATCH] drm: should break if already get the best size > > Signed-off-by:

Re: [Intel-gfx] [PATCH 1/3] mm: Check if mmu notifier callbacks are allowed to fail

2018-11-22 Thread Chris Wilson
Quoting Daniel Vetter (2018-11-22 16:51:04) > Just a bit of paranoia, since if we start pushing this deep into > callchains it's hard to spot all places where an mmu notifier > implementation might fail when it's not allowed to. Most callers could handle the failure correctly. It looks like the

Re: [v3 2/3] drm: Add DP colorspace property

2018-11-20 Thread Chris Wilson
Quoting Uma Shankar (2018-11-20 14:22:10) > @@ -1457,6 +1480,18 @@ int drm_mode_create_colorspace_property(struct > drm_connector *connector) > return -ENOMEM; > > dev->mode_config.hdmi_colorspace_property = prop; > + } else if

[PATCH] drm/amdgpu: Reorder uvd ring init before uvd resume

2018-11-16 Thread Chris Wilson
d at (133146): [] __do_softirq+0x365/0x47c [5.596748] softirqs last disabled at (133139): [] irq_exit+0x119/0x120 [5.596749] ---[ end trace eaee508abfebccdc ]--- Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108709 Signed-off-by: Chris Wilson Cc: Alex Deucher --- drivers/gpu/dr

Re: [PATCH xf86-video-intel v8 2/2] sna: Added AYUV format support for textured and sprite video adapters.

2018-11-13 Thread Chris Wilson
Quoting Ville Syrjälä (2018-11-13 19:13:40) > On Tue, Nov 13, 2018 at 06:49:38PM +0000, Chris Wilson wrote: > > Quoting Stanislav Lisovskiy (2018-11-13 07:45:02) > > > @@ -408,6 +424,9 @@ void sna_video_textured_setup(struct sna *sna, > > > ScreenPtr screen) > > &

Re: [PATCH xf86-video-intel v8 2/2] sna: Added AYUV format support for textured and sprite video adapters.

2018-11-13 Thread Chris Wilson
Quoting Stanislav Lisovskiy (2018-11-13 07:45:02) > @@ -408,6 +424,9 @@ void sna_video_textured_setup(struct sna *sna, ScreenPtr > screen) > } else if (sna->kgem.gen < 040) { > adaptor->nImages = ARRAY_SIZE(gen3_Images); > adaptor->pImages = (XvImageRec

Re: [PATCH v2] Fix the possible watermark miswriting for skl+

2018-11-13 Thread Chris Wilson
Quoting Stanislav Lisovskiy (2018-11-13 14:31:38) > Currently whenever we attempt to recalculate > watermarks, we assign dirty_pipes to zero, > then compare current wm results to the recalculated > one and if they changed we set correspondent dirty_pipes > bit again. > This can lead to situation,

[PATCH] drm/syncobj: Fix compilation following partial revert

2018-11-12 Thread Chris Wilson
We need to include the revert of commit 783195ec1cad ("drm/syncobj: disable the timeline UAPI for now v2") along with undoing the change to drm/i915. Fixes: 131280a162e7 ("drm: Revert syncobj timeline changes.") Signed-off-by: Chris Wilson Cc: Christian König Cc: Daniel Vett

Re: [PATCH 2/2] drm: Revert syncobj timeline changes.

2018-11-12 Thread Chris Wilson
Quoting Christian König (2018-11-12 10:16:01) > Am 09.11.18 um 23:26 schrieb Eric Anholt: > > Eric Anholt writes: > > > [ Unknown signature status ] > zhoucm1 writes: > > > On 2018年11月09日 00:52, Christian König wrote: > > Am 08.11.18 um 17:07

Re: [PATCH] drm: Revert "add syncobj timeline support v9"

2018-11-10 Thread Chris Wilson
Quoting Christian König (2018-10-19 10:27:11) > From: Christian König > > Still contains some bugs. > > This reverts commit 48197bc564c7a1888c86024a1ba4f956e0ec2300. > > Bugs: https://bugs.freedesktop.org/show_bug.cgi?id=108490 > Signed-off-by: Christian König The code for the old style of

Re: [PATCH][drm-next] drm/i915/csr: fix spelling mistake "firmare" -> "firmware"

2018-11-07 Thread Chris Wilson
Quoting Colin King (2018-11-07 10:22:11) > From: Colin Ian King > > Trivial fix to spelling mistake in DRM_INFO message > > Signed-off-by: Colin Ian King Thank you for the spelling correction, applied. -Chris ___ dri-devel mailing list

[PATCH] drm: Propagate failure from drm_modeset_register_all() on module load

2018-11-06 Thread Chris Wilson
If we fail to register all the initial CRTCs and connectors, report that failure back to the caller. Signed-off-by: Chris Wilson --- drivers/gpu/drm/drm_drv.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c

Re: [PATCH] drm/vgem: create a render node for vgem

2018-11-05 Thread Chris Wilson
Quoting kbuild test robot (2018-10-26 16:55:25) > Hi Emil, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on sof-driver-fuweitax/master] > [also build test ERROR on v4.19 next-20181019] > [if your patch is applied to the wrong git tree, please drop us a note to

Re: [PATCH 2/3] drm/file: Uncompact the feature flags

2018-11-02 Thread Chris Wilson
Quoting Daniel Vetter (2018-11-02 13:25:42) > This essentially undoes > > commit 39868bd7668bd47308b1dfd97c212757caee764f > Author: Chris Wilson > Date: Tue Oct 29 08:55:58 2013 + > > drm: Compact booleans within struct drm_file > > We do lockless acces

Re: [PATCH v2] drm/msm: Move fence put to where failure occurs

2018-11-02 Thread Chris Wilson
Quoting Robert Foss (2018-11-02 12:13:13) > If dma_fence_wait fails to wait for a supplied in-fence in > msm_ioctl_gem_submit, make sure we release that in-fence. > > Also remove this dma_fence_put() from the 'out' label. > > Signed-off-by: Robert Foss Reviewed-by:

Re: [PATCH v1] drm/msm: Move fence put to where failure occurs

2018-11-01 Thread Chris Wilson
Quoting Robert Foss (2018-11-01 16:12:28) > If dma_fence_wait fails to wait for a supplied in-fence in > msm_ioctl_gem_submit, make sure we release that in-fence. > > Also remove this dma_fence_put() from the 'out' label. > > Signed-off-by: Robert Foss > --- >

Re: [PATCH] drm/syncobj: Mark local add/remove callback functions as static

2018-11-01 Thread Chris Wilson
Quoting zhoucm1 (2018-11-01 08:53:02) > > > On 2018年10月31日 20:07, Chris Wilson wrote: > > drivers/gpu/drm/drm_syncobj.c:181:6: warning: no previous prototype for > > ‘drm_syncobj_add_callback’ [-Wmissing-prototypes] > > drivers/gpu/drm/drm_syncobj.c:190:6: war

[PATCH] drm/syncobj: Mark local add/remove callback functions as static

2018-10-31 Thread Chris Wilson
/drm_syncobj.c:181:13: warning: ‘drm_syncobj_add_callback’ defined but not used [-Wunused-function] so remove the unused drm_syncobj_add_callback() entirely. Signed-off-by: Chris Wilson --- drivers/gpu/drm/drm_syncobj.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git

Re: [PATCH] drm/i915: change i915_sw_fence license to MIT

2018-10-31 Thread Chris Wilson
Quoting Jonathan Gray (2018-10-31 00:56:12) > Chris Wilson said Intel is willing to change the license of these files > to MIT. > > Signed-off-by: Jonathan Gray Reviewed-by: Chris Wilson -Chris ___ dri-devel mailing li

  1   2   3   4   5   6   7   8   9   10   >