Re: [PATCH 1/2] drm: panel-simple: Add simple-panel driver.

2019-04-10 Thread Heiko Stübner
Hi Christoph, Am Mittwoch, 10. April 2019, 16:10:44 CEST schrieb Christoph Muellner: > On our RK3399-Q7 EVK base board we have the option to connect an arbitrary > monitor via DP cable. The actual monitor is therefore not known in advance. > This means, we don't have any panel information besides

Re: [PATCH v4 6/7] ARM: dts: rockchip: Specify rk3288-veyron-jerry's display timings

2019-03-29 Thread Heiko Stübner
Am Donnerstag, 28. März 2019, 18:17:09 CET schrieb Douglas Anderson: > Let's document the display timings that jerry has been using out in > the field. This uses the standard blankings but a slightly slower > clock rate, thus getting a refresh rate 58.3 Hz. > > NOTE: this won't really do

Re: [PATCH v4 4/7] drm/panel: simple: Use display_timing for Innolux n116bge

2019-03-29 Thread Heiko Stübner
Am Donnerstag, 28. März 2019, 18:17:07 CET schrieb Douglas Anderson: > Convert the Innolux n116bge from using a fixed mode to specifying a > display timing with min/typ/max values. > > Note that the n116bge's datasheet doesn't fit too well into DRM's way > of specifying things. Specifically the

Re: [PATCH v4 2/7] drm/panel: simple: Add ability to override typical timing

2019-03-29 Thread Heiko Stübner
Am Donnerstag, 28. März 2019, 18:17:05 CET schrieb Douglas Anderson: > From: Sean Paul > > This patch adds the ability to override the typical display timing for a > given panel. This is useful for devices which have timing constraints > that do not apply across the entire display driver (eg: to

Re: [PATCH v2 3/5] drm/rockchip: Use the helpers for PSR

2019-03-29 Thread Heiko Stübner
Am Freitag, 29. März 2019, 20:00:10 CET schrieb Sean Paul: > On Fri, Mar 29, 2019 at 07:51:51PM +0100, Heiko Stübner wrote: > > Hi, > > > > Am Dienstag, 26. März 2019, 21:44:56 CET schrieb Sean Paul: > > > From: Sean Paul > > > > > > Instead of

Re: [PATCH v2 3/5] drm/rockchip: Use the helpers for PSR

2019-03-29 Thread Heiko Stübner
Hi, Am Dienstag, 26. März 2019, 21:44:56 CET schrieb Sean Paul: > From: Sean Paul > > Instead of rolling our own implementation for tracking when PSR should > be [in]active, use the new self refresh helpers to do the heavy lifting. I only got patches 3-5 and had to pull 1+2 from patchwork, the

Re: [PATCH v4 1/4] drm: rockchip: introduce rk3066 hdmi

2019-03-19 Thread Heiko Stübner
Hi Johan, Am Mittwoch, 6. März 2019, 23:41:10 CET schrieb Johan Jonker: > From: Zheng Yang > > The RK3066 HDMI TX serves as interface between a LCD Controller and > a HDMI bus. A HDMI TX consists of one HDMI transmitter controller and > one HDMI transmitter PHY. The interface has three (3)

Re: [PATCH 13/17] drm/rockchip: Convert to using __drm_atomic_helper_crtc_reset() for reset.

2019-03-18 Thread Heiko Stübner
Lankhorst > Cc: Sandy Huang > Cc: "Heiko Stübner" > Cc: linux-rockc...@lists.infradead.org so I've looked up the patch2 that introduces __drm_atomic_helper_crtc_reset in patchwork and compared results and everything looks as it should be I think ;-)

Re: [PATCH] drm/rockchip: vop: reset scale mode when win is disabled

2019-03-18 Thread Heiko Stübner
Hi Jonas, Am Mittwoch, 20. Februar 2019, 23:40:06 CET schrieb Jonas Karlman: > NV12 framebuffers produced by the VPU shows distorted on RK3288 > after win has been disabled when scaling is active. > > This issue can be reproduced using a 1080p modeset by: > - Scale a 1280x720 NV12 framebuffer to

Re: linux-next: Fixes tag needs some work in the drm-fixes tree

2019-02-08 Thread Heiko Stübner
Am Freitag, 8. Februar 2019, 12:40:22 CET schrieb Stephen Rothwell: > Hi Heiko, > > On Fri, 08 Feb 2019 12:31:38 +0100 Heiko Stübner wrote: > > we had this warning already from the drm-misc-fixes tree :-) . > > Sorry about that ... there goes my memory again :-) No wo

Re: linux-next: Fixes tag needs some work in the drm-fixes tree

2019-02-08 Thread Heiko Stübner
Am Freitag, 8. Februar 2019, 12:01:37 CET schrieb Stephen Rothwell: > Hi all, > > In commit > > 053ff09f1a8f ("drm/rockchip: rgb: update SPDX license identifier") > > Fixes tag > > Fixes: 1f0f01515172 ("Add support for Rockchip Soc RGB output interface") > > has these problem(s): > > -

Re: [PATCH] dt-bindings: display: add binding for Innolux ee101ia-01d panel

2019-01-29 Thread Heiko Stübner
Hi Thierry, Am Dienstag, 13. November 2018, 13:42:05 CET schrieb Heiko Stuebner: > From: Heiko Stuebner > > This is a panel handled through the generic lvds-panel binding, > so only needs its additional compatible specified. > > Signed-off-by: Heiko Stuebner just pulling this pending patch

Re: [PATCH] drm/rockchip: Allow driver to be shutdown on reboot/kexec

2018-12-05 Thread Heiko Stübner
Hi Brian, Am Mittwoch, 5. Dezember 2018, 04:01:34 CET schrieb Brian Norris: > + others > > Hi, > > On Sun, Aug 05, 2018 at 01:48:07PM +0100, Marc Zyngier wrote: > > Leaving the DRM driver enabled on reboot or kexec has the annoying > > effect of leaving the display generating transactions

Re: [PATCH 1/9] mm: Introduce new vm_insert_range API

2018-11-28 Thread Heiko Stübner
Am Donnerstag, 15. November 2018, 16:45:30 CET schrieb Souptick Joarder: > Previouly drivers have their own way of mapping range of > kernel pages/memory into user vma and this was done by > invoking vm_insert_page() within a loop. > > As this pattern is common across different drivers, it can >

Re: [PATCH 4/9] drm/rockchip/rockchip_drm_gem.c: Convert to use vm_insert_range

2018-11-28 Thread Heiko Stübner
Hi Souptick, Am Montag, 26. November 2018, 06:36:42 CET schrieb Souptick Joarder: > On Thu, Nov 15, 2018 at 9:14 PM Souptick Joarder wrote: > > Convert to use vm_insert_range() to map range of kernel > > memory to user vma. > > > > Signed-off-by: Souptick Joarder > > Any feedback for this

Re: [PATCH] drm/fbdev: Make skip_vt_switch the default

2018-11-28 Thread Heiko Stübner
Am Dienstag, 27. November 2018, 18:34:24 CET schrieb Daniel Vetter: > KMS drivers really should all be able to restore their display state > on resume without fbcon helping out. So make this the default. > > Since I'm not entirely foolish, make it only a default, which drivers > can still

Re: [PATCH] drm/panel: Set max rate for Innolux p079x panels

2018-11-14 Thread Heiko Stübner
Hi Linus, Am Mittwoch, 14. November 2018, 12:42:54 CET schrieb Linus Walleij: > After adding the hs_rate and lp_rate fields to the DSI device > we need to populate these accordingly so display drivers can > respect them. > > Cc: Andrzej Hajda > Cc: Chris Zhong > Cc: Lin Huang > Cc: Heiko

Re: [PATCH v2 2/8] drm/bridge/synopsys: dsi: don't call __dw_mipi_dsi_probe from dw_mipi_dsi_bind

2018-07-03 Thread Heiko Stübner
Am Dienstag, 3. Juli 2018, 14:16:28 CEST schrieb Andrzej Hajda: > On 18.06.2018 12:28, Heiko Stuebner wrote: > > __dw_mipi_dsi_probe() does all the grabbing of resources and does it using > > devm-helpers. So this is happening on each try of master bringup possibly > > slowing down things a lot. >

Re: [PATCH 12/12] drm/rockchip: add support for CDNS MHDP IP controller.

2018-07-03 Thread Heiko Stübner
Hi Damien, it's very cool to see collaboration from vendors on this. Am Dienstag, 3. Juli 2018, 12:02:23 CEST schrieb Damian Kos: > It would be really nice to explain a bit about the added controller support in the commit message, so that people reviewing the patch can get a feeling for it. >

Re: [PATCH 03/10] drm/rockchip/crc: Implement verify_crc_source callback

2018-07-03 Thread Heiko Stübner
Hi Maarten, Am Dienstag, 3. Juli 2018, 12:16:41 CEST schrieb Maarten Lankhorst: > Op 02-07-18 om 13:07 schreef Mahesh Kumar: > > This patch implements "verify_crc_source" callback function for > > rockchip drm driver. > > > > Changes since V1: > > - simplify the verification (Jani N) > > > >

Re: [PATCH] drm/rockchip: vop: fixup linebuffer mode calc error

2018-06-26 Thread Heiko Stübner
Am Dienstag, 26. Juni 2018, 10:16:44 CEST schrieb Sandy Huang: > linebuffer mode should be LB_YUV_3840X5 when width is bigger > than 1280 in yuv mode. > seperate yuv and rgb case make the scl_vop_cal_lb_mode() logic > is clearer. > > Signed-off-by: Sandy Huang > Link: >

Re: [PATCH v4 2/2] drm/rockchip: vop: fix irq disabled after vop driver probed

2018-06-18 Thread Heiko Stübner
Hi Marc, Am Mittwoch, 13. Juni 2018, 15:01:27 CEST schrieb Marc Zyngier: > On 12/06/18 14:20, Heiko Stuebner wrote: > > From: Sandy Huang > > > > The vop irq is shared between vop and iommu and irq probing in the > > iommu driver moved to the probe function recently. This can in some > > cases

Re: [PATCH 1/2] drm/rockchip: cnd-dp: adjust spdif register setting

2018-06-16 Thread Heiko Stübner
Am Dienstag, 22. Mai 2018, 10:53:41 CEST schrieb Lin Huang: > We use jitter bypass mode for spdif, so do not need to set jitter mode > related bit in SPDIF_CTRL_ADDR register. Also, we need to enable > SPDIF_ENABLE bit. > > Signed-off-by: Chris Zhong > Signed-off-by: Lin Huang applied to

Re: [PATCH 5/5] drm/rockchip: lvds: add missing of_node_put

2018-06-16 Thread Heiko Stübner
Hi Julia, Am Mittwoch, 23. Mai 2018, 21:07:16 CEST schrieb Julia Lawall: > The device node iterators perform an of_node_get on each iteration, so a > jump out of the loop requires an of_node_put. > > The semantic patch that fixes this problem is as follows > (http://coccinelle.lip6.fr): > > //

Re: [RFC v2 2/2] dt-bindings: mipi-dsi: Add dual-channel DSI related info

2018-06-07 Thread Heiko Stübner
Hi Andrzej, Am Donnerstag, 7. Juni 2018, 12:39:03 CEST schrieb Andrzej Hajda: > On 07.06.2018 01:08, Heiko Stuebner wrote: > > Am Mittwoch, 6. Juni 2018, 18:07:46 CEST schrieb Archit Taneja: > >> On Wednesday 06 June 2018 04:16 PM, Heiko Stübner wrote: > >>> Hi Archi

Re: [RFC v2 2/2] dt-bindings: mipi-dsi: Add dual-channel DSI related info

2018-06-06 Thread Heiko Stübner
Hi Archit, Am Mittwoch, 6. Juni 2018, 12:21:16 CEST schrieb Archit Taneja: > On Wednesday 06 June 2018 02:00 PM, Heiko Stübner wrote: > > Am Mittwoch, 6. Juni 2018, 07:59:29 CEST schrieb Archit Taneja: > >> On Monday 04 June 2018 05:47 PM, Heiko Stuebner wrote: > >>

Re: [RFC v2 2/2] dt-bindings: mipi-dsi: Add dual-channel DSI related info

2018-06-06 Thread Heiko Stübner
Am Mittwoch, 6. Juni 2018, 07:59:29 CEST schrieb Archit Taneja: > On Monday 04 June 2018 05:47 PM, Heiko Stuebner wrote: > > Am Donnerstag, 18. Januar 2018, 05:53:55 CEST schrieb Archit Taneja: > >> Add binding info for peripherals that support dual-channel DSI. Add > >> corresponding optional

Re: [PATCH v7 1/5] drm/rockchip: add transfer function for cdn-dp

2018-06-05 Thread Heiko Stübner
Hi, Am Mittwoch, 23. Mai 2018, 09:42:29 CEST schrieb Lin Huang: > From: Chris Zhong > > We may support training outside firmware, so we need support > dpcd read/write to get the message or do some setting with > display. > > Signed-off-by: Chris Zhong > Signed-off-by: Lin Huang >

Re: [PATCH v2 2/2] drm/rockchip: vop: fix irq disabled after vop driver probed

2018-05-29 Thread Heiko Stübner
Am Dienstag, 29. Mai 2018, 13:59:42 CEST schrieb Robin Murphy: > On 28/05/18 14:20, Heiko Stuebner wrote: > > From: Sandy Huang > > > > The vop irq is shared between vop and iommu and irq probing in the > > iommu driver moved to the probe function recently. This can in some > > cases lead to a

[PATCH] drm/rockchip: vop: fix irq disabled after vop driver probed

2018-05-24 Thread Heiko Stübner
From: Sandy Huang The vop irq is shared between vop and iommu and irq probing in the iommu driver moved to the probe function recently. This can in some cases lead to a stall if the irq is triggered while the vop driver still has it disabled. But there is no real need to

Re: [PATCH 05/24] drm/rockchip: rockchip_drm_fb -> drm_framebuffer

2018-05-17 Thread Heiko Stübner
Signed-off-by: Daniel Stone <dani...@collabora.com> > > Cc: Sandy Huang <h...@rock-chips.com> > > Cc: Heiko Stübner <he...@sntech.de> > > Ping? I only see the cover-letter (not listing all patches of the series) plus patches 4+5 of the series, nothing else. Both patches

Re: [PATCH 0/3] drm/rockchip: VOP interrupt fixes

2018-03-14 Thread Heiko Stübner
Am Dienstag, 20. Februar 2018, 14:01:17 CET schrieb Marc Zyngier: > This small series fixes a number of issues that I found while trying > to get kexec working on the Chromebook Plus (aka rk3399-gru-kevin) in > order to use it as some sort of interactive bootloader. > > The main issue is that the

Re: [PATCH v5 06/36] drm/rockchip: Only wait for panel ACK on PSR entry

2018-03-14 Thread Heiko Stübner
Am Freitag, 9. März 2018, 23:22:57 CET schrieb Enric Balletbo i Serra: > From: zain wang > > We currently wait for the panel to mirror our intended PSR state > before continuing on both PSR enter and PSR exit. This is really > only important to do when we're entering PSR,

Re: [PATCH v5 05/36] drm/bridge: analogix_dp: add fast link train for eDP

2018-03-14 Thread Heiko Stübner
Am Freitag, 9. März 2018, 23:22:56 CET schrieb Enric Balletbo i Serra: > From: zain wang > > We would meet a short black screen when exit PSR with the full link > training, In this case, we should use fast link train instead of full > link training. > > Signed-off-by: zain

Re: [PATCH v5 03/36] drm/bridge: analogix_dp: Don't change psr while bridge is disabled

2018-03-14 Thread Heiko Stübner
Am Freitag, 9. März 2018, 23:22:54 CET schrieb Enric Balletbo i Serra: > From: zain wang > > There is a race between AUX CH bring-up and enabling bridge which will > cause link training to fail. To avoid hitting it, don't change psr state > while enabling the bridge. > >

Re: [PATCH v5 04/36] drm/rockchip: add mutex vop lock

2018-03-14 Thread Heiko Stübner
Am Freitag, 9. März 2018, 23:22:55 CET schrieb Enric Balletbo i Serra: > From: zain wang > > Add a lock to vop to avoid disabling the crtc while waiting for a line > flag while enabling psr. If we disable in the middle of waiting for the > line flag, we'll end up timing out

Re: [PATCH v5 02/36] drm/rockchip: Remove analogix psr worker

2018-03-14 Thread Heiko Stübner
Am Freitag, 9. März 2018, 23:22:53 CET schrieb Enric Balletbo i Serra: > From: Sean Paul > > Now that the spinlocks and timers are gone, we can remove the psr > worker located in rockchip's analogix driver and do the enable/disable > directly. This should simplify the code

Re: [PATCH v5 01/36] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2018-03-14 Thread Heiko Stübner
Am Freitag, 9. März 2018, 23:22:52 CET schrieb Enric Balletbo i Serra: > From: Yakir Yang > > Make sure the request PSR state takes effect in analogix_dp_send_psr_spd() > function, or print the sink PSR error state if we failed to apply the > requested PSR setting. > > Cc:

Re: [PATCH v5 00/36] DRM Rockchip rk3399 (Kevin)

2018-03-12 Thread Heiko Stübner
Am Freitag, 9. März 2018, 23:22:51 CET schrieb Enric Balletbo i Serra: > Hi, > > This patchset includes cleanups, improvements, and bug fixes for > Rockchip DRM driver and PSR support. > > This new version is the same as before removing some of the patches > already applied and fixing the Exynos

Re: [PATCH v5 19/36] drm/rockchip: Restore psr->state when enable/disable psr failed

2018-03-12 Thread Heiko Stübner
Am Freitag, 9. März 2018, 23:23:10 CET schrieb Enric Balletbo i Serra: > From: zain wang > > If we failed disable psr, it would hang the display until next psr > cycle coming. So we should restore psr->state when it failed. > > Cc: Tomasz Figa >

Re: [PATCH v5 03/36] drm/bridge: analogix_dp: Don't change psr while bridge is disabled

2018-03-12 Thread Heiko Stübner
Am Freitag, 9. März 2018, 23:22:54 CET schrieb Enric Balletbo i Serra: > From: zain wang > > There is a race between AUX CH bring-up and enabling bridge which will > cause link training to fail. To avoid hitting it, don't change psr state > while enabling the bridge. > >

Re: [PATCH v5 01/36] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2018-03-12 Thread Heiko Stübner
Am Freitag, 9. März 2018, 23:22:52 CET schrieb Enric Balletbo i Serra: > From: Yakir Yang > > Make sure the request PSR state takes effect in analogix_dp_send_psr_spd() > function, or print the sink PSR error state if we failed to apply the > requested PSR setting. > > Cc:

Re: [PATCH v5 06/36] drm/rockchip: Only wait for panel ACK on PSR entry

2018-03-12 Thread Heiko Stübner
Hi, the subject is misleading I think, as this is touching only the generic bridge code and not anything Rockchip-related, so should probably be "drm/bridge"? Am Freitag, 9. März 2018, 23:22:57 CET schrieb Enric Balletbo i Serra: > From: zain wang > > We currently wait for

Re: [PATCH v5 04/36] drm/rockchip: add mutex vop lock

2018-03-12 Thread Heiko Stübner
Am Freitag, 9. März 2018, 23:22:55 CET schrieb Enric Balletbo i Serra: > From: zain wang > > Add a lock to vop to avoid disabling the crtc while waiting for a line > flag while enabling psr. If we disable in the middle of waiting for the > line flag, we'll end up timing out

Re: [PATCH v5 02/36] drm/rockchip: Remove analogix psr worker

2018-03-12 Thread Heiko Stübner
Am Freitag, 9. März 2018, 23:22:53 CET schrieb Enric Balletbo i Serra: > From: Sean Paul > > Now that the spinlocks and timers are gone, we can remove the psr > worker located in rockchip's analogix driver and do the enable/disable > directly. This should simplify the code

Re: [PATCH v9 4/5] drm/rockchip: dw_hdmi: Move HDMI vpll clock enable to bind()

2018-03-08 Thread Heiko Stübner
Am Freitag, 2. März 2018, 18:57:56 CET schrieb Enric Balletbo i Serra: > From: Jeffy Chen > > The HDMI vpll clock should be enabled when bind() is called. So move the > clk_prepare_enable of that clock to bind() function and add the missing > clk_disable_unprepare()

Re: [PATCH v9 3/5] drm/rockchip: inno_hdmi: reorder clk_disable_unprepare call in unbind

2018-03-08 Thread Heiko Stübner
Am Freitag, 2. März 2018, 18:57:55 CET schrieb Enric Balletbo i Serra: > From: Jeffy Chen > > In bind the clk_prepare_enable of the HDMI pclk is called before adding the > i2c_adapter. So it should be the other way around in unbind, first remove > the i2c_adapter and

Re: [PATCH v9 1/5] drm/rockchip: dw-mipi-dsi: Fix connector and encoder cleanup.

2018-03-08 Thread Heiko Stübner
Am Freitag, 2. März 2018, 18:57:53 CET schrieb Enric Balletbo i Serra: > From: Jeffy Chen > > In bind()'s error handling path call destroy functions instead of > cleanup functions for encoder and connector and reorder to match how is > called in bind(). > > In

Re: [PATCH v9 2/5] drm/rockchip: inno_hdmi: Fix error handling path.

2018-03-08 Thread Heiko Stübner
Am Freitag, 2. März 2018, 18:57:54 CET schrieb Enric Balletbo i Serra: > From: Jeffy Chen > > Add missing error handling in bind(). > > Fixes: 412d4ae6b7a5 ("drm/rockchip: hdmi: add Innosilicon HDMI support") > Signed-off-by: Jeffy Chen >

Re: [PATCH 3/3] drm/bridge: analogix_dp: Don't create useless connectors

2018-03-05 Thread Heiko Stübner
Am Montag, 5. März 2018, 09:57:41 CET schrieb Marek Szyprowski: > If there is another bridge after analogix_dp, then the connector object > should not be created. This fixes following timeouts on Exynos5420-based > Chromebook2 Peach-PIT board during boot: > > exynos-dp 145b.dp-controller: AUX

Re: [PATCH 2/3] drm/bridge: analogix_dp: Postpone enabling runtime power management

2018-03-05 Thread Heiko Stübner
Am Montag, 5. März 2018, 09:57:40 CET schrieb Marek Szyprowski: > Enabling runtime power management early in analogix_dp_bind() causes > following kernel NULL pointer dereference: > > Unable to handle kernel NULL pointer dereference at virtual address 07d8 > pgd = 28ffa2e4 > [07d8]

Re: [PATCH 1/3] drm/bridge: analogix_dp: Don't power bridge in analogix_dp_bind

2018-03-05 Thread Heiko Stübner
Am Montag, 5. März 2018, 09:57:39 CET schrieb Marek Szyprowski: > From: zain wang > > The bridge does not need to be powered in analogix_dp_bind(), so > remove the calls to pm_runtime_get()/phy_power_on()/analogix_dp_init_dp() > as well as their power-off counterparts. > >

Re: [PATCH v8 4/8] drm/rockchip: dw-mipi-dsi: Fix error handling path

2018-03-01 Thread Heiko Stübner
Hi Jeffy, Thierry, Enric, Am Mittwoch, 10. Januar 2018, 17:23:44 CET schrieb Thierry Escande: > From: Jeffy Chen > > Add missing pm_runtime_disable() in bind()'s error handling path. > > Also cleanup encoder & connector in unbind(). Can you please split all these

Re: [PATCH v8 7/8] drm/bridge/synopsys: dw-hdmi: Do not use device's drvdata

2018-03-01 Thread Heiko Stübner
Am Mittwoch, 10. Januar 2018, 17:23:47 CET schrieb Thierry Escande: > From: Jeffy Chen > > Let plat drivers own the drvdata, so that they could cleanup resources > in their unbind(). > > Signed-off-by: Jeffy Chen > Signed-off-by: Thierry

Re: [PATCH v8 3/8] drm/rockchip: analogix_dp: Add a sanity check for rockchip_drm_psr_register()

2018-03-01 Thread Heiko Stübner
Am Mittwoch, 10. Januar 2018, 17:23:43 CET schrieb Thierry Escande: > From: Jeffy Chen > > The rockchip_drm_psr_register() can fail, so add a sanity check for that. > > Also reorder the calls in unbind() to match bind(). > > Signed-off-by: Jeffy Chen

Re: [PATCH v8 2/8] drm/bridge: analogix_dp: Fix connector and encoder cleanup

2018-03-01 Thread Heiko Stübner
Am Mittwoch, 10. Januar 2018, 17:23:42 CET schrieb Thierry Escande: > From: Jeffy Chen > > Since we are initing connector in the core driver and encoder in the > plat driver, let's clean them up in the right places. > > Signed-off-by: Jeffy Chen

Re: [PATCH v8 1/8] drm/bridge: analogix: Do not use device's drvdata

2018-03-01 Thread Heiko Stübner
Am Mittwoch, 10. Januar 2018, 17:23:41 CET schrieb Thierry Escande: > From: Jeffy Chen > > The driver that instantiates the bridge should own the drvdata, as all > driver model callbacks (probe, remove, shutdown, PM ops, etc.) are also > owned by its driver struct.

Re: [PATCH v5] drm/rockchip: Add device links for master and components

2018-03-01 Thread Heiko Stübner
Am Mittwoch, 7. Februar 2018, 18:53:09 CET schrieb Enric Balletbo i Serra: > From: Jeffy Chen > > Since we are trying to access components' resources in the master's > suspend/resume PM callbacks(e.g. panel), add device links to correct > the suspend/resume and

Re: [PATCH] drm/rockchip: vop: Init vskiplines in scl_vop_cal_scale()

2018-03-01 Thread Heiko Stübner
Am Freitag, 23. Februar 2018, 07:22:50 CET schrieb Jeffy Chen: > Currently we are calling scl_vop_cal_scale() to get vskiplines for yrgb > and cbcr. So the cbcr's vskiplines might be an unexpected value if the > second scl_vop_cal_scale() didn't update it. > > Init vskiplines in

Re: [PATCH v3 05/43] drm/bridge: analogix_dp: Don't power bridge in analogix_dp_bind

2018-02-28 Thread Heiko Stübner
Am Dienstag, 30. Januar 2018, 21:28:35 CET schrieb Thierry Escande: > From: zain wang > > The bridge does not need to be powered in analogix_dp_bind(), so > remove the calls to pm_runtime_get()/phy_power_on()/analogix_dp_init_dp() > as well as their power-off counterparts. >

Re: [PATCH v3 05/43] drm/bridge: analogix_dp: Don't power bridge in analogix_dp_bind

2018-02-28 Thread Heiko Stübner
Am Mittwoch, 28. Februar 2018, 15:54:30 CET schrieb Marc Zyngier: > On 28/02/18 14:37, Heiko Stübner wrote: > > Am Dienstag, 30. Januar 2018, 21:28:35 CET schrieb Thierry Escande: > >> From: zain wang <w...@rock-chips.com> > >> > >> The bridge does not ne

Re: [PATCH v3 05/43] drm/bridge: analogix_dp: Don't power bridge in analogix_dp_bind

2018-02-28 Thread Heiko Stübner
Am Dienstag, 30. Januar 2018, 21:28:35 CET schrieb Thierry Escande: > From: zain wang > > The bridge does not need to be powered in analogix_dp_bind(), so > remove the calls to pm_runtime_get()/phy_power_on()/analogix_dp_init_dp() > as well as their power-off counterparts. >

Re: [PATCH 0/4] Move DP phy switch to PHY driver

2018-02-16 Thread Heiko Stübner
Hi Kishon, Am Freitag, 16. Februar 2018, 12:04:42 CET schrieb Kishon Vijay Abraham I: > On Friday 10 February 2017 01:14 PM, Chris Zhong wrote: > > There are 2 Type-c PHYs in RK3399, but only one DP controller. Hence > > only one PHY can connect to DP controller at one time, the other should > >

Re: [PATCH 0/4] Move DP phy switch to PHY driver

2017-12-04 Thread Heiko Stübner
Hi, Am Montag, 4. Dezember 2017, 08:08:31 CET schrieb Doug Anderson: > On Sun, Dec 3, 2017 at 11:46 PM, Heiko Stübner <he...@sntech.de> wrote: > > Am Montag, 4. Dezember 2017, 10:47:08 CET schrieb Chris Zhong: > >> On 2017年12月02日 05:58, Heiko Stuebner wrote: > >&g

Re: [PATCH 0/4] Move DP phy switch to PHY driver

2017-12-03 Thread Heiko Stübner
Hi Chris, Am Montag, 4. Dezember 2017, 10:47:08 CET schrieb Chris Zhong: > On 2017年12月02日 05:58, Heiko Stuebner wrote: > > Am Freitag, 1. Dezember 2017, 13:42:46 CET schrieb Doug Anderson: > >> Hi, > >> > >> On Wed, Nov 29, 2017 at 6:27 PM, Chris Zhong wrote: > >>> Hi Doug

Re: [PATCH] MAINTAINERS: change maintainer for Rockchip drm drivers

2017-11-29 Thread Heiko Stübner
Am Mittwoch, 29. November 2017, 10:54:18 CET schrieb Daniel Vetter: > On Tue, Nov 28, 2017 at 03:42:36PM -0800, Doug Anderson wrote: > > Hi, > > > > On Sun, Nov 26, 2017 at 6:22 PM, Sandy Huang wrote: > > > Hi Daniel, > > > > > > I register the account and get the

Re: [PATCH 5/7] arm64: dts: rockchip: rk3399: Correct MIPI DPHY PLL clock

2017-09-20 Thread Heiko Stübner
Am Montag, 18. September 2017, 17:05:37 CEST schrieb Nickey Yang: > clk_24m --> Gate11[14] --> clk_mipidphy_ref --> Gate21[0] --> clk_dphy_pll > > Signed-off-by: Nickey Yang applied as fix for 4.14 after polishing the commit message a bit Thanks Heiko

Re: [PATCH 5/7] arm64: dts: rockchip: rk3399: Correct MIPI DPHY PLL clock

2017-09-18 Thread Heiko Stübner
Hi Nickey, Am Montag, 18. September 2017, 17:05:37 CEST schrieb Nickey Yang: > clk_24m --> Gate11[14] --> clk_mipidphy_ref --> Gate21[0] --> clk_dphy_pll please try to be a bit more verbose in your commit messages :-) . It looks to me, like this patch does not depend on the other ones and I can

Re: [PATCH v8 3/3] drm/rockchip: Add support for Rockchip Soc LVDS

2017-09-07 Thread Heiko Stübner
Hi Mark, Am Donnerstag, 7. September 2017, 18:16:29 CEST schrieb Mark yao: > Looks good for me, so: > Reviewed-by: Mark Yao > > I'd like to apply these lvds patches tomorrow if there is no more doubts. Rob had some minor comments on v7 of the dt-binding, so you may

Re: rk3288: Enable HDMI hang boot and no Linux log

2017-09-04 Thread Heiko Stübner
Hi, Am Montag, 4. September 2017, 18:14:56 CEST schrieb Jagan Teki: > Is linux-next support HDMI on rk3288? I'm trying to enable hdmi (with > ddc-i2c-bus) statically along with Linux boot logo. Observed an kernel > boot hang, didn't find whats wrong because DWC MHL PHY as detected > from the log.

Re: [PATCH v6 4/7] drm/rockchip: vop: group vop registers

2017-07-27 Thread Heiko Stübner
Am Donnerstag, 27. Juli 2017, 11:51:06 CEST schrieb Heiko Stübner: > Hi Mark, > > Am Mittwoch, 26. Juli 2017, 14:19:25 CEST schrieb Mark Yao: > > Grouping the vop registers facilitates make register > > definition clearer, and also is useful for different vop > > re

Re: [PATCH v6 4/7] drm/rockchip: vop: group vop registers

2017-07-27 Thread Heiko Stübner
Hi Mark, Am Mittwoch, 26. Juli 2017, 14:19:25 CEST schrieb Mark Yao: > Grouping the vop registers facilitates make register > definition clearer, and also is useful for different vop > reuse the same group register. > > Signed-off-by: Mark Yao > --- >

Re: [PATCH 5/5] dt-bindings: display: fill Documents for series of vop

2017-07-11 Thread Heiko Stübner
Hi Mark, Am Dienstag, 11. Juli 2017, 20:42:38 CEST schrieb Mark Yao: > Signed-off-by: Mark Yao > --- > Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt | 4 > 1 file changed, 4 insertions(+) > > diff --git >

Re: [PATCH] drm: bridge: synopsys/dw-hdmi: Provide default configuration function for HDMI 2.0 PHY

2017-06-20 Thread Heiko Stübner
Hi Jose, Am Freitag, 9. Juni 2017, 13:53:12 CEST schrieb Jose Abreu: > On 09-06-2017 12:04, Jose Abreu wrote: > > Currently HDMI 2.0 PHYs do not have a default configuration function. > > > > As these PHYs have the same register layout as the 3D PHYs we can > > safely use the default

Re: [PATCH 1/3] dt-bindings: add the grf clock for dw-mipi-dsi

2017-03-15 Thread Heiko Stübner
Am Mittwoch, 15. März 2017, 17:55:23 CET schrieb Chris Zhong: > Hi Heiko > > On 03/15/2017 05:03 PM, Heiko Stübner wrote: > > Am Mittwoch, 15. März 2017, 16:42:30 CET schrieb Chris Zhong: > >> For RK3399, the grf clock should be controlled by dw-mipi-dsi driver,

Re: [PATCH 1/3] dt-bindings: add the grf clock for dw-mipi-dsi

2017-03-15 Thread Heiko Stübner
Am Mittwoch, 15. März 2017, 16:42:30 CET schrieb Chris Zhong: > For RK3399, the grf clock should be controlled by dw-mipi-dsi driver, > add the description for this clock. > > Signed-off-by: Chris Zhong > --- > >

Re: [PATCH 3/4] phy: rockchip-typec: support DP phy switch

2017-03-09 Thread Heiko Stübner
Hi Brian, Am Mittwoch, 8. März 2017, 19:10:50 CET schrieb Brian Norris: > On Thu, Mar 09, 2017 at 02:02:54AM +0100, Heiko Stuebner wrote: > > Am Mittwoch, 8. März 2017, 16:39:23 CET schrieb Brian Norris: > > > On Fri, Feb 10, 2017 at 03:44:13PM +0800, Chris Zhong wrote: > > > > There are 2 Type-c

Re: [PATCH 3/4] phy: rockchip-typec: support DP phy switch

2017-03-08 Thread Heiko Stübner
Am Mittwoch, 8. März 2017, 16:39:23 CET schrieb Brian Norris: > On Fri, Feb 10, 2017 at 03:44:13PM +0800, Chris Zhong wrote: > > There are 2 Type-c PHYs in RK3399, but only one DP controller. Hence > > only one PHY can connect to DP controller at one time, the other should > > be disconnected. The

Re: [PATCH v2 0/7] drm/rockchip: switch to drm_mm for support arm64 iommu

2017-02-08 Thread Heiko Stübner
Am Dienstag, 7. Februar 2017, 16:35:35 CET schrieb Mark Yao: > Some iommu patches on the series[0] "iommu/rockchip: Fix bugs and > enable on ARM64" already landed, So drm/rockchip related patches [1] and [2] > ready to landed, this series just rebase them to lastest drm-next. > > And fix some

[PATCH v5 8/8] iommu/rockchip: Enable Rockchip IOMMU on ARM64

2016-11-29 Thread Heiko Stübner
Am Montag, 28. November 2016, 16:42:27 schrieb Brian Norris: > Hi, > > On Fri, Jun 24, 2016 at 10:13:33AM +0800, Shunqian Zheng wrote: > > From: Simon Xue > > > > This patch makes it possible to compile the rockchip-iommu driver on > > ARM64, so that it can be used with 64-bit SoCs equipped

[PATCH 4/5] PM / devfreq: rockchip: add devfreq driver for rk3399 dmc

2016-09-02 Thread Heiko Stübner
Am Freitag, 2. September 2016, 06:31:24 schrieb Lin Huang: > base on dfi result, we do ddr frequency scaling, register > dmc driver to devfreq framework, and use simple-ondemand > policy. > > Signed-off-by: Lin Huang > Signed-off-by: MyngJoo Ham > Reviewed-by: Chanwoo Choi > --- [...] > diff

[PATCH v7 3/8] clk: rockchip: rk3399: add ddrc clock support

2016-09-01 Thread Heiko Stübner
Am Montag, 22. August 2016, 11:36:19 schrieb Lin Huang: > add ddrc clock setting, so we can do ddr frequency > scaling on rk3399 platform in future. > > Signed-off-by: Lin Huang applied to my clk-branch for 4.9 Thanks Heiko

[PATCH v7 7/8] PM / devfreq: rockchip: add devfreq driver for rk3399 dmc

2016-09-01 Thread Heiko Stübner
Hi, Am Montag, 22. August 2016, 11:36:23 schrieb Lin Huang: > base on dfi result, we do ddr frequency scaling, register > dmc driver to devfreq framework, and use simple-ondemand > policy. > > Signed-off-by: Lin Huang > Reviewed-by: Chanwoo Choi > --- [...] > diff --git

[PATCH v7 1/8] clk: rockchip: add new clock-type for the ddrclk

2016-09-01 Thread Heiko Stübner
Am Montag, 22. August 2016, 11:36:17 schrieb Lin Huang: > On new rockchip platform(rk3399 etc), there have dcf controller to > do ddr frequency scaling, and this controller will implement in > arm-trust-firmware. We add a special clock-type to handle that. > > Signed-off-by: Lin Huang Applied

[PATCH v7 2/8] clk: rockchip: rk3399: add SCLK_DDRCLK ID for ddrc

2016-08-31 Thread Heiko Stübner
Am Montag, 22. August 2016, 11:36:18 schrieb Lin Huang: > Signed-off-by: Lin Huang applied to my shared clock-id branch for 4.9

[PATCH v4 1/7] clk: rockchip: add clock flag parameter when register pll

2016-08-05 Thread Heiko Stübner
Hi Lin, Am Freitag, 5. August 2016, 16:50:49 schrieb hl: > On 2016年08月05日 06:37, Heiko Stuebner wrote: > > Am Freitag, 29. Juli 2016, 15:56:55 schrieb Lin Huang: > >> From: Heiko Stübner > >> > >> add clock flag parameter so we can pass specific clock flag > >> (like CLK_GET_RATE_NOCACHE

[PATCH v4 2/7] clk: rockchip: add new clock-type for the ddrclk

2016-08-04 Thread Heiko Stübner
Hi Lin, Am Freitag, 29. Juli 2016, 15:56:56 schrieb Lin Huang: > On new rockchip platform(rk3399 etc), there have dcf controller to > do ddr frequency scaling, and this controller will implement in > arm-trust-firmware. We add a special clock-type to handle that. > > Signed-off-by: Lin Huang

[PATCH 1/3] drm/rockchip: inno_hdmi: add audio support

2016-08-03 Thread Heiko Stübner
Am Dienstag, 2. August 2016, 10:16:04 schrieb Yakir Yang: > Hi Mark & Heiko, > > Ping.. devicetree side looks good, so we're waiting on Mark to pick up patch 1. Heiko > On 06/15/2016 09:28 PM, Yakir Yang wrote: > > Using the common hdmi-codec driver to support hdmi audio function. > > >

[PATCH v3 2/7] clk: rockchip: add new clock-type for the ddrclk

2016-07-24 Thread Heiko Stübner
Am Freitag, 22. Juli 2016, 17:07:15 schrieb Lin Huang: > @@ -488,6 +496,25 @@ struct rockchip_clk_branch { > .child = ch, \ > } > > +#define COMPOSITE_DDRC(_id, cname, pnames, f, mo, ms, mw, mf,\ > + ds, dw, df)

[PATCH v3 1/7] firmware: rockchip: sip: Add rockchip SIP runtime service

2016-07-22 Thread Heiko Stübner
Hi again, one bigger thing I noticed only now. Am Freitag, 22. Juli 2016, 17:07:14 schrieben Sie: > diff --git a/drivers/firmware/rockchip_sip.c > b/drivers/firmware/rockchip_sip.c new file mode 100644 > index 000..7756af9 > --- /dev/null > +++ b/drivers/firmware/rockchip_sip.c > @@ -0,0

[PATCH v3 3/7] clk: rockchip: rk3399: add SCLK_DDRCLK ID for ddrc

2016-07-22 Thread Heiko Stübner
Am Freitag, 22. Juli 2016, 17:07:16 schrieb Lin Huang: > Signed-off-by: Lin Huang > --- > Changes in v3: > -None > > Changes in v2: > - None > Changes in v1: > - None > > include/dt-bindings/clock/rk3399-cru.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git

[PATCH v3 1/7] firmware: rockchip: sip: Add rockchip SIP runtime service

2016-07-22 Thread Heiko Stübner
Hi, Am Freitag, 22. Juli 2016, 17:07:14 schrieb Lin Huang: > From: Shengfei xu > > This patch adds support for the SiP interface, we can pass dram > paramtert to bl31, and control ddr frequency scaling in bl31. > > Signed-off-by: Shengfei xu > Signed-off-by: Lin Huang [...] > +++

[PATCH v1 5/6] drm/rockchip: dw_hdmi: introduce the VPLL clock setting

2016-07-12 Thread Heiko Stübner
Hi Yakir, Am Montag, 11. Juli 2016, 19:05:49 schrieb Yakir Yang: > For RK3399 HDMI, there is an external clock need for HDMI PHY, > and it should keep the same clock rate with VOP DCLK. > > VPLL have supported the clock for HDMI PHY, but there is no > clock divider bewteen VPLL and HDMI PHY. So

[PATCH v4 0/8] iommu/rockchip: Fix bugs and enable on ARM64

2016-06-21 Thread Heiko Stübner
Am Dienstag, 21. Juni 2016, 14:54:35 schrieb Joerg Roedel: > Hi Tomasz, > > On Tue, Jun 21, 2016 at 09:42:16PM +0900, Tomasz Figa wrote: > > In simple words, DRM patches depend on IOMMU patches. > > > > More precisely: The IOMMU patches alone are supposed to not break > > anything. Same goes for

[RFC PATCH v1 3/6] clk: rockchip: rk3399: add ddrc clock support

2016-06-03 Thread Heiko Stübner
Am Freitag, 3. Juni 2016, 17:55:16 schrieb Lin Huang: > add ddrc clock setting, so we can do ddr frequency > scaling on rk3399 platform in future. > > Signed-off-by: Lin Huang > --- > Changes in v1: > - remove ddrc source CLK_IGNORE_UNUSED flag, Suggestion by Doug > - move clk_ddrc and

[RFC PATCH v1 1/6] rockchip: rockchip: add new clock-type for the ddrclk

2016-06-03 Thread Heiko Stübner
Am Freitag, 3. Juni 2016, 17:55:14 schrieb Lin Huang: > On new rockchip platform(rk3399 etc), there have dcf controller to > do ddr frequency scaling, and this controller will implement in > arm-trust-firmware. We add a special clock-type to handle that. > > Signed-off-by: Lin Huang > --- >

[RFC PATCH v1 2/6] clk: rockchip: rk3399: add SCLK_DDRCLK ID for ddrc

2016-06-03 Thread Heiko Stübner
Hi Shawn, Am Freitag, 3. Juni 2016, 20:34:52 schrieb Shawn Lin: > How about merge it into your patch#3. see comments from Doug and me on previous version. clock-ids should always be separate patches, as we will need them in both clock and devicetree branches, so they must be in a separate

[RFC PATCH 2/4] clk: rockchip: rk3399: add ddrc clock support

2016-06-01 Thread Heiko Stübner
Am Mittwoch, 1. Juni 2016, 08:24:48 schrieb Doug Anderson: > Lin Huang, > > On Wed, Jun 1, 2016 at 2:35 AM, Lin Huang wrote: > > add ddrc clock setting, so we can do ddr frequency > > scaling on rk3399 platform in future. > > > > Signed-off-by: Lin Huang > > --- > > > >

[PATCH 2/2] dt-bindings: add document for rk3399-vop

2016-04-19 Thread Heiko Stübner
patch subject above: dt-bindings: add documentation for Rockchip rk3399 display controllers not everybody skimming over patches directly knows what a vop is ;-) I still believe even such a trivial patch should also get some form of description, something like: - Document compatible

[PATCH] drm/rockchip: support non-iommu buffer path

2016-04-19 Thread Heiko Stübner
Am Dienstag, 19. April 2016, 10:19:32 schrieb Mark Yao: > Some rockchip vop not support iommu, need use non-iommu > buffer for it. And if we get iommu issues, we can compare > the issues with non-iommu path, the would help the debug. > > Signed-off-by: Mark Yao > --- >

  1   2   >