Re: [PATCH] drm/bridge: dw-hdmi: fix SCDC configuration for ddc-i2c-bus

2019-04-23 Thread Heiko Stuebner
DC is not supported when there is no DDC bus. > > Fixes: 264fce6cc2c1 ("drm/bridge: dw-hdmi: Add SCDC and TMDS Scrambling > support") > Signed-off-by: Jonas Karlman I've looked that up and yeah, hdmi->ddc seems the right thing to use as it points either to the external i

Re: [PATCH v2] drm/rockchip: shutdown drm subsystem on shutdown

2019-04-18 Thread Heiko Stuebner
Am Dienstag, 2. April 2019, 13:37:53 CEST schrieb Heiko Stuebner: > From: Vicente Bergas > > As explained by Robin Murphy: > > the IOMMU shutdown disables paging, so if the VOP is still > > scanning out then that will result in whatever IOVAs it was using now going > >

Re: [PATCH] drm: rockchip: add shutdown function to poweroff VOP and HDMI TX

2019-04-02 Thread Heiko Stuebner
Hi Johan, Am Montag, 11. März 2019, 19:14:27 CEST schrieb Johan Jonker: > Hi, > > Just found out that this was patched and reverted before.(lol) > The revert was 3 months ago for RK3399 boards, but other processors > like RK3066 are left without shutdown now. > > What's the status for a fix? >

[PATCH v2] drm/rockchip: shutdown drm subsystem on shutdown

2019-04-02 Thread Heiko Stuebner
ted commit message to explain the history] Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c index 8d7a634c12c2..cb93

Re: [PATCH v5 5/5] drm: rockchip: add fixed screen size DVI-D support for rk3066 hdmi

2019-03-31 Thread Heiko Stuebner
Hi Johan, Am Donnerstag, 21. März 2019, 01:14:40 CEST schrieb Johan Jonker: > Add fixed screen size DVI-D support > for rk3066 hdmi with an extra patch. > > Signed-off-by: Johan Jonker > +static const struct drm_display_mode edid_cea_modes[] = { > + /* 4 - 1280x720@60Hz 16:9 */ > + {

Re: [PATCH v6 3/4] ARM: dts: rockchip: rk3066a-mk808: enable vop0 and hdmi nodes

2019-03-31 Thread Heiko Stuebner
Am Samstag, 30. März 2019, 10:56:38 CEST schrieb Johan Jonker: > This patch enables the vop0 and hdmi nodes > for a MK808 with rk3066 processor. > > Signed-off-by: Johan Jonker applied for 5.2 Thanks Heiko ___ dri-devel mailing list

Re: [PATCH v6 2/4] ARM: dts: rockchip: add rk3066 hdmi nodes

2019-03-31 Thread Heiko Stuebner
Am Samstag, 30. März 2019, 10:56:37 CEST schrieb Johan Jonker: > From: Zheng Yang > > This patch adds the hdmi nodes to rk3066. > > Signed-off-by: Zheng Yang > Signed-off-by: Johan Jonker applied for 5.2 after correcting the alphabetical sorting of some properties. Thanks Heiko

Re: [PATCH v6 1/4] drm: rockchip: introduce rk3066 hdmi

2019-03-31 Thread Heiko Stuebner
Hi Johan, Am Samstag, 30. März 2019, 10:56:36 CEST schrieb Johan Jonker: > From: Zheng Yang > > The RK3066 HDMI TX serves as interface between a LCD Controller and > a HDMI bus. A HDMI TX consists of one HDMI transmitter controller and > one HDMI transmitter PHY. The interface has three (3)

Re: [PATCH v6 4/4] dt-bindings: display: rockchip: add document for rk3066 hdmi

2019-03-31 Thread Heiko Stuebner
Am Samstag, 30. März 2019, 10:56:39 CEST schrieb Johan Jonker: > This patch adds a binding that describes the HDMI controller for > rk3066. > > Signed-off-by: Johan Jonker > Reviewed-by: Rob Herring applied to drm-misc-next, so should land in 5.2 Thanks Heiko

Re: [PATCH] drm: bridge: dw-hdmi: Fix overflow workaround for Rockchip SoCs

2019-03-30 Thread Heiko Stuebner
Am Mittwoch, 20. Februar 2019, 08:52:31 CET schrieb Jonas Karlman: > The Rockchip RK3288 SoC (v2.00a) and RK3328/RK3399 SoCs (v2.11a) have > also been identified as needing this workaround with a single iteration. > > Fixes: be41fc55f1aa ("drm: bridge: dw-hdmi: Handle overflow workaround based >

Re: [PATCH v8] drm/lima: driver for ARM Mali4xx GPUs

2019-03-12 Thread Heiko Stuebner
> > - fix job finish fence leak since kernel 5.0 > > > - use drm syncobj to replace native fence > > > - move buffer object GPU va map into kernel > > > - reserve syscall argument space for future info > > > - remove kernel gem modifier > > >

Re: [PATCH] dt-bindings: display: add binding for Innolux ee101ia-01d panel

2019-02-03 Thread Heiko Stuebner
Am Dienstag, 29. Januar 2019, 17:45:50 CET schrieb Daniel Vetter: > On Tue, Jan 29, 2019 at 02:37:23PM +0100, Heiko Stübner wrote: > > Hi Thierry, > > > > Am Dienstag, 13. November 2018, 13:42:05 CET schrieb Heiko Stuebner: > > > From: Heiko Stuebner > > >

Re: [PATCHv2 1/9] mm: Introduce new vm_insert_range and vm_insert_range_buggy API

2019-01-31 Thread Heiko Stuebner
Am Donnerstag, 31. Januar 2019, 13:31:52 CET schrieb Souptick Joarder: > On Thu, Jan 31, 2019 at 5:37 PM Heiko Stuebner wrote: > > > > Am Donnerstag, 31. Januar 2019, 04:08:12 CET schrieb Souptick Joarder: > > > Previouly drivers have their own way of mapping range of &

Re: [PATCHv2 1/9] mm: Introduce new vm_insert_range and vm_insert_range_buggy API

2019-01-31 Thread Heiko Stuebner
n v1 and v2. Nevertheless I managed to test v1 on Rockchip hardware and display is still working, including talking to Lima via prime. So if there aren't any big changes for v2, on Rockchip Tested-by: Heiko Stuebner Heiko ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCHv2 4/9] drm/rockchip/rockchip_drm_gem.c: Convert to use vm_insert_range

2019-01-31 Thread Heiko Stuebner
hip hardware and display is still working, including talking to Lima via prime. So if there aren't any big changes for v2, on Rockchip Tested-by: Heiko Stuebner Heiko ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop

Re: [PATCH] drm/rockchip: fix for mailbox read validation.

2019-01-28 Thread Heiko Stuebner
Am Montag, 19. November 2018, 16:14:14 CET schrieb Damian Kos: > This is basically the same fix as in > commit fa68d4f8476b ("drm/rockchip: fix for mailbox read size") > but for cdn_dp_mailbox_validate_receive function. > > See patchwork.kernel.org/patch/10671981/ for details. > > Signed-off-by:

Re: [PATCH] drm/rockchip: check yuv2yuv existence before assigning window data

2019-01-27 Thread Heiko Stuebner
Am Samstag, 26. Januar 2019, 01:24:37 CET schrieb Heiko Stuebner: > Before assigning window data, we should check if the yuv2yuv vop-data > is set at all, because it looks like it can otherwise reference something > wrong, as I saw on my rk3188 today which ended up in a null pointer >

Re: [PATCH 21/26] drm/rockchip: Use drm_fb_helper_fill_info

2019-01-27 Thread Heiko Stuebner
infradead.org After looking up the rest of the series and also realizing that fbi->par seems to be set when a client attaches to the fb, this looks good to me, so Reviewed-by: Heiko Stuebner > --- > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 4 +--- > 1 file changed, 1 insertion(+

Re: linux-next: Fixes tag needs some work in the drm-misc-fixes tree

2019-01-27 Thread Heiko Stuebner
Am Sonntag, 27. Januar 2019, 04:41:26 CET schrieb Stephen Rothwell: > Hi all, > > In commit > > 053ff09f1a8f ("drm/rockchip: rgb: update SPDX license identifier") > > Fixes tag > > Fixes: 1f0f01515172 ("Add support for Rockchip Soc RGB output interface") looks like I accidentially lost

[PATCH] drm/rockchip: check yuv2yuv existence before assigning window data

2019-01-25 Thread Heiko Stuebner
: 1c21aa8f2b68 ("drm/rockchip: Fix YUV buffers color rendering") Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip

Re: [PATCH] drm/rockchip: rgb: update SPDX license identifier

2019-01-25 Thread Heiko Stuebner
Am Mittwoch, 23. Januar 2019, 11:14:39 CET schrieb Sandy Huang: > update SPDX License Identifier from GPL-2.0+ to GPL-2.0 > and drop some GPL text. > > Signed-off-by: Sandy Huang I've added Fixes, Cc-stable and Reported-by (for Thomas) tags and applied it to drm-misc-fixes Thanks Heiko

Re: [v8, 2/3] drm/rockchip: Add support for Rockchip Soc RGB output interface

2019-01-18 Thread Heiko Stuebner
Hi Thomas, Am Freitag, 18. Januar 2019, 01:40:03 CET schrieb Thomas Gleixner: > On Thu, 30 Aug 2018, Heiko Stuebner wrote: > > +++ b/drivers/gpu/drm/rockchip/rockchip_rgb.c > > @@ -0,0 +1,173 @@ > > +//SPDX-License-Identifier: GPL-2.0+ > > +/* > > + * Copyrigh

Re: [PATCH 3/4] drm/rockchip: add missing of_node_put

2019-01-14 Thread Heiko Stuebner
Am Montag, 14. Januar 2019, 11:05:56 CET schrieb Daniel Vetter: > On Sun, Jan 13, 2019 at 07:48:49PM +0100, Heiko Stuebner wrote: > > Am Sonntag, 13. Januar 2019, 09:47:43 CET schrieb Julia Lawall: > > > The device node iterators perform an of_node_get on each iteration, s

Re: [PATCH 3/4] drm/rockchip: add missing of_node_put

2019-01-13 Thread Heiko Stuebner
Am Sonntag, 13. Januar 2019, 09:47:43 CET schrieb Julia Lawall: > The device node iterators perform an of_node_get on each iteration, so a > jump out of the loop requires an of_node_put. > > The semantic patch that fixes this problem is as follows > (http://coccinelle.lip6.fr): > > // > @@ >

Re: [PATCH v2 5/7] ARM: dts: rockchip: add rk3066 vop display nodes

2019-01-12 Thread Heiko Stuebner
Am Samstag, 29. Dezember 2018, 14:33:16 CET schrieb Johan Jonker: > From: Mark Yao > > This patch adds the core display subsystem and vop nodes to rk3066. > > Signed-off-by: Mark Yao > Signed-off-by: Johan Jonker applied for 5.1 Thanks Heiko ___

Re: [PATCH v2 3/7] drm: rockchip: vop: add rk3066 vop definitions

2019-01-12 Thread Heiko Stuebner
Am Freitag, 11. Januar 2019, 15:54:24 CET schrieb Rob Herring: > On Sun, Dec 30, 2018 at 06:22:00PM +0100, Heiko Stuebner wrote: > > Hi Johan, > > > > Am Samstag, 29. Dezember 2018, 14:33:14 CET schrieb Johan Jonker: > > > From: Mark Yao > > > > >

Re: [PATCH 0/3] Support reflect-x/y on RK3328, RK3368, and RK3399

2019-01-10 Thread Heiko Stuebner
Am Mittwoch, 9. Januar 2019, 19:56:36 CET schrieb Ezequiel Garcia: > Here's a small series supporting plane reflection (aka. mirroring) > properties on RK3328, RK3368, and RK3399 SoCs. > > Note that RK3288 specification doesn't seem to document registers > for plane mirroring, but instead it only

Re: [PATCH v4] drm/rockchip: update cursors asynchronously through atomic.

2019-01-10 Thread Heiko Stuebner
Am Mittwoch, 5. Dezember 2018, 13:33:10 CET schrieb Helen Koike: > From: Enric Balletbo i Serra > > Add support to async updates of cursors by using the new atomic > interface for that. > > Signed-off-by: Enric Balletbo i Serra > [updated for upstream] > Signed-off-by: Helen Koike applied to

Re: [PATCH v3] drm/rockchip: Fix YUV buffers color rendering

2019-01-10 Thread Heiko Stuebner
Am Dienstag, 8. Januar 2019, 22:46:59 CET schrieb Ezequiel Garcia: > From: Daniele Castagna > > Currently, YUV hardware overlays are converted to RGB using > a color space conversion different than BT.601. > > The result is that colors of e.g. NV12 buffers don't match > colors of YUV hardware

Re: [PATCH v2] drm/rockchip: Fix YUV buffers color rendering

2019-01-07 Thread Heiko Stuebner
Hi, sorry, only now got to test this on actual hardware, Am Freitag, 14. Dezember 2018, 17:29:20 CET schrieb Ezequiel Garcia: > From: Daniele Castagna > > Currently, YUV hardware overlays are converted to RGB using > a color space conversion different than BT.601. > > The result is that

Re: [PATCH v2 3/7] drm: rockchip: vop: add rk3066 vop definitions

2018-12-30 Thread Heiko Stuebner
Hi Johan, Am Samstag, 29. Dezember 2018, 14:33:14 CET schrieb Johan Jonker: > From: Mark Yao > > This patch adds the rk3066 VOP definitions. > > The VOP or LCD Controller serves as interface between > framebuffer memory and a display device (LCD panel or TV set). > > This SOC has two

Re: [PATCH v2 2/7] clk: rockchip: rk3188: add CLK_SET_RATE_PARENT for lcdc dclk

2018-12-30 Thread Heiko Stuebner
Am Samstag, 29. Dezember 2018, 14:33:13 CET schrieb Johan Jonker: > From: Finley Xiao > > Add CLK_SET_RATE_PARENT for lcdc dclk. > > Signed-off-by: Finley Xiao > Signed-off-by: Johan Jonker applied for 4.22 Thanks Heiko ___ dri-devel mailing

Re: [PATCH v2 1/7] ARM: dts: rockchip: rk3066: add HCLK_HDMI to pmu node

2018-12-30 Thread Heiko Stuebner
Am Samstag, 29. Dezember 2018, 14:33:12 CET schrieb Johan Jonker: > A MK808 TV stick with rk3066 processor > boots normal with logo and console, > but after booting the monitor remains black. > This patch fixes a vblank wait time out > by adding HCLK_HDMI to the pmu node. > The HCLK_HDMI clock is

Re: [PATCH] dts: rockchip: rk3066: add qos_hdmi and HCLK_HDMI to pmu node

2018-12-17 Thread Heiko Stuebner
Hi Johan, Am Montag, 17. Dezember 2018, 15:00:55 CET schrieb Johan Jonker: > Thanks Tomasz for adding all the mailing lists. > I prefer to ask first if a qos_hdmi exists before sending it in for > public review. > > All the clocks in the pmu node seem to have a "quality-of-service" (QoS) >

[PATCH 14/15] arm64: dts: rockchip: enable display on rk3368-r88

2018-12-17 Thread Heiko Stuebner
Enable vop, hdmi and hdmi-i2c on the R88 board. Signed-off-by: Heiko Stuebner --- arch/arm64/boot/dts/rockchip/rk3368-r88.dts | 17 + 1 file changed, 17 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3368-r88.dts b/arch/arm64/boot/dts/rockchip/rk3368-r88.dts index

[PATCH 10/15] arm64: dts: rockchip: add dw-hdmi controller on rk3368

2018-12-17 Thread Heiko Stuebner
Add the core node for the dw-hdmi controller found on rk3368 socs. Signed-off-by: Heiko Stuebner --- arch/arm64/boot/dts/rockchip/rk3368.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi b/arch/arm64/boot/dts/rockchip/rk3368.dtsi

[PATCH 12/15] arm64: dts: rockchip: add dw-mipi-dsi controller on rk3368

2018-12-17 Thread Heiko Stuebner
Add the core node for the mipi-dsi controller found on rk3368 socs. Signed-off-by: Heiko Stuebner --- arch/arm64/boot/dts/rockchip/rk3368.dtsi | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi b/arch/arm64/boot/dts/rockchip/rk3368.dtsi

[PATCH 11/15] arm64: dts: rockchip: add analogix-dp controller on rk3368

2018-12-17 Thread Heiko Stuebner
Add the core node for the Analogix displayport controller found on rk3368 socs. Signed-off-by: Heiko Stuebner --- arch/arm64/boot/dts/rockchip/rk3368.dtsi | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi b/arch/arm64/boot/dts

[PATCH 15/15] arm64: defconfig: enable hym8563 rtc driver

2018-12-17 Thread Heiko Stuebner
The hym8563 is used on a number of Rockchip boards on 64bit as well and maybe even more importantly is the source for 32kHz clock on those as well, completing the clock tree of the soc. So enable it as built-in. Signed-off-by: Heiko Stuebner --- arch/arm64/configs/defconfig | 1 + 1 file

[PATCH 13/15] arm64: dts: rockchip: add core display support for rk3368

2018-12-17 Thread Heiko Stuebner
Add the display subsystem and vop and hook up the individual encoder ports. Signed-off-by: Heiko Stuebner --- arch/arm64/boot/dts/rockchip/rk3368.dtsi | 73 1 file changed, 73 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi b/arch/arm64/boot/dts

[PATCH 03/15] clk: rockchip: use clock ids for dphy rx and tx on rk3368

2018-12-17 Thread Heiko Stuebner
Export the clocks using the newly added clock ids. Signed-off-by: Heiko Stuebner --- drivers/clk/rockchip/clk-rk3368.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/rockchip/clk-rk3368.c b/drivers/clk/rockchip/clk-rk3368.c index 7c4d242f19c1..58debf7daf85

[PATCH 00/15] drm/rockchip: add display support for rk3368

2018-12-17 Thread Heiko Stuebner
support for powerdomains and the vop is in the kernel for quite a while already but hasn't been used so far. Heiko Stuebner (15): clk: rockchip: add clock ids for dphy rx and tx channels on rk3368 clk: rockchip: add clock id 24m dsi clock on rk3368 clk: rockchip: use clock ids for dphy rx and tx

[PATCH 04/15] clk: rockchip: use clock id for 24m dsi on rk3368

2018-12-17 Thread Heiko Stuebner
Export the clock using the newly added clock id. Signed-off-by: Heiko Stuebner --- drivers/clk/rockchip/clk-rk3368.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/rockchip/clk-rk3368.c b/drivers/clk/rockchip/clk-rk3368.c index 58debf7daf85..56ca10fe3e96 100644

[PATCH 07/15] drm/rockchip: dw-mipi-dsi: add support for rk3368-variant

2018-12-17 Thread Heiko Stuebner
Add the compatible and grf values and allow the driver to also not select a specific crtc input on systems with only one vop. Signed-off-by: Heiko Stuebner --- .../display/rockchip/dw_mipi_dsi_rockchip.txt | 1 + .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 25 +-- 2 files

[PATCH 09/15] arm64: dts: rockchip: add power-domain nodes on rk3368

2018-12-17 Thread Heiko Stuebner
Add the power-controller main node, the individual power domains below it and their used quality-of-service syscons on rk3368 and hook the power-domains to their user-devicenodes. Signed-off-by: Heiko Stuebner --- arch/arm64/boot/dts/rockchip/rk3368.dtsi | 177 +++ 1 file

[PATCH 05/15] drm/rockchip: dw_hdmi: add support for rk3368

2018-12-17 Thread Heiko Stuebner
The rk3368 only has one vop block and thus the dw_hdmi does not need to do the source selection. Signed-off-by: Heiko Stuebner --- .../display/rockchip/dw_hdmi-rockchip.txt | 1 + drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 15 +++ 2 files changed, 16 insertions

[PATCH 01/15] clk: rockchip: add clock ids for dphy rx and tx channels on rk3368

2018-12-17 Thread Heiko Stuebner
Add the clock ids so that they can be exported from the clock driver and referenced in the rk3368 devicetree. Signed-off-by: Heiko Stuebner --- include/dt-bindings/clock/rk3368-cru.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/dt-bindings/clock/rk3368-cru.h b/include/dt

[PATCH 06/15] drm/rockchip: analogix_dp: add support for the rk3368 variant

2018-12-17 Thread Heiko Stuebner
setting needed". The dp controller behaves similar to the one found on rk3288, so we don't add a new chip_type to not overly pollute the bridge driver. Signed-off-by: Heiko Stuebner --- .../display/rockchip/analogix_dp-rockchip.txt | 1 + drivers/gpu/drm/rockchip/analogi

[PATCH 08/15] arm64: dts: rockchip: default values for core clocks on rk3368

2018-12-17 Thread Heiko Stuebner
Add better default values for PLLs and core clocks on rk3368. This includes all plls as well as core aclk,hclk and pclk in both the cpu as well as peripheral domain. Signed-off-by: Heiko Stuebner --- arch/arm64/boot/dts/rockchip/rk3368.dtsi | 10 ++ 1 file changed, 10 insertions

[PATCH 02/15] clk: rockchip: add clock id 24m dsi clock on rk3368

2018-12-17 Thread Heiko Stuebner
Needed as input for the dsi controller. Signed-off-by: Heiko Stuebner --- include/dt-bindings/clock/rk3368-cru.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/dt-bindings/clock/rk3368-cru.h b/include/dt-bindings/clock/rk3368-cru.h index a4ed1f094da8..04fbcd92adc0 100644

Re: [PATCH RFC v2 5/8] drm/bridge: dw-hdmi: support dynamically get input/out color info

2018-12-14 Thread Heiko Stuebner
- get_enc_in_encoding > - get_enc_out_encoding > > Signed-off-by: Zheng Yang > Signed-off-by: Neil Armstrong Please see comments in patch1 for details. on rk3288 and rk3328 Tested-by: Heiko Stuebner ___ dri-devel mailing list dri-

Re: [PATCH RFC v2 4/8] drm/bridge: dw-hdmi: add support for YUV420 output

2018-12-14 Thread Heiko Stuebner
comments in patch1 for details. on rk3288 and rk3328 Tested-by: Heiko Stuebner ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH RFC v2 6/8] drm/bridge: dw-hdmi: allow ycbcr420 modes for >= 0x200a

2018-12-14 Thread Heiko Stuebner
gned to support HDMI2.0 display modes. > > Signed-off-by: Neil Armstrong Please see comments in patch1 for details. on rk3288 and rk3328 Tested-by: Heiko Stuebner ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop

Re: [PATCH RFC v2 1/8] drm/bridge: dw-hdmi: Add SCDC and TMDS Scrambling support

2018-12-14 Thread Heiko Stuebner
xternal innosilicon hdmiphy). I don't know how to test newly added features, but at least the patches don't seem to break existing users, so on rk3288 and rk3328 Tested-by: Heiko Stuebner ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/rockchip: Add implicit fencing support for planes

2018-12-12 Thread Heiko Stuebner
Am Freitag, 30. November 2018, 11:24:49 CET schrieb Heiko Stuebner: > Render like lima will attach a fence to the framebuffer dma_buf, > so the display driver should wait for it to finish before showing > the framebufferto prevent tearing. > > Generally tested on rk3188, rk3288, rk

Re: [PATCH for-4.20] Revert "drm/rockchip: Allow driver to be shutdown on reboot/kexec"

2018-12-11 Thread Heiko Stuebner
subsystem on shutdown > > Fixes: 7f3ef5dedb14 ("drm/rockchip: Allow driver to be shutdown on > reboot/kexec") > Cc: Jeffy Chen > Cc: Robin Murphy > Cc: Vicente Bergas > Cc: Marc Zyngier > Cc: Heiko Stuebner > Cc: sta...@vger.kernel.org > Signed-off-

Re: [PATCH v3] drm/rockchip: support hwc layer

2018-12-10 Thread Heiko Stuebner
Am Mittwoch, 5. Dezember 2018, 14:52:30 CET schrieb Randy Li: > From: ayaka > > The Windows 2/3 or a RGB UI layer is a high performance flexibly > plane. It is too waste to use it as a cursor plane. > > I have verified this patch with weston git version, I am not > sure whether X would meet

Re: [PATCH 2/2] dt-bindings: gpu: add Allwinner H6 Mali Midgard binding

2018-12-03 Thread Heiko Stuebner
Am Dienstag, 27. November 2018, 08:42:49 CET schrieb Icenowy Zheng: > Allwinner H6 SoC uses a Mali T720 GPU, which is one of the GPUs in the > Midgard GPU product line. > > Add binding for the H6 Mali Midgard GPU. > > Signed-off-by: Icenowy Zheng > --- >

[PATCH] drm/rockchip: Add implicit fencing support for planes

2018-11-30 Thread Heiko Stuebner
. Suggested-by: Qiang Yu Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index fb70fb486fbf..db8358e6d230 100644 --- a/drivers/gpu

Re: [PATCH] drm/rockchip: fix for mailbox read size

2018-11-19 Thread Heiko Stuebner
Am Dienstag, 6. November 2018, 16:37:05 CET schrieb Damian Kos: > Some of the functions (like cdn_dp_dpcd_read, cdn_dp_get_edid_block) > allow to read 64KiB, but the cdn_dp_mailbox_read_receive, that is > used by them, can read only up to 255 bytes at once. Normally, it's > not a big issue as DPCD

[PATCH] dt-bindings: display: add binding for Innolux ee101ia-01d panel

2018-11-13 Thread Heiko Stuebner
From: Heiko Stuebner This is a panel handled through the generic lvds-panel binding, so only needs its additional compatible specified. Signed-off-by: Heiko Stuebner --- .../bindings/display/panel/innolux,ee101ia-01d.txt | 7 +++ 1 file changed, 7 insertions(+) create mode 100644

Re: [PATCH 2/2] drm/atomic: Create and use __drm_atomic_helper_crtc_reset() everywhere

2018-11-12 Thread Heiko Stuebner
_state), GFP_KERNEL); > - if (crtc->state) > - crtc->state->crtc = crtc; > + __drm_atomic_helper_crtc_reset(crtc, _state->base); > } > > static struct drm_crtc_state *vop_crtc_duplicate_state(struct drm_crtc *crtc) for the Rockchip-part Acked-by: Heiko Stu

[PATCH] backlight: pwm_bl: fix devicetree parsing with auto-generated brightness tables

2018-11-12 Thread Heiko Stuebner
From: Heiko Stuebner Commit 88ba95bedb79 ("backlight: pwm_bl: Compute brightness of LED linearly to human eye") made the parse-dt function return early when using an auto- generated brightness-table, but didn't take into account that some more settings were handled below the brightnes

[PATCH] backlight: pwm_bl: re-add driver internal enabled tracking

2018-11-09 Thread Heiko Stuebner
unmatched regulator-disable call, as it never got enabled from the pwm-bl before. To prevent these consistency issues, reintroduce the driver-internal tracking of the enabled state. Fixes: e6bcca0890b9 ("backlight: pwm_bl: Switch to using "atomic" PWM API") Signed-off-by: Heik

[PATCH v4 RESEND] drm/panel: add Kingdisplay kd097d04 panel driver

2018-10-30 Thread Heiko Stuebner
tegra and pending rockchip dual-dsi handle (dual-)dsi lanes - spdx header instead of license boilerplate Signed-off-by: Nickey Yang Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile| 1 + .../drm/panel/

Re: [PATCH] drm/rockchip: psr: do not dereference encoder before it is null checked.

2018-10-16 Thread Heiko Stuebner
Am Samstag, 13. Oktober 2018, 12:56:54 CEST schrieb Enric Balletbo i Serra: > 'encoder' is deferenced before it is null sanity checked, hence we > potentially have a null pointer dereference bug. Instead, initialise > drm_drv from encoder->dev->dev_private after we are sure 'encoder' is > not

Re: [PATCH v5 7/7] drm/rockchip: dsi: add dual mipi support

2018-10-01 Thread Heiko Stuebner
Hi Andrzej Am Freitag, 21. September 2018, 08:11:16 CEST schrieb Andrzej Hajda: > On 20.09.2018 13:20, Heiko Stuebner wrote: > > Hi Andrzej, > > > > Am Montag, 27. August 2018, 13:34:07 CEST schrieb Andrzej Hajda: > >> On 21.08.2018 16:05, Heiko Stuebner wrote: &

[PATCH v6 7/7] drm/rockchip: dsi: add dual mipi support

2018-10-01 Thread Heiko Stuebner
to determine the dual-dsi state and get access to both controller instances. v6: handle master+slave component in dsi-attach v5: use driver-internal mechanism to find dual dsi slave v4: add component directly in probe when adding empty dsi slave controller Signed-off-by: Heiko Stuebner

[PATCH v6 1/7] drm/bridge/synopsys: dsi: move mipi_dsi_host_unregister to __dw_mipi_dsi_remove

2018-10-01 Thread Heiko Stuebner
-by: Heiko Stuebner Reviewed-by: Andrzej Hajda Reviewed-by: Philippe Cornu Tested-by: Philippe Cornu --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge

[PATCH v6 4/7] dt-bindings: display: rockchip: update DSI controller

2018-10-01 Thread Heiko Stuebner
Herring Signed-off-by: Heiko Stuebner --- .../display/rockchip/dw_mipi_dsi_rockchip.txt | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt b/Documentation/devicetree/bindings/display

[PATCH v6 5/7] drm/rockchip: dsi: migrate to use dw-mipi-dsi bridge driver

2018-10-01 Thread Heiko Stuebner
changes move to call component_add in the new glue host-attach Signed-off-by: Nickey Yang Signed-off-by: Brian Norris Reviewed-by: Brian Norris Reviewed-by: Sean Paul Reviewed-by: Archit Taneja Reviewed-by: Andrzej Hajda Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/

[PATCH v6 6/7] drm/bridge/synopsys: dsi: add dual-dsi support

2018-10-01 Thread Heiko Stuebner
settings - disable slave before master - lane-sum calculation comments Signed-off-by: Nickey Yang Signed-off-by: Heiko Stuebner Tested-by: Philippe Cornu Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 80 +-- include/drm/bridge/dw_mipi_dsi.h

[PATCH v6 0/8] drm/rockchip: migrate to common dw-mipi-dsi bridge and dual-dsi

2018-10-01 Thread Heiko Stuebner
ead check for a slave in dsi-attach and add the slave-component from there if needed - Go back to reading dsi-slave from dt, to prevent possible driver- probe races Heiko Stuebner (4): drm/bridge/synopsys: dsi: move mipi_dsi_host_unregister to __dw_mipi_dsi_remove drm/bridge/synopsys:

[PATCH v6 2/7] drm/bridge/synopsys: dsi: don't call __dw_mipi_dsi_probe from dw_mipi_dsi_bind

2018-10-01 Thread Heiko Stuebner
dw_mipi_dsi instead of the platform-device. Signed-off-by: Heiko Stuebner Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 15 +++ include/drm/bridge/dw_mipi_dsi.h | 5 + 2 files changed, 4 insertions(+), 16 deletions(-) diff --git

[PATCH v6 3/7] drm/bridge/synopsys: dsi: add ability to have glue-specific attach and detach

2018-10-01 Thread Heiko Stuebner
drivers, add a new struct for host_ops so that glue drivers can tell the bridge to call specific functions after the common host-attach and before the common host-detach run. Suggested-by: Andrzej Hajda Reviewed-by: Andrzej Hajda Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/bridge/synopsys/dw

Re: [PATCH v3] backlight: pwm_bl: switch to using "atomic" PWM API

2018-09-28 Thread Heiko Stuebner
Hi Lee, Am Montag, 10. September 2018, 16:49:24 CEST schrieb Lee Jones: > On Tue, 14 Aug 2018, Enric Balletbo i Serra wrote: > > > The "atomic" API allows us to configure PWM period and duty_cycle and > > enable it in one call. > > > > The patch also moves the pwm_init_state just before any use

Re: [PATCH v5 0/6] drm/rockchip: hdmi support for rk3328

2018-09-28 Thread Heiko Stuebner
Am Mittwoch, 12. September 2018, 14:47:34 CEST schrieb Heiko Stuebner: > The rk3228/rk3229 and rk3328 socs started using a new type of hdmi-phy > from Innosilicon that resides completely separate from the dw-hdmi block > and gets accessed via mmio. > > Additionally the rk33

Re: [PATCH v4] drm/panel: add Kingdisplay kd097d04 panel driver

2018-09-27 Thread Heiko Stuebner
Hi Thierry, Am Donnerstag, 27. September 2018, 14:07:21 CEST schrieb Thierry Reding: > On Fri, Aug 17, 2018 at 11:37:31AM +0200, Heiko Stuebner wrote: > > From: Nickey Yang > > > > Support Kingdisplay kd097d04 9.7" 1536x2048 TFT LCD panel, > > it is a

Re: [PATCH] drm/rockchip: vop: add rk3188 hs_start interrupt as dsp_hold equivalent

2018-09-27 Thread Heiko Stuebner
Am Sonntag, 23. September 2018, 14:37:30 CEST schrieb Heiko Stuebner: > The hs_start interrupt on rk3188 fires at the start of a new frame, so > serves essentially the same purpose as the dsp_hold_valid irq in checking > when the last frame got delivered when going to standby.

Re: [PATCH v5 2/5] drm/dp: fix link probing for devices supporting DP 1.4+

2018-09-25 Thread Heiko Stuebner
Hi Damian, Am Dienstag, 25. September 2018, 11:13:32 CEST schrieb Damian Kos: > From: Quentin Schulz > > DP 1.4 introduced a DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT bit in > DP_TRAINING_AUX_RD_INTERVAL register. If set, DPCD registers from > DP_DPCD_REV to DP_ADAPTER_CAP should be retrieved

Re: [PATCH v4 5/5] drm: bridge: add support for Cadence MHDP DPI/DP bridge

2018-09-24 Thread Heiko Stuebner
Hi Damian, Am Montag, 24. September 2018, 13:40:03 CEST schrieb Damian Kos: > > Am Donnerstag, 20. September 2018, 16:54:40 CEST schrieb Damian Kos: > > > From: Quentin Schulz > > > > > > This adds basic support for Cadence MHDP DPI to DP bridge. > > > > > > Basically, it takes a DPI stream as

[PATCH] drm/rockchip: vop: add rk3188 hs_start interrupt as dsp_hold equivalent

2018-09-23 Thread Heiko Stuebner
completed before. Fixes: 428e15cc41e3 ("drm/rockchip: vop: add rk3188 vop definitions") Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c b/drive

Re: [PATCH v4 5/5] drm: bridge: add support for Cadence MHDP DPI/DP bridge

2018-09-21 Thread Heiko Stuebner
Hi Damian, Am Donnerstag, 20. September 2018, 16:54:40 CEST schrieb Damian Kos: > From: Quentin Schulz > > This adds basic support for Cadence MHDP DPI to DP bridge. > > Basically, it takes a DPI stream as input and output it encoded in DP > format. It's missing proper HPD, HDCP and currently

Re: [PATCH v5 7/7] drm/rockchip: dsi: add dual mipi support

2018-09-20 Thread Heiko Stuebner
Hi Andrzej, Am Montag, 27. August 2018, 13:34:07 CEST schrieb Andrzej Hajda: > On 21.08.2018 16:05, Heiko Stuebner wrote: > > Add the Rockchip-sepcific dual-dsi setup and hook it into the VOP as well. > > As described in the general dual-dsi devicetree binding, the panel should

Re: [PATCH v3 0/5] drm: add support for Cadence MHDP DPI/DP bridge.

2018-09-13 Thread Heiko Stuebner
801 PHY (PHY's driver should be on the way by now) > - MST support > - DSC support > - FEC support > - HDCP support with te Kconfig issue in patch5 fixed, this series tested on rk3288 (analogix-dp) and rk3399 (analogix-dp + cadence-dp) Everything seems to work that worked before. Tested-

Re: [PATCH v3 5/5] drm/bridge: add preliminary driver for cadence dpi/dp bridge

2018-09-13 Thread Heiko Stuebner
Am Dienstag, 28. August 2018, 12:24:48 CEST schrieb Damian Kos: > From: Quentin Schulz > > This patch finally adds the preliminary driver for Cadence MHDP DPI/DP bridge. > > Changes made in the low level driver (cdn-dp-reg.*): > - moved it to from drivers/gpu/drm/rockchip to >

Re: [PATCH v4 6/6] drm/rockchip: dw_hdmi: add dw-hdmi support for the rk3328

2018-09-12 Thread Heiko Stuebner
Am Montag, 10. September 2018, 17:15:46 CEST schrieb Jonas Karlman: > Hi Heiko, > > CEC is not working when CEC 5V is enabled > > On 2018-09-10 11:22, Heiko Stuebner wrote: > > > The rk3328 uses a dw-hdmi controller with an external hdmi phy from > > Innosili

[PATCH v5 6/6] drm/rockchip: dw_hdmi: add dw-hdmi support for the rk3328

2018-09-12 Thread Heiko Stuebner
The rk3328 uses a dw-hdmi controller with an external hdmi phy from Innosilicon which uses the generic phy framework for access. Add the necessary data and the compatible for the rk3328 to the rockchip dw-hdmi driver. Signed-off-by: Heiko Stuebner Tested-by: Robin Murphy Acked-by: Rob Herring

[PATCH v5 2/6] drm/rockchip: dw_hdmi: Allow outputs that don't need output switching

2018-09-12 Thread Heiko Stuebner
-switching is necessary. Signed-off-by: Heiko Stuebner Tested-by: Robin Murphy changes in v3: - fixed wording issue found by Robin Murphy --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c

[PATCH v5 5/6] drm/rockchip: dw_hdmi: store rockchip_hdmi reference in phy_data object

2018-09-12 Thread Heiko Stuebner
and use this reference later on. Inspiration for this comes from meson and sunxi dw-hdmi, which are using the same method. Signed-off-by: Heiko Stuebner Tested-by: Robin Murphy changes in v3: - reword commit message --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 9 +++-- 1 file changed, 7

[PATCH v5 1/6] drm/bridge: dw-hdmi: allow forcing vendor phy-type

2018-09-12 Thread Heiko Stuebner
it may be necessary to allow forcing other types, but for now we'll keep it simply to the case actually seen in the wild. changes in v3: - only allow forcing vendor type, as suggested by Laurent Signed-off-by: Heiko Stuebner Tested-by: Robin Murphy --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4

[PATCH v5 0/6] drm/rockchip: hdmi support for rk3328

2018-09-12 Thread Heiko Stuebner
some dw-hdmi phy functions as a similar patch entered drm-misc already Heiko Stuebner (6): drm/bridge: dw-hdmi: allow forcing vendor phy-type drm/rockchip: dw_hdmi: Allow outputs that don't need output switching dt-bindings: allow optional phys in Rockchip dw_hdmi binding drm/rockchip

[PATCH v5 3/6] dt-bindings: allow optional phys in Rockchip dw_hdmi binding

2018-09-12 Thread Heiko Stuebner
Some newer Rockchip SoCs use an Innosilicon hdmiphy accessed via general mmio, so allow these to be referenced via the regular phy interfaces and therefore add optional phy-related properties to the binding. Signed-off-by: Heiko Stuebner Reviewed-by: Rob Herring --- .../devicetree/bindings

[PATCH v5 4/6] drm/rockchip: dw_hdmi: allow including external phys

2018-09-12 Thread Heiko Stuebner
Some variants of the dw-hdmi on Rockchip socs use a separate phy block accessed via the generic phy framework, so allow them to be included if such a phy reference is found. Signed-off-by: Heiko Stuebner Tested-by: Robin Murphy --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 10 ++ 1

[PATCH v4 2/6] drm/rockchip: dw_hdmi: Allow outputs that don't need output switching

2018-09-10 Thread Heiko Stuebner
-switching is necessary. Signed-off-by: Heiko Stuebner Tested-by: Robin Murphy changes in v3: - fixed wording issue found by Robin Murphy --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c

[PATCH v4 4/6] drm/rockchip: dw_hdmi: allow including external phys

2018-09-10 Thread Heiko Stuebner
Some variants of the dw-hdmi on Rockchip socs use a separate phy block accessed via the generic phy framework, so allow them to be included if such a phy reference is found. Signed-off-by: Heiko Stuebner Tested-by: Robin Murphy --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 10 ++ 1

[PATCH v4 3/6] dt-bindings: allow optional phys in Rockchip dw_hdmi binding

2018-09-10 Thread Heiko Stuebner
Some newer Rockchip SoCs use an Innosilicon hdmiphy accessed via general mmio, so allow these to be referenced via the regular phy interfaces and therefore add optional phy-related properties to the binding. Signed-off-by: Heiko Stuebner Reviewed-by: Rob Herring --- .../devicetree/bindings

[PATCH v4 0/6] drm/rockchip: hdmi support for rk3328

2018-09-10 Thread Heiko Stuebner
Heiko Stuebner (6): drm/bridge: dw-hdmi: allow forcing vendor phy-type drm/rockchip: dw_hdmi: Allow outputs that don't need output switching dt-bindings: allow optional phys in Rockchip dw_hdmi binding drm/rockchip: dw_hdmi: allow including external phys drm/rockchip: dw_hdmi: store

[PATCH v4 5/6] drm/rockchip: dw_hdmi: store rockchip_hdmi reference in phy_data object

2018-09-10 Thread Heiko Stuebner
and use this reference later on. Inspiration for this comes from meson and sunxi dw-hdmi, which are using the same method. Signed-off-by: Heiko Stuebner Tested-by: Robin Murphy changes in v3: - reword commit message --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 9 +++-- 1 file changed, 7

[PATCH v4 6/6] drm/rockchip: dw_hdmi: add dw-hdmi support for the rk3328

2018-09-10 Thread Heiko Stuebner
The rk3328 uses a dw-hdmi controller with an external hdmi phy from Innosilicon which uses the generic phy framework for access. Add the necessary data and the compatible for the rk3328 to the rockchip dw-hdmi driver. Signed-off-by: Heiko Stuebner Tested-by: Robin Murphy Acked-by: Rob Herring

  1   2   3   4   5   >