[GIT PULL] exynos-drm-next

2019-04-22 Thread Inki Dae
Hi Dave, Just log cleanup patches of Exynos KMS and DMA drivers including one trivial style fixup. Please kinkdly let me know if there is any problem. Thanks, Inki Dae The following changes since commit dbb92471674a48892f5e50779425e03388073ab9: Revert "drm: allow render ca

[PATCH 6/6] drm/exynos: ipp: clean up debug messages

2019-04-15 Thread Inki Dae
. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_fimc.c| 5 ++-- drivers/gpu/drm/exynos/exynos_drm_gsc.c | 5 ++-- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 46 ++--- drivers/gpu/drm/exynos/exynos_drm_ipp.h | 9 +++--- drivers/gpu/drm

[PATCH 5/6] drm/exynos: vidi: replace platform_device pointer with device one

2019-04-15 Thread Inki Dae
Add device pointer to vidi_context and remove platform_device pointer. It doesn't need for vidi_context to contain platform_device object. Instead, this patch makes this driver more simply by replacing platform_device pointer with device one. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos

[PATCH 3/6] drm/exynos: use DRM_DEV_ERROR to print out error message

2019-04-15 Thread Inki Dae
This patch just cleans up the use of error log macro, which changes the log macro to DRM_DEV_ERROR. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 +- drivers/gpu/drm/exynos/exynos7_drm_decon.c| 14 +--- drivers/gpu/drm/exynos/exynos_dp.c| 9

[PATCH 4/6] drm/exynos: use DRM_DEV_DEBUG* instead of DRM_DEBUG macro

2019-04-15 Thread Inki Dae
Use DRM_DEV_DEBUG* instead of DRM_DEBUG macro to print out debug messages. This patch just cleans up the use of debug log macro, which changes the log macro to DRM_DEV_DEBUG*. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 +- drivers/gpu/drm/exynos

[PATCH 2/6] drm/exynos: remove unnecessary messages

2019-04-15 Thread Inki Dae
This patch removes unnecessary messages from fimd_clear_channels and decon_clear_channels functions which print out just function name. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 -- drivers/gpu/drm/exynos/exynos7_drm_decon.c| 2 -- drivers/gpu/drm/exynos

[PATCH 1/6] drm/exynos: fimd: use DRM_ERROR instead of DRM_INFO in error case

2019-04-15 Thread Inki Dae
This patch makes error messages to be printed out using DRM_ERROR instead of DRM_INFO. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm

[PATCH 0/6 v3] drm/exynos: clean up logs

2019-04-15 Thread Inki Dae
up debug/error messages of all Exynos DRM KMS and DMA drivers. . Clean up vidi driver by adding device pointer to vidi_context. . Clean up ipp driver by using device pointer instead of drm_device one, which makes ipp driver to print out the debug messages with correct device name. Inki Dae (6

Re: [PATCH 0/7 v2] drm/exynos: clean up logs

2019-04-15 Thread Inki Dae
Hi Sam, 19. 4. 15. 오후 6:13에 Sam Ravnborg 이(가) 쓴 글: > Hi Inki > > >> Inki Dae (6): >> drm/fimd: use DRM_ERROR instead of DRM_INFO in error case >> drm/exynos: remove unnecessary messages >> drm/exynos: use DRM_DEV_ERROR to print out error message &

Re: [PATCH 1/7] drm/exynos: g2d: remove style error

2019-04-15 Thread Inki Dae
Oops. There was my mistake. This patch is already merged to exynos-drm-fixes. Please ignore this one. Thanks, Inki Dae 19. 4. 15. 오후 5:54에 Inki Dae 이(가) 쓴 글: > From: Seung-Woo Kim > > Remove checkpatch error, "foo* bar" should be "foo *bar". > > Signed-

[PATCH 5/7] drm/exynos: use DRM_DEV_DEBUG* instead of DRM_DEBUG macro

2019-04-15 Thread Inki Dae
Use DRM_DEV_DEBUG* instead of DRM_DEBUG macro to print out debug messages. This patch just cleans up the use of debug log macro, which changes the log macro to DRM_DEV_DEBUG*. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 +- drivers/gpu/drm/exynos

[PATCH 3/7] drm/exynos: remove unnecessary messages

2019-04-15 Thread Inki Dae
This patch removes unnecessary messages from fimd_clear_channels and decon_clear_channels functions which print out just function name. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 -- drivers/gpu/drm/exynos/exynos7_drm_decon.c| 2 -- drivers/gpu/drm/exynos

[PATCH 0/7 v2] drm/exynos: clean up logs

2019-04-15 Thread Inki Dae
driver by adding device pointer to vidi_context. . Clean up ipp driver by using device pointer instead of drm_device one, which makes ipp driver to print out the debug messages with correct device name. Inki Dae (6): drm/fimd: use DRM_ERROR instead of DRM_INFO in error case drm/exynos: remove

[PATCH 2/7] drm/fimd: use DRM_ERROR instead of DRM_INFO in error case

2019-04-15 Thread Inki Dae
This patch makes error messages to be printed out using DRM_ERROR instead of DRM_INFO. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm

[PATCH 7/7] drm/ipp: clean up debug messages

2019-04-15 Thread Inki Dae
. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_fimc.c| 5 ++-- drivers/gpu/drm/exynos/exynos_drm_gsc.c | 5 ++-- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 46 ++--- drivers/gpu/drm/exynos/exynos_drm_ipp.h | 9 +++--- drivers/gpu/drm

[PATCH 4/7] drm/exynos: use DRM_DEV_ERROR to print out error message

2019-04-15 Thread Inki Dae
This patch just cleans up the use of error log macro, which changes the log macro to DRM_DEV_ERROR. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 +- drivers/gpu/drm/exynos/exynos7_drm_decon.c| 14 +--- drivers/gpu/drm/exynos/exynos_dp.c| 9

[PATCH 1/7] drm/exynos: g2d: remove style error

2019-04-15 Thread Inki Dae
From: Seung-Woo Kim Remove checkpatch error, "foo* bar" should be "foo *bar". Signed-off-by: Seung-Woo Kim Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos

[PATCH 6/7] drm/vidi: replace platform_device pointer with device one

2019-04-15 Thread Inki Dae
Add device pointer to vidi_context and remove platform_device pointer. It doesn't need for vidi_context to contain platform_device object. Instead, this patch makes this driver more simply by replacing platform_device pointer with device one. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos

Re: [PATCH 1/2] drm/fimd: use DRM_ERROR instead of DRM_INFO in error case

2019-04-14 Thread Inki Dae
Hi Sam, 19. 4. 15. 오후 12:17에 Sam Ravnborg 이(가) 쓴 글: > Hi Inki > > On Mon, Apr 15, 2019 at 09:47:19AM +0900, Inki Dae wrote: >> This patch makes error messages to be printed out using DRM_ERROR >> instead of DRM_INFO. >> >> Signed-off-by: Inki Dae

[PATCH 1/2] drm/fimd: use DRM_ERROR instead of DRM_INFO in error case

2019-04-14 Thread Inki Dae
This patch makes error messages to be printed out using DRM_ERROR instead of DRM_INFO. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm

[PATCH 2/2] drm/exynos: remove unnecessary messages

2019-04-14 Thread Inki Dae
This patch removes unnecessary messages from fimd_clear_channels and decon_clear_channels functions which print out just function name. Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 -- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 -- 2 files changed, 4

[PATCH 0/2] drm/exynos: clean up logs

2019-04-14 Thread Inki Dae
Just clean up logs from exynos drm driver. Inki Dae (2): drm/fimd: use DRM_ERROR instead of DRM_INFO in error case drm/exynos: remove unnecessary messages drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 -- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 8 +++- 2 files changed, 3

Re: [PATCH 08/21] drm/exynos: Use drm_fb_helper_fill_info

2019-03-27 Thread Inki Dae
19. 3. 26. 오후 10:19에 Daniel Vetter 이(가) 쓴 글: > This will give the exynos fbdev a name! > > v2: Rebase > > Signed-off-by: Daniel Vetter Acked-by: Inki Dae Thanks, Inki Dae > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Seung-Woo Kim > Cc: Kyungmin Park > C

Re: [PATCH v3 RESEND 00/24] drm/exynos: add support for GSCALER planes on Exynos5433

2019-03-26 Thread Inki Dae
19. 3. 26. 오후 10:51에 Andrzej Hajda 이(가) 쓴 글: > On 26.03.2019 09:45, Inki Dae wrote: >> Hi Andrzej, >> >> 19. 3. 25. 오후 4:13에 Andrzej Hajda 이(가) 쓴 글: >>> Hi Inki, >>> >>> GSCALERs in Exynos SoCs support conversion between wide range of image >&g

Re: [PATCH v3 RESEND 00/24] drm/exynos: add support for GSCALER planes on Exynos5433

2019-03-26 Thread Inki Dae
aware that DTS patches has been already applied to samsung-soc tree, > I left them here to simplify testing on exynos-drm-next, which is not in sync > with > samsung-soc, for this reason I have moved them on the beginning of the > patchset. Got it. I can test it by doing cherry-pick

Re: [PATCH v2 RESEND 00/24] drm/exynos: add support for GSCALER planes on Exynos5433

2019-03-24 Thread Inki Dae
Hi Andrzej, Merge conflict. Could you rebase this patch series on top of exynos-drm-next? Thanks, Inki Dae 19. 3. 20. 오후 10:06에 Andrzej Hajda 이(가) 쓴 글: > Hi Inki, > > GSCALERs in Exynos SoCs support conversion between wide range of image > formats, > plus scaling and rot

[GIT PULL] exynos-drm-fixes

2019-03-21 Thread Inki Dae
Hi Dave, Just one fixup to resolve page fault issue at Mixer device. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 9e98c678c2d6ae3a17cb2de55d17f69dddaa231b: Linux 5.1-rc1 (2019-03-17 14:22:26 -0700) are available in the git

Re: [PATCH v2] drm/exynos/mixer: fix MIXER shadow registry synchronisation code

2019-03-21 Thread Inki Dae
Hi Marek, 19. 3. 21. 오후 5:32에 Marek Szyprowski 이(가) 쓴 글: > Hi Inki, > > On 2019-03-21 09:20, Inki Dae wrote: >> 19. 3. 19. 오후 10:05에 Andrzej Hajda 이(가) 쓴 글: >>> MIXER on Exynos5 SoCs uses different synchronisation method than Exynos4 >>> to update

Re: [PATCH v2] drm/exynos/mixer: fix MIXER shadow registry synchronisation code

2019-03-21 Thread Inki Dae
you or someone else who has Exynos4xxx based board check it on Odroid-u3 board? I have no board. :( Thanks, Inki Dae > > Regards > Andrzej > --- > drivers/gpu/drm/exynos/exynos_mixer.c | 110 +++--- > 1 file changed, 66 insertions(+), 44 deletions(-) > &

Re: [PATCH 2/6] drm/exynos: dsi: Use drm_bridge_detach

2019-03-18 Thread Inki Dae
-off-by: Jagan Teki Acked-by: Inki Dae Thanks, Inki Dae > --- > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c > b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > index a

Re: [PATCH] drm/exynos/mixer: fix MIXER shadow registry synchronisation code

2019-03-18 Thread Inki Dae
ne kernel - linux-5.1.0-rc1 - and even on Tizen kernel (tizen-next branch) but screen remained blank after running modetest app. Without this patch, modetest app worked well on both kernels. Thanks, Inki Dae > > -- > Either I've been missing something or nothing has been going on. (K. E. >

[GIT PULL] exynos-drm-next

2019-02-07 Thread Inki Dae
Hi Dave, Just adding s5pv210 SoC support of rotator module and changing email address of scaler module author. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 2cc3b81dfa7f7de0d647e7f1473de811eef8b0de: Merge tag 'drm-intel-next

Re: [PATCH 1/6] include/drm: color_mgmt: Add enum labels

2019-01-17 Thread Inki Dae
n't see why above two types are needed. Is there any case that the range checking behavior should be different according to the color space? And even if there is that case, I think you have to put DRM_COLOR_RANG_MAX under DRM_COLOR_FULL_RANGE. Thanks, Inki Dae > }; > &

Re: [PATCH 1/3] drm/exynos: rotator: Add support for s5pv210

2019-01-08 Thread Inki Dae
Applied. Thanks, Inki Dae > --- > drivers/gpu/drm/exynos/exynos_drm_rotator.c | 23 + > 1 file changed, 23 insertions(+) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_rotator.c > b/drivers/gpu/drm/exynos/exynos_drm_rotator.c > index a820a68429b9..a822

[GIT PULL v2] exynos-drm-next

2018-12-13 Thread Inki Dae
Hi Dave, Just adding configurable plane alpha and pixel blend mode support for FIMD device I missed. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 2a3c83f5fe0770d13bbb71b23674886ff4111f44: Merge tag 'vmwgfx-next-2018-12-13

Re: [PATCH 0/3] drm/exynos: add support for dynamic zpos in DECON and FIMD

2018-12-12 Thread Inki Dae
18. 12. 12. 오후 5:43에 Andrzej Hajda 이(가) 쓴 글: > On 12.12.2018 00:26, Inki Dae wrote: >> >> 18. 12. 11. 오후 5:36에 Andrzej Hajda 이(가) 쓴 글: >>> On 11.12.2018 09:01, Inki Dae wrote: >>>> 18. 12. 11. 오후 4:49에 Andrzej Hajda 이(가) 쓴 글: >>>>> On

Re: [PATCH 0/3] drm/exynos: add support for dynamic zpos in DECON and FIMD

2018-12-12 Thread Inki Dae
18. 12. 12. 오후 5:30에 Andrzej Hajda 이(가) 쓴 글: > On 12.12.2018 00:48, Inki Dae wrote: >> >> 18. 12. 11. 오후 10:20에 Andrzej Hajda 이(가) 쓴 글: >>> Hi again, >>> >>> It seems I have missed two questions: >>> >>> On 11.12.2018 09:36, Andrzej Haj

Re: [PATCH 0/3] drm/exynos: add support for dynamic zpos in DECON and FIMD

2018-12-11 Thread Inki Dae
18. 12. 11. 오후 10:20에 Andrzej Hajda 이(가) 쓴 글: > Hi again, > > It seems I have missed two questions: > > On 11.12.2018 09:36, Andrzej Hajda wrote: >> On 11.12.2018 09:01, Inki Dae wrote: >>> 18. 12. 11. 오후 4:49에 Andrzej Hajda 이(가) 쓴 글: >>>> On 11.12.20

Re: [PATCH 0/3] drm/exynos: add support for dynamic zpos in DECON and FIMD

2018-12-11 Thread Inki Dae
18. 12. 11. 오후 5:36에 Andrzej Hajda 이(가) 쓴 글: > On 11.12.2018 09:01, Inki Dae wrote: >> >> 18. 12. 11. 오후 4:49에 Andrzej Hajda 이(가) 쓴 글: >>> On 11.12.2018 00:45, Inki Dae wrote: >>>> Hi Andrzej, >>>> >>>> 18. 12. 10. 오후 4:35에 Andrzej Ha

Re: [PATCH 0/3] drm/exynos: add support for dynamic zpos in DECON and FIMD

2018-12-11 Thread Inki Dae
18. 12. 11. 오후 4:49에 Andrzej Hajda 이(가) 쓴 글: > On 11.12.2018 00:45, Inki Dae wrote: >> Hi Andrzej, >> >> 18. 12. 10. 오후 4:35에 Andrzej Hajda 이(가) 쓴 글: >>> Hi Inki, >>> >>> On 10.12.2018 03:25, Inki Dae wrote: >>>> Hi Andrzej, >>

Re: [PATCH 0/3] drm/exynos: add support for dynamic zpos in DECON and FIMD

2018-12-10 Thread Inki Dae
Hi Andrzej, 18. 12. 10. 오후 4:35에 Andrzej Hajda 이(가) 쓴 글: > Hi Inki, > > On 10.12.2018 03:25, Inki Dae wrote: >> Hi Andrzej, >> >> 18. 12. 6. 오후 6:38에 Andrzej Hajda 이(가) 쓴 글: >>> Hi Inki, >>> >>> This small patchset adds dynamic zpos support f

Re: [PATCH 0/3] drm/exynos: add support for dynamic zpos in DECON and FIMD

2018-12-09 Thread Inki Dae
e by user space doesn't guarantee correct HW overlay priority. Why do you want to support mutable zpos? Thanks, Inki Dae > It was tested on tm2 and trats2. > > Regards > Andrzej > > > Andrzej Hajda (3): > drm/exynos/decon5433: add dynamic zpos support >

Re: [PATCH 0/3] drm/exynos: add support for dynamic zpos in DECON and FIMD

2018-12-06 Thread Inki Dae
ynos-drm-next, or on all > Christoph's patches? I missed to merge Christoph's patches. Thanks for notice. Now you can rebase your patch on top of exynos-drm-next. Thanks, Inki Dae > > > Regards > > Andrzej > > >> >> Regards >> Andrzej >> >> >

[GIT PULL] exynos-drm-next

2018-12-05 Thread Inki Dae
Hi Dave, Three patch series - code refactoring for simplifying DMA mapping, enhancing plane alpha and blend mode support for Exynos5433 Decon device, and fixing color format setting of Mixer driver. Please kindly let me know if there is any problem. Thanks, Inki Dae The following

Re: [PATCH 0/6] drm/exynos/iommu: refactoring

2018-11-27 Thread Inki Dae
exynos-drm-next-todo for more tests last week. I had a review for your patch series and Looked good but I'd like to have more tests. Thanks, Inki Dae > > Regards > > Andrzej > > > >> >> Regards >> Andrzej >> >> >> Andrzej Hajda (6): &

[GIT PULL] exynos-drm-fixes

2018-11-05 Thread Inki Dae
Hi Dave, Just three regression fixups - fix extension and clone mode issue, fix lack of fbdev on Rinato and trats boards, and check for dsi->panel object correctlY. Please kindely let me know if there is any problem. Thanks, Inki Dae The following changes since com

Re: [PATCH] Revert "drm/exynos/decon5433: implement frame counter"

2018-10-05 Thread Inki Dae
On 2018년 10월 05일 15:26, Daniel Vetter wrote: > On Fri, Oct 5, 2018 at 8:22 AM Daniel Vetter wrote: >> >> On Fri, Oct 5, 2018 at 4:59 AM Inki Dae wrote: >>> >>> This reverts commit 0586feba322e1de05075700eb4b835c8b683e62b >>> >>> This patch m

[PATCH] Revert "drm/exynos/decon5433: implement frame counter"

2018-10-04 Thread Inki Dae
off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 9 - drivers/gpu/drm/exynos/exynos_drm_crtc.c | 11 --- drivers/gpu/drm/exynos/exynos_drm_drv.h | 1 - 3 files changed, 21 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/

Re: [PATCH v2 2/3] iommu/dma: Use fast DMA domain lookup

2018-10-01 Thread Inki Dae
+ dri-devel This patch may also break other ARM DRM drivers. I cced dri-devel so that they could manage this. And below relevant link for ARM DRM maintainers, https://www.spinics.net/lists/arm-kernel/msg676098.html Thanks, Inki Dae 2018년 9월 29일 (토) 오전 1:19, Marek Szyprowski 님이 작성: > &

[GIT PULL] exynos-drm-next

2018-10-01 Thread Inki Dae
] https://patchwork.freedesktop.org/patch/243921/ Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 0320ac5188eab5c6e8b92b110d1eae967ac272d2: Merge tag 'du-next-20180914' of git://linuxtv.org/pinchartl/media into drm-next (2018-09-20 14

[GIT PULL] exynos-drm-fixes

2018-09-30 Thread Inki Dae
and DMA-IOMMU frameworks in v4.20 Please kindly let me know if there is any problem. [1] https://www.spinics.net/lists/arm-kernel/msg676098.html Thanks, Inki Dae The following changes since commit fcb1349a2af5a3c4a1d789bb5d1a9b3e582652a3: Merge branch 'drm-fixes-4.19' of git

Re: [PATCH 2/3] drm/exynos: scaler: Add support for tiled formats

2018-09-20 Thread Inki Dae
struct drm_exynos_ipp_task_rect *src_pos = >src.rect; > > - u32 dst_fmt = scaler_get_format(task->dst.buf.fourcc); > + const struct scaler_format *dst_fmt = > scaler_get_format(task->dst.buf.fourcc); > struct drm_exynos_ipp_task_rect *dst_pos = >

Re: [PATCH v4] gpu/drm/exynos: Convert drm_atomic_helper_suspend/resume()

2018-09-20 Thread Inki Dae
ed for 4.20 ? Queued already to exynos-drm-next below so please wait. I will have pull-request soon. https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git/log/?h=exynos-drm-next Thanks, Inki Dae > >>> --- >>> v2: Address Inki Dae's comment. Remove ret v

Re: [PATCH 2/3] drm/exynos: scaler: Add support for tiled formats

2018-09-13 Thread Inki Dae
2018년 09월 13일 17:49에 Marek Szyprowski 이(가) 쓴 글: > Hi Inki, > > On 2018-09-13 10:23, Inki Dae wrote: >> 2018년 09월 13일 17:03에 Marek Szyprowski 이(가) 쓴 글: >>> On 2018-09-13 07:14, Inki Dae wrote: >>>> 2018년 09월 12일 15:59에 Andrzej Pietrasiewicz 이(가) 쓴 글: >&

Re: [PATCH 2/3] drm/exynos: scaler: Add support for tiled formats

2018-09-13 Thread Inki Dae
Hi Marek, 2018년 09월 13일 17:03에 Marek Szyprowski 이(가) 쓴 글: > Hi Inki, > > On 2018-09-13 07:14, Inki Dae wrote: >> 2018년 09월 12일 15:59에 Andrzej Pietrasiewicz 이(가) 쓴 글: >>> W dniu 12.09.2018 o 01:54, Inki Dae pisze: >>>> Hi Marek and Andrzej, >>>> >

Re: [PATCH 2/3] drm/exynos: scaler: Add support for tiled formats

2018-09-12 Thread Inki Dae
2018년 09월 12일 15:59에 Andrzej Pietrasiewicz 이(가) 쓴 글: > Hi Inki, > > W dniu 12.09.2018 o 01:54, Inki Dae pisze: >> Hi Marek and Andrzej, >> >> 2018년 08월 10일 22:29에 Marek Szyprowski 이(가) 쓴 글: >>> From: Andrzej Pietrasiewicz >>> >>> Add suppo

Re: [PATCH 2/3] drm/exynos: scaler: Add support for tiled formats

2018-09-11 Thread Inki Dae
plane has always same tile size. And also RGB formats have 16 x 16 tile size in tile mode but you declared it as 0. Could you check it out again? Thanks, Inki Dae > +}; > + > +static const struct scaler_format *scaler_get_format(u32 drm_fmt) > { > - switch (drm_fmt)

Re: [PATCH 1/3] drm: drm_fourcc: add Samsung 16x16 tile format

2018-09-06 Thread Inki Dae
Hi, 2018년 08월 27일 09:38에 Inki Dae 이(가) 쓴 글: > > > 2018년 08월 10일 22:28에 Marek Szyprowski 이(가) 쓴 글: >> From: Andrzej Pietrasiewicz >> >> Add modifier for tiled formats used by graphics modules found in Samsung >> Exynos5250/542x/5433 SoCs. This is a simple til

Re: [PATCH 1/3] drm: drm_fourcc: add Samsung 16x16 tile format

2018-08-26 Thread Inki Dae
2018년 08월 10일 22:28에 Marek Szyprowski 이(가) 쓴 글: > From: Andrzej Pietrasiewicz > > Add modifier for tiled formats used by graphics modules found in Samsung > Exynos5250/542x/5433 SoCs. This is a simple tiled layout using tiles > of 16x16 pixels in a row-major layout. Review

Re: [PATCH v5 2/9] drm/exynos: move connector creation to attach callback

2018-08-21 Thread Inki Dae
2018년 08월 21일 20:21에 Andrzej Hajda 이(가) 쓴 글: > On 21.08.2018 07:27, Inki Dae wrote: >> >> 2018년 08월 20일 18:00에 Andrzej Hajda 이(가) 쓴 글: >>> On 17.08.2018 03:56, Inki Dae wrote: >>>> 2018년 08월 13일 20:17에 Andrzej Hajda 이(가) 쓴 글: >>>>> On 07.08.2018

Re: [PATCH v5 2/9] drm/exynos: move connector creation to attach callback

2018-08-20 Thread Inki Dae
2018년 08월 20일 18:00에 Andrzej Hajda 이(가) 쓴 글: > On 17.08.2018 03:56, Inki Dae wrote: >> >> 2018년 08월 13일 20:17에 Andrzej Hajda 이(가) 쓴 글: >>> On 07.08.2018 10:53, Inki Dae wrote: >>>> 2018년 07월 26일 00:46에 Andrzej Hajda 이(가) 쓴 글: >>>>> From: Ma

Re: [PATCH v5 2/9] drm/exynos: move connector creation to attach callback

2018-08-16 Thread Inki Dae
2018년 08월 13일 20:17에 Andrzej Hajda 이(가) 쓴 글: > On 07.08.2018 10:53, Inki Dae wrote: >> >> 2018년 07월 26일 00:46에 Andrzej Hajda 이(가) 쓴 글: >>> From: Maciej Purski >>> >>> The current implementation assumes that the only possible peripheral >>>

Re: [PATCH v5 2/9] drm/exynos: move connector creation to attach callback

2018-08-07 Thread Inki Dae
t considering device tree graph binding? Then, you embedded bridge device node in dsi device node[1] but the binding document below doesn't mention about this, Documentation/devicetree/bindings/display/exynos/exynos_dsim.txt [1] https://lkml.org/lkml/2018/6/19/237 Thanks, Inki Dae > + if (o

Re: [PATCH v3 1/9] drm/exynos: rename "bridge_node" to "mic_bridge_node"

2018-07-25 Thread Inki Dae
2018년 07월 25일 17:11에 Andrzej Hajda 이(가) 쓴 글: > On 24.07.2018 09:49, Inki Dae wrote: >> Hi, >> >> 2018년 06월 19일 17:19에 Maciej Purski 이(가) 쓴 글: >>> When adding support for peripheral out bridges, the "bridge" name >>> becomes imprecise as it refe

[GIT PULL] exynos-drm-next

2018-07-25 Thread Inki Dae
Hi Dave, Two big cleanups to suspend/resume code and g2d driver including trivial one. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 2d3bda7071a713fa4ecf9d0acb7faede6d59100a: Merge tag 'exynos-drm-fixes-for-v4.18-rc4

Re: [PATCH v3 2/9] drm/exynos: move connector creation to attach callback

2018-07-24 Thread Inki Dae
2018년 07월 24일 17:04에 Inki Dae 이(가) 쓴 글: > Hi, > > 2018년 06월 19일 17:19에 Maciej Purski 이(가) 쓴 글: >> The current implementation assumes that the only possible peripheral >> device for DSIM is a panel. Using an output bridge child device >> should also be possible

Re: [PATCH v3 2/9] drm/exynos: move connector creation to attach callback

2018-07-24 Thread Inki Dae
DSI > peripheral bridge device. Right, we should consider DSI to LVDS bridge. Thanks, Inki Dae > > Signed-off-by: Maciej Purski > --- > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 38 > ++--- > 1 file changed, 25 insertions(+), 13 deletions(-) >

Re: [PATCH v3 3/9] drm/exynos: enable out_bridge in exynos_dsi_enable()

2018-07-24 Thread Inki Dae
able(dsi, false); > - drm_panel_unprepare(dsi->panel); > - pm_runtime_put_sync(dsi->dev); > - return; > + if (dsi->panel) { > + ret = drm_panel_enable(dsi->panel); > + if (ret &l

Re: [PATCH 1/3] drm/exynos: Drop useless check from exynos_drm_{suspend,resume}

2018-07-24 Thread Inki Dae
2018년 07월 24일 16:49에 Marek Szyprowski 이(가) 쓴 글: > Hi Inki, > > On 2018-07-24 09:12, Inki Dae wrote: >> 2018년 06월 11일 21:24에 Marek Szyprowski 이(가) 쓴 글: >>> The virtual Exynos DRM device has no runtime PM enabled, so checking >>> for its runtime suspended sta

Re: [PATCH v3 1/9] drm/exynos: rename "bridge_node" to "mic_bridge_node"

2018-07-24 Thread Inki Dae
nd what you say. And in case of Exynos5433 SoC, SMIES(Samsung Mobile Image Enhancement System) can be located between DECON and MIPI-DSI devices also. Therefore, having specific name isn't reasonable. Thanks, Inki Dae > > Signed-off-by: Maciej Purski > --- > drivers/gpu/drm/exynos/ex

Re: [PATCH 1/3] drm/exynos: Drop useless check from exynos_drm_{suspend,resume}

2018-07-24 Thread Inki Dae
> - return 0; > + if (!drm_dev) > + return; return 0. I will fix it. Thanks, Inki Dae > > private = drm_dev->dev_private; > drm_atomic_helper_resume(drm_dev, private->suspend_state); > ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] gpu/drm/exynos: Convert drm_atomic_helper_suspend/resume()

2018-07-24 Thread Inki Dae
helper_poll_enable(drm_dev); > + ret = drm_mode_config_helper_resume(drm_dev); Ditto. return drm_mode_config_helper_resume(drm_dev); With this patch, you could remove 'int ret' declaration including one from exynos_drm_suspend. Thanks, Inki Dae > > - return 0; > + return

[GIT PULL]: exynos-drm-fixes

2018-07-02 Thread Inki Dae
Hi Dave, Several fixups to Exynos DRM IPP v2 framework and relevant drivers merged to mainline recently, and some clenaups. Please kindely let me know if there is any problem. Thanks, Inki Dae The following changes since commit 2d8aa4ef6aac566617052640e9bb07ecb9c45183: Merge tag

Re: [PATCH 0/9] Exynos DRM IPP fixes

2018-06-25 Thread Inki Dae
pped horizontal > and vertial flips or used incorrect variant of the YUV modes. This > patchset fixes those issues. This patchset had been reviewed and verified already on review.tizen.org so merged to exynos-drm-fixes. Thanks, Inki Dae > > Best regards > Marek Szyprowski > Samsun

Re: [PATCH v2 01/10] drm/exynos: rename "bridge_node" to "mic_bridge_node"

2018-06-24 Thread Inki Dae
Hi, I will start to review patch sets for -fixes first so I queued your four patches and you can check exynos-drm-next-todo branch for it. Thanks, Inki Dae 2018년 05월 30일 21:15에 Maciej Purski 이(가) 쓴 글: > When adding support for peripheral out bridges, the "bridge" name > b

Re: [PATCH v2] drm/exynos: ipp: fix image broken issue

2018-05-28 Thread Inki Dae
This patch changes userspace parameter but Kernel driver shouldn't touch such parameter. Please ignore this patch. Marek will post a generic solution soon, which fixes the image broken issue without touching userspace parameter. Thanks, Inki Dae 2018년 05월 24일 10:04에 Inki Dae 이(가) 쓴 글: > Fi

[GIT PULL v2] exynos-drm-next

2018-05-25 Thread Inki Dae
Hi Dave, Since previous git-pull request, it includes more HW overlays support of DECON controller and several fixups and one cleanup. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit bec923c50ab550d1d53b297dd4c753db18a13204

[PATCH v2] drm/bridge: sil_sii8620: do not have a dependency of RC_CORE

2018-05-24 Thread Inki Dae
driver only for HDMI. Changelog v2: - select INPUT because compiling will fail without INPUT. Signed-off-by: Inki Dae <inki@samsung.com> --- drivers/gpu/drm/bridge/Kconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/g

Re: [PATCH] drm/bridge: sil_sii8620: do not have a dependency of RC_CORE

2018-05-24 Thread Inki Dae
2018년 05월 24일 17:03에 Andrzej Hajda 이(가) 쓴 글: > On 24.05.2018 09:07, Inki Dae wrote: >> This patch makes RC_CORE to be selected with this driver. >> >> sil_sii8620 driver calls remote controller interfaces directly >> so RC_CORE should be enabled mandatorily. >

Re: [PATCH 0/3] Exynos DRM - add 2 more planes to Decon on Exynos5433

2018-05-24 Thread Inki Dae
or this patchset: > 1. dts (patch 2/3) - please schedule for v4.18 merge window > 2. driver (patch 3/3) - please schedule for the next release after dts is >merged > 3. bindings (patch 1/3) - probably can go together with the driver patch Merged 1 and 3. Thanks, Inki Dae >

[PATCH] drm/bridge: sil_sii8620: do not have a dependency of RC_CORE

2018-05-24 Thread Inki Dae
driver only for HDMI. Signed-off-by: Inki Dae <inki@samsung.com> --- drivers/gpu/drm/bridge/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig index 3aa65bd..0290fc3 100644 --- a/drivers/gpu/drm/

[PATCH v2] drm/exynos: ipp: fix image broken issue

2018-05-23 Thread Inki Dae
fixup buffer function before calling size limit check. - Remove checking align of image offset, x and y. The offest values have no any limit but only size. Signed-off-by: Inki Dae <inki@samsung.com> --- drivers/gpu/drm/exynos/exynos_drm_gsc.c | 94 +++-- drive

[PATCH] drm/exynos: scaler: fix static checker warning

2018-05-22 Thread Inki Dae
drivers/gpu/drm/exynos/exynos_drm_scaler.c:402 scaler_task_done() warn: signedness bug returning '(-22)' Reported-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: Inki Dae <inki@samsung.com> --- drivers/gpu/drm/exynos/exynos_drm_scaler.c | 2 +- 1 file changed, 1 ins

Re: [PATCH] drm/exynos: fimc: signedness bug in fimc_setup_clocks()

2018-05-22 Thread Inki Dae
2018년 05월 18일 17:04에 Dan Carpenter 이(가) 쓴 글: > "id" needs to be signed for the error handling to work. Applied to exynos-drm-fixes-v4.18-rc1. Thanks, Inki Dae > > Fixes: 7a2d5c77c558 ("drm/exynos: fimc: Convert driver to IPP v2 core API") > Signed-o

[PATCH] drm/exynos: ipp: fix image broken issue

2018-05-16 Thread Inki Dae
gem buffer is enough for it or not. Signed-off-by: Inki Dae <inki@samsung.com> --- drivers/gpu/drm/exynos/exynos_drm_gsc.c | 87 +++-- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 15 ++ drivers/gpu/drm/exynos/exynos_drm_ipp.h | 12 + 3 files change

[GIT PULL] exynos-drm-next

2018-05-13 Thread Inki Dae
if there is any problem. Thanks, Inki Dae The following changes since commit a02cbe2e34c576cdc5e7846a3cd55245ab81db47: Merge branch 'vmwgfx-fixes-4.17' of git://people.freedesktop.org/~thomash/linux into drm-fixes (2018-05-04 10:03:27 +1000) are available in the git repository at: git

Re: [PATCH] gpu: drm: exynos: Change return type to vm_fault_t

2018-05-11 Thread Inki Dae
;> +#include >> >> #define to_exynos_gem(x) container_of(x, struct exynos_drm_gem, base) >> >> @@ -111,7 +112,7 @@ int exynos_drm_gem_dumb_create(struct drm_file >> *file_priv, >> struct drm_mode_create_dumb *args); >&

Re: [PATCH v7 7/7] ARM64: dts: exynos: Add mem-2-mem Scaler devices

2018-05-09 Thread Inki Dae
com> > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> Reviewed-by: Inki Dae <inki@samsung.com> Thanks, Inki Dae > --- > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 46 ++ > 1 file changed, 46 insertions(+) > > diff --git a/arc

Re: [PATCH v7 6/7] ARM: dts: exynos: Add mem-2-mem Scaler devices

2018-05-09 Thread Inki Dae
ve been already added to exynos5420.dtsi earlier, > so bind them to newly added devices. > > Signed-off-by: Andrzej Pietrasiewicz <andrze...@samsung.com> > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> Reviewed-by: Inki Dae <inki@samsung.com> Thanks, Inki D

[GIT PULL] exynos-drm-fixes

2018-05-08 Thread Inki Dae
Hi Dave, Just fixup to pagefault issue of mixer driver I missed and a trivial cleanup to avoid duplicated drm_bridge_attach. Please kindly let me know if there is any problem Thanks, Inki Dae The following changes since commit a02cbe2e34c576cdc5e7846a3cd55245ab81db47: Merge branch

Re: [PATCH 0/2] drm/exynos/mixer: fixes for interlaced mode

2018-04-22 Thread Inki Dae
;>> This is reviewed/updated/tested Tobias's patch addressing page-faults >>>> in Video Processor in interlaced mode. Plus preliminary patch fixing Mixer >>>> interlaced mode. >>>> >>>> Regards >>>> Andrzej >>> Gentl

[GIT PULL] exynos-drm-fixes

2018-04-20 Thread Inki Dae
Hi Dave, Just cleanup by removing Exynos specific framebuffer structure and relevant two callback functions. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 97130968839a2928869a2d25500b5855017aac7d: Merge tag 'drm-amdkfd-fixes

Re: [PATCH 16/24] drm/exynos: Move GEM BOs to drm_framebuffer

2018-04-13 Thread Inki Dae
reuse those. Looks good and I will apply it including other two patches - 17 and 18 - after test. Thanks, Inki Dae > > Signed-off-by: Daniel Stone <dani...@collabora.com> > Cc: Inki Dae <inki@samsung.com> > Cc: Joonyoung Shim <jy0922.s...@samsung.com> > Cc

Re: [PATCH 06/13] drm/exynos: Stop updating plane->crtc

2018-04-05 Thread Inki Dae
2018년 04월 06일 01:45에 Daniel Vetter 이(가) 쓴 글: > On Thu, Apr 05, 2018 at 06:13:53PM +0300, Ville Syrjala wrote: >> From: Ville Syrjälä <ville.syrj...@linux.intel.com> >> >> We want to get rid of plane->crtc on atomic drivers. Stop setting it. >> >>

Re: [PATCH v5 2/6] drm/exynos: Let core take care of normalizing the zpos

2018-03-23 Thread Inki Dae
2018년 03월 21일 19:20에 Peter Ujfalusi 이(가) 쓴 글: > Instead of re-implementing the drm_atomic_helper_check() locally with just > adding drm_atomic_normalize_zpos() into it, set the > drm_mode_config->normalize_zpos. > > Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com&

[RESEND PATCH libdrm] tests: fix memory leak issue

2018-03-19 Thread Inki Dae
. Signed-off-by: Inki Dae <inki@samsung.com> --- tests/kms/libkms-test-device.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/kms/libkms-test-device.c b/tests/kms/libkms-test-device.c index 53c7349..042ae05 100644 --- a/tests/kms/libkms-test-device.c +++ b

[PATCH libdrm] tests: fix memory leak issue

2018-03-19 Thread Inki Dae
Fixed memory leak issue to drmModeRes object. This object was allocated by drmModeGetResources function but not freed when device->screens failed. So this patch frees the drmModeRes object when device->screens failed by calling drmModeFreeResources function. Signed-off-by: Inki Dae

[GIT PULL] exynos-drm-fixes

2018-03-18 Thread Inki Dae
Hi Dave, Just adding a missed description, '#sound-dai-cells', which is a device tree propery of hdmi device node that Exynos SoC device tree files have already. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit

Re: [PATCH v2] dt-bindings: exynos: Document #sound-dai-cells property of the HDMI node

2018-03-11 Thread Inki Dae
/exynos_hdmi.txt | 1 + >> 1 file changed, 1 insertion(+) > > Reviewed-by: Rob Herring <r...@kernel.org> Applied. Thanks, Inki Dae > > > > ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] dt-bindings: exynos: Document #sound-dai-cells property of the HDMI node

2018-03-08 Thread Inki Dae
Hi Sylwester, 2018년 03월 08일 20:22에 Sylwester Nawrocki 이(가) 쓴 글: > Hi Inki, > > Cc: alsa-de...@alsa-project.org > > On 03/08/2018 09:15 AM, Inki Dae wrote: >> By the way, it seems 'sound-dai-cells' property never affect >> Exynos4210/4212> 5420/5433. It seems th

  1   2   3   4   5   6   7   8   9   10   >