Re: [Intel-gfx] [PATCH v2] drm: Fire off KMS hotplug events if probe detect says the connector is connected

2019-04-18 Thread Jani Nikula
> + if (old_status != connector->status || > + connector->status == connector_status_connected) > changed = true; > } > drm_connector_list_iter_end(_iter); -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm: remove redundant 'default n' from Kconfig

2019-04-12 Thread Jani Nikula
u/drm/exynos/Kconfig |2 -- > drivers/gpu/drm/i915/Kconfig |3 --- > drivers/gpu/drm/i915/Kconfig.debug | 13 - For i915, Acked-by: Jani Nikula and can be merged through whichever tree you like. > drivers/gpu/drm/msm/Kconfig |2 -- >

Re: [PATCH drm-tip] rerere-cache: Fix drm/drm-next merge conflict resolution

2019-04-12 Thread Jani Nikula
508,6 @@ void drm_dev_unplug(struct drm_device *dev) > synchronize_srcu(_unplug_srcu); > > drm_dev_unregister(dev); > - drm_dev_put(dev); > } > EXPORT_SYMBOL(drm_dev_unplug); -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/4] drm/i915/dsi: Fix pipe_bpp for handling for 6 bpc pixel-formats

2019-04-05 Thread Jani Nikula
{ > - DRM_ERROR("Invalid BPP(0)\n"); > - return 0; > - } > + int bpp = mipi_dsi_pixel_format_to_bpp(intel_dsi->pixel_format); > > config->dsi_pll.ctrl = I915_READ(BXT_DSI_PLL_CTL); > > @@ -348,10 +332,7 @@

Re: [Intel-gfx] [PATCH] drm/i915: Fix context IDs not released on driver hot unbind

2019-04-04 Thread Jani Nikula
gt; > > used to be. The panic is entirely correct, we should not be >> > > > unloading >> > > > the module before those dangling pointers have been made safe. >> > > > >> > > > This is papering over the symptom.

Re: [Intel-gfx] linux-next: Tree for Mar 29 (i915, no ACPI)

2019-04-02 Thread Jani Nikula
build/kconfig-language.txt "In general use select only for non-visible symbols (no prompts anywhere) and for symbols with no dependencies." -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PULL] drm-intel-fixes

2019-03-28 Thread Jani Nikula
On Thu, 28 Mar 2019, Jani Nikula wrote: > Hi Dave and Daniel, a fairly normal fixes pull. > > drm-intel-fixes-2019-03-28: > drm/i915 fixes for v5.2-rc3: > - fix mmap range checks > - fix gvt ppgtt mm LRU list access races > - fix selftest error pointer check > - fix

Re: [PATCH v2] gpu:drm: Remove duplicate headers

2019-03-28 Thread Jani Nikula
dge { >> > diff --git a/drivers/gpu/drm/i915/intel_display.c >> > b/drivers/gpu/drm/i915/intel_display.c >> > index 1166342..7956e89 100644 >> > --- a/drivers/gpu/drm/i915/intel_display.c >> > +++ b/drivers/gpu/drm/i915/intel_display.c >> > @@ -46

[PULL] drm-intel-fixes

2019-03-28 Thread Jani Nikula
++-- drivers/gpu/drm/i915/selftests/i915_gem_evict.c | 2 +- 8 files changed, 41 insertions(+), 14 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman

Re: [PATCH 06/16] drm/i915/fbdev: Move intel_fb_initial_config() to fbdev helper

2019-03-27 Thread Jani Nikula
er intel_modeset_init(), in time for the use here. > Suggested-by: Daniel Vetter > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: intel-...@lists.freedesktop.org > Signed-off-by: Noralf Trønnes Reviewed-by: Jani Nikula and Acked-by: Jani Nikula for merging vi

Re: [PATCH libdrm] intel: sync i915_pciids.h with kernel

2019-03-25 Thread Jani Nikula
_AML_CFL_GT2_IDS(info) >> +INTEL_AML_CFL_GT2_IDS(info), \ >> +INTEL_CML_GT1_IDS(info), \ >> +INTEL_CML_GT2_IDS(info) >> >> /* CNL */ >> #define INTEL_CNL_IDS(info) \ >> @@ -469,6 +495,7 @@ >>

Re: [PATCH] drm/edid: Remove defunct EDID_QUIRK_FIRST_DETAILED_PREFERRED

2019-03-22 Thread Jani Nikula
w_bug.cgi?id=284231 (got the > reference from xf86EdidModes.c) > * Peacock Ergovision 19 (only in xf86EdidModes.c) > https://bugzilla.redhat.com/show_bug.cgi?id=492359 > * Philips 107p5 CRT > "Reported on xorg@ with pastebin", didn't find the mail(s) > > Cc

Re: [RFC] drm/i915: adding state checker for gamma lut values

2019-03-20 Thread Jani Nikula
int i; >>> + >>> + sw_lut_size = drm_color_lut_size(blob1); >>> + hw_lut_size = drm_color_lut_size(blob2); >>> + >>> + if (sw_lut_size != hw_lut_size) { >>> + DRM_DEBUG_KMS("Invalid LUT size; got %d, expected %d\n", >

Re: [PATCH] drm/udl: Refactor edid retreiving in UDL driver

2019-03-15 Thread Jani Nikula
there's a v2 earlier today, but I didn't have the time to check what changed, there's no changelog. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [RFC] drm/i915: adding state checker for gamma lut values

2019-03-15 Thread Jani Nikula
ompare_blob(current_config->name, pipe_config->name)) { \ > + pipe_config_err(adjust, __stringify(name), \ > + "hw_state doesn't match sw_state\n"); \ > + ret = false; \ > + } \ > +} while (0) > +

Re: [PATCH] drm/udl: Refactor edid retreiving in UDL driver

2019-03-14 Thread Jani Nikula
On Wed, 13 Mar 2019, Robert Tarasov wrote: > On Wed, Mar 13, 2019 at 2:26 AM Jani Nikula > wrote: > read_buff = kmalloc(2, GFP_KERNEL); >> >> A follow-up cleanup might be to switch to using "u8 read_buff[2];" >> instead of kmallocing it. >> >> I

Re: [PATCH] drm/i915/ddi: Fix default eDP detection on port A

2019-03-13 Thread Jani Nikula
On Thu, 07 Mar 2019, Jani Nikula wrote: > On Thu, 07 Mar 2019, Thomas Preston wrote: >> Would you like me to resubmit with the suggested changes? > > Nah, we can tweak the commit message while applying. Pushed to dinq, thanks for the patch. BR, Jani. -- Jani Nikula, In

Re: [PATCH] drm: Format-declare struct drm_format_info in drm_framebuffer.h

2019-03-13 Thread Jani Nikula
ixed, Reviewed-by: Jani Nikula > --- > include/drm/drm_framebuffer.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/drm/drm_framebuffer.h b/include/drm/drm_framebuffer.h > index f0b34c977ec5..c23016748e3f 100644 > --- a/include/drm/drm_framebuffer.h &

Re: [PATCH] drm/udl: Refactor edid retreiving in UDL driver

2019-03-13 Thread Jani Nikula
n't claim to understand how the usb stuff works, but otherwise the patch looks good to me. Nice refactoring! Reviewed-by: Jani Nikula > if (!read_buff) > - return false; > + return -1; > > - for (i = 0; i < EDID_LENGTH; i++) { > - i

Re: [PATCH] MAINTAINERS: Add an entry for the vboxvideo driver

2019-03-13 Thread Jani Nikula
On Wed, 13 Mar 2019, Hans de Goede wrote: > Hi, > > On 3/13/19 9:26 AM, Jani Nikula wrote: >> On Mon, 11 Mar 2019, Hans de Goede wrote: >>> Add a MAINTAINERS entry for the vboxvideo driver, now that it has been >>> moved out of staging. >>> >>>

Re: [PATCH] MAINTAINERS: Add an entry for the vboxvideo driver

2019-03-13 Thread Jani Nikula
On Wed, 13 Mar 2019, Daniel Vetter wrote: > On Wed, Mar 13, 2019 at 10:26:37AM +0200, Jani Nikula wrote: >> On Mon, 11 Mar 2019, Hans de Goede wrote: >> > Add a MAINTAINERS entry for the vboxvideo driver, now that it has been >> > moved out of staging. >&g

Re: [PATCH] MAINTAINERS: Add an entry for the vboxvideo driver

2019-03-13 Thread Jani Nikula
like *all* DRM drivers to have those.) BR, Jani. > + > DRM DRIVER FOR VMWARE VIRTUAL GPU > M: "VMware Graphics" > M: Thomas Hellstrom -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: DRM-based Oops viewer

2019-03-12 Thread Jani Nikula
On Mon, 11 Mar 2019, "Ahmed S. Darwish" wrote: > Hello Jani, > > On Mon, Mar 11, 2019 at 11:04:19AM +0200, Jani Nikula wrote: >> On Sun, 10 Mar 2019, "Ahmed S. Darwish" wrote: >> Please first better define what you want to achieve. >> > > Oh

Re: [PATCH] drm/udl: Bugfix in EDID reading routine

2019-03-12 Thread Jani Nikula
On Mon, 11 Mar 2019, Robert Tarasov wrote: > Yes, you're right. Will prepare another patch which will use > drm_do_get_edid() Oh, you might want to have this patch first with cc: stable and all that, and do the cleanup afterwards. BR, Jani. > > On Mon, Mar 11, 2019 at 4:33 AM

Re: INFO: rcu detected stall in sys_sendfile64 (2)

2019-03-12 Thread Jani Nikula
ompiler bugs, even - playing with __LINE__ is all it would > take), but the odds that it's _not_ a false positive are very low. If it's not a false positive, it's bound to be good source material for IOCCC. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/udl: Bugfix in EDID reading routine

2019-03-11 Thread Jani Nikula
; ++i) { > + for (i = 1; i <= extensions; ++i) { > if (udl_get_edid_block(udl, i, buff_ptr)) { > buff_ptr += EDID_LENGTH; > } else { Ugh. Why doesn't udl use drm_do_

Re: DRM-based Oops viewer

2019-03-11 Thread Jani Nikula
> > [6] linux/drivers/gpu/drm/i915/i915_drv.c::i915_kick_out_firmware_fb() > linux/drivers/gpu/drm/radeon/radeon_drv.c::radeon_pci_probe() > > [7] > https://docs.microsoft.com/en-us/windows-hardware/drivers/storage/restrictions-on-miniport-drivers-that-manage-the-boot-drive &g

Re: [PATCH v8 1/2] drm/i915: Introduce async plane update to i915

2019-03-08 Thread Jani Nikula
On Fri, 08 Mar 2019, Helen Koike wrote: > Hi Jani, > > On 3/8/19 6:55 AM, Jani Nikula wrote: >> >> Please send drm/i915 patches also to intel-...@lists.freedesktop.org to >> trigger CI on the patches among other things. > > Sure! Is there a way to tell th

Re: [PATCH v8 1/2] drm/i915: Introduce async plane update to i915

2019-03-08 Thread Jani Nikula
ntel_plane_atomic_async_update, > }; > > /** > diff --git a/drivers/gpu/drm/i915/intel_display.c > b/drivers/gpu/drm/i915/intel_display.c > index 415d8968f2c5..244e1c94277d 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c &g

Re: [PATCH] drm/i915/ddi: Fix default eDP detection on port A

2019-03-07 Thread Jani Nikula
On Thu, 07 Mar 2019, Thomas Preston wrote: > Would you like me to resubmit with the suggested changes? Nah, we can tweak the commit message while applying. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list

Re: [PATCH] drm/i915/ddi: Fix default eDP detection on port A

2019-03-07 Thread Jani Nikula
On Thu, 07 Mar 2019, Thomas Preston wrote: > Hi, > Thanks for looking at this. > > On 07/03/2019 08:18, Jani Nikula wrote: >> >> The subject should probably have "drm/i915/bios" or "drm/i915/vbt". >> > > Noted > >> On Wed, 06

Re: Is it possible to reset graphics controller on reboot in a framebuffer driver?

2019-03-07 Thread Jani Nikula
notifiers to achieve the exact same goal. See drivers/video/fbdev/aty/atyfb_base.c, look for register_reboot_notifier(). HTH, Jani. -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/i915/ddi: Fix default eDP detection on port A

2019-03-07 Thread Jani Nikula
at have a non-eDP output on port A. I guess it's a risk we have to take, and handle the fallout later. Acked-by: Jani Nikula > Fixes: commit a98d9c1d7e9b ("drm/i915/ddi: Rely on VBT DDI port info for eDP > detection") The Fixes: format does *not* include "commi

Re: [PATCH 2/7] drm/edid: Allow to ignore the audio EDID data

2019-03-05 Thread Jani Nikula
On Tue, 05 Mar 2019, Maxime Ripard wrote: > On Mon, Mar 04, 2019 at 05:47:09PM +0200, Jani Nikula wrote: >> On Mon, 04 Mar 2019, Maxime Ripard wrote: >> > In some cases, in order to accomodate with displays with poor EDIDs, we >> > need to ignore that the monitor alled

Re: [PATCH 3/7] drm/edid: Allow to ignore the HDMI monitor mode

2019-03-04 Thread Jani Nikula
s HDMI > * @edid: monitor EDID information > @@ -4170,6 +4175,9 @@ bool drm_detect_hdmi_monitor(struct edid *edid) > int i; > int start_offset, end_offset; > > + if (force_dvi_monitor) > + return false; > + > edid_ext = drm_find_cea_extension(edid); >

Re: [PATCH 2/7] drm/edid: Allow to ignore the audio EDID data

2019-03-04 Thread Jani Nikula
> * @edid: EDID block to scan > @@ -4209,6 +4214,9 @@ bool drm_detect_monitor_audio(struct edid *edid) > bool has_audio = false; > int start_offset, end_offset; > > + if (ignore_edid_audio) > + goto end; > + > edid_ext = drm_find_cea_exten

Re: [PATCH RESEND] drm: panel-orientation-quirks: Add quirk for Lenovo Ideapad D330

2019-03-01 Thread Jani Nikula
DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"), >> + DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad >> D330-10IGM"), >> + }, >> + .driver_data = (void *)_rightside_up, >> }, {/

Re: [PATCH 0/3] Propagate DP-over-Type-C hotplug events from Type-C subsys to drm-drivers

2019-02-27 Thread Jani Nikula
orientation, there's a worst case of sixth attempt of finding out there's just one lane in a certain orientation. Couple that with link rate selection (did it not work because too high link rate or because the lanes are just not there?) we get pretty confused about what we should try. BR, Jani. -- Ja

Re: [Intel-gfx] [RFC PATCH 00/42] Introduce memory region concept (including device local memory)

2019-02-26 Thread Jani Nikula
en when it really has slowed us down. So while you may have fair points about a specific case, and again I'll let Joonas address the specific case, I'll have to ask you to please not generalize that to the whole driver. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center __

Re: [PATCH v2 2/3] drm/dsc: Add native 420 and 422 support to compute_rc_params

2019-02-25 Thread Jani Nikula
le422 is renamed to simple_422 to avoid > confusion > > Acked-by: Jani Nikula This was really for patch 1/3 where it actually matters. BR, Jani. > Reviewed-by: Manasi Navare > Reviewed-by: Harry Wentland > Signed-off-by: David Francis > --- > drivers/gpu/drm/drm_dsc.c

Re: [PATCH RESEND 1/2] drm: panel-orientation-quirks: Get rid of superfluous (void *) casting

2019-02-22 Thread Jani Nikula
apad Miix 320 */ >145.matches = { >146 DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), >147 DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"), >148 DMI_EXACT_MATCH(DMI_PRODUCT_V

Re: [PATCH v2 1/2] drm: move i915_kick_out_vgacon to drm_fb_helper

2019-02-21 Thread Jani Nikula
On Thu, 21 Feb 2019, Gerd Hoffmann wrote: > On Thu, Feb 21, 2019 at 03:08:39PM +0200, Jani Nikula wrote: >> On Thu, 21 Feb 2019, Gerd Hoffmann wrote: >> > It'll be useful for other drivers too, so move it to drm_fb_helper.c >> > (and rename it of course). Also add

Re: [PATCH v2 1/2] drm: move i915_kick_out_vgacon to drm_fb_helper

2019-02-21 Thread Jani Nikula
> - ret = 0; > - } > - console_unlock(); > - > - return ret; > -} > -#endif > - > static void intel_init_dpio(struct drm_i915_private *dev_priv) > { > /* > @@ -1420,7 +1387,7 @@ static int i915_driver_init_hw(struct drm_i915_pri

[PULL] drm-intel-fixes

2019-02-20 Thread Jani Nikula
Chris Wilson (1): drm/i915/fbdev: Actually configure untiled displays drivers/gpu/drm/i915/intel_fbdev.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center

Re: [PATCH 1/2] drm: panel-orientation-quirks: Get rid of superfluous (void *) casting

2019-02-18 Thread Jani Nikula
On Sat, 16 Feb 2019, David Santamaría Rogado wrote: > From: howl > > The (void *) casting in the driver_data variable assignment is superfluous. > Spotted by Jani Nikula. > > Signed-off-by: David Santamaría Rogado Reviewed-by: Jani Nikula > -

Re: [Intel-gfx] [PATCH 0/3] Make DRM DSC helpers more generally usable

2019-02-14 Thread Jani Nikula via dri-devel
acking function > to operate only on the packing struct, to allow for drivers with > their own SDP struct headers Acked-by: Jani Nikula as long as you've ironed out the details with Manasi's review. Also okay to merge via drm-misc. Ideally, please rebase on drm-tip and continue to Cc: inte

Re: Fwd: [PATCH] drm: panel-orientation-quirks: Get rid of superfluous (void *) casting

2019-02-14 Thread Jani Nikula via dri-devel
> It's usually to put this kind of comment below the --- line... > >> The (void *) casting in the driver_data variable assignment is superfluous. >> Spotted by Jani Nikula. Please either make that Suggested-by: Jani Nikula or leave out completely. >> >> Signed-of

[PULL] drm-intel-fixes

2019-02-13 Thread Jani Nikula via dri-devel
Swarup (1): drm/i915/cnl: Fix CNL macros for Voltage Swing programming Clint Taylor (1): drm/i915/icl: combo port vswing programming changes per BSPEC Jani Nikula (2): drm/i915/opregion: fix version check drm/i915/opregion: rvda is relative from opregion base in opregion 2.1

Re: [PATCH RESEND] drm: panel-orientation-quirks: Add quirk for Lenovo Ideapad D330

2019-02-12 Thread Jani Nikula via dri-devel
er_data = _rightside_up, > }, { /* Lenovo Ideapad Miix 320 */ > .matches = { >DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), >DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"), >DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"), > },

Re: [PATCH RESEND] drm: panel-orientation-quirks: Add quirk for Lenovo Ideapad D330

2019-02-12 Thread Jani Nikula via dri-devel
S LTH17 */ > .matches = { >DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"), > ___ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PULL] drm-intel-fixes

2019-02-06 Thread Jani Nikula
DPLL state left over by broken SNB BIOSen drivers/gpu/drm/i915/intel_ddi.c | 2 +- drivers/gpu/drm/i915/intel_display.c | 50 +++- drivers/gpu/drm/i915/intel_sprite.c | 2 +- 3 files changed, 46 insertions(+), 8 deletions(-) -- Jani Nikula, Intel Open

Re: [PULL] drm-intel-next

2019-02-05 Thread Jani Nikula
| 718 >> > > + >> > > drivers/gpu/drm/i915/intel_workarounds.c | 70 +- >> > > drivers/gpu/drm/i915/selftests/i915_gem_evict.c| 7 +- >> > > drivers/gpu/drm/i915/selftes

Re: [PATCH v1 0/19] drm/panel: drmP.h removal and DRM_DEV*

2019-02-01 Thread Jani Nikula
On Fri, 01 Feb 2019, Andrzej Hajda wrote: > On 01.02.2019 11:30, Jani Nikula wrote: >> On Fri, 01 Feb 2019, Sam Ravnborg wrote: >>> Hi Thierry. >>> >>>> I personally like the DRM_DEV_* variants better because of the >>>> additional inf

Re: [PATCH v1 0/19] drm/panel: drmP.h removal and DRM_DEV*

2019-02-01 Thread Jani Nikula
truct device) > > DRM_DRM*, or DRM_DDEV* or ... But you get the idea. > > But this is not where we are today. > > Shall I redo the patch-set so we go back to dev_*() in probe() / remove()? > > Sam > _____

Re: [Intel-gfx] linux-next: build failure after merge of the drm-intel-fixes tree

2019-01-30 Thread Jani Nikula
t; drm-intel-fixes. IS_GEN(dev_priv, 6) needs to be converted to > IS_GEN6(dev_priv). > > Lucas De Marchi > >> >> I have reverted that commit for today. Dropped the commit from drm-intel-fixes. Somehow I had managed to screw up my kernel config in a way that avoided the build

Re: [PATCH] drm/doc: Make igts for cross-driver stuff strongly suggested

2019-01-28 Thread Jani Nikula
On Mon, 28 Jan 2019, Daniel Vetter wrote: > Compared to the RFC[1] no changes to the patch itself, but igt moved > forward a lot: This is no longer compatible with the v2 changelog below. ;) I'm biased so this doesn't carry so much value, but here goes anyway, Acked-by: Jani

Re: [PATCH v6 2/5] drm/i915: prepare for drmP.h removal from drm_modeset_helper.h

2019-01-28 Thread Jani Nikula
les touched the lists of include files was grouped > and sorted. > > Build tested on x86 and arm allmodconfig / allyesconfig. > > Signed-off-by: Sam Ravnborg > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: David Airlie > Cc: Daniel Vetter > Cc

[PULL] drm-intel-fixes

2019-01-24 Thread Jani Nikula
i915/intel_lrc.c | 4 2 files changed, 10 insertions(+), 5 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: linux-next: Fixes tag needs some work in the drm-intel-fixes tree

2019-01-24 Thread Jani Nikula
ror handling for > prepare_execlist_workload") > > has these problem(s): > > - Subject does not match target commit subject > > Just some whitespace. Thanks for the report. The commit being referenced seems to be the right one, though, so I don't think I'm going to force pu

RE: [Intel-gfx] [PATCH 1/3] treewide: Lift switch variables out of switches

2019-01-23 Thread Jani Nikula
On Wed, 23 Jan 2019, Edwin Zimmerman wrote: > On Wed, 23 Jan 2019, Jani Nikula wrote: >> On Wed, 23 Jan 2019, Greg KH wrote: >> > On Wed, Jan 23, 2019 at 03:03:47AM -0800, Kees Cook wrote: >> >> Variables declared in a switch statement before any case statements &

Re: [Intel-gfx] [PATCH 1/3] treewide: Lift switch variables out of switches

2019-01-23 Thread Jani Nikula
On Wed, 23 Jan 2019, Jani Nikula wrote: > On Wed, 23 Jan 2019, Greg KH wrote: >> On Wed, Jan 23, 2019 at 03:03:47AM -0800, Kees Cook wrote: >>> Variables declared in a switch statement before any case statements >>> cannot be initialized, so move all instances out

Re: [Intel-gfx] [PATCH 1/3] treewide: Lift switch variables out of switches

2019-01-23 Thread Jani Nikula
ase 0: /* ... */ } but can have e.g.: switch (i) { case 0: { int j = 0; /* ... */ } } I think Kees' approach of moving such variable declarations to the enclosing block scope

Re: [PATCH] video/fbdev: refactor video= cmdline parsing

2019-01-23 Thread Jani Nikula
On Wed, 23 Jan 2019, Daniel Vetter wrote: > On Wed, Jan 23, 2019 at 11:38:17AM +0200, Jani Nikula wrote: >> Make the video_setup() function slightly easier to read by removing the >> repeated checks for !global. Remove the misleading return value comment >> while at it

Re: [igt-dev] [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-23 Thread Jani Nikula
ts, we could maintain similar lists for different needs. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [igt-dev] [PATCH] drm/doc: Make igts for cross-driver stuff mandatory

2019-01-23 Thread Jani Nikula
tainer/community discretion no matter what. Judging by the discussion, CRC based tests don't currently meet the driver-agnostic requirement. Playing devil's advocate, you could argue any new APIs couldn't be tested with CRC either, even if it were the most reasonable approach for i915. BR, Jani. -

[PATCH] video/fbdev: refactor video= cmdline parsing

2019-01-23 Thread Jani Nikula
easier. Signed-off-by: Jani Nikula --- drivers/video/fbdev/core/fb_cmdline.c | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/drivers/video/fbdev/core/fb_cmdline.c b/drivers/video/fbdev/core/fb_cmdline.c index 39509ccd92f1..3b5bd666b952 100644

Re: [Intel-gfx] [PATCH] drm/dp: use DRM_DEBUG_DP() instead of drm_dbg for logging

2019-01-22 Thread Jani Nikula
On Mon, 21 Jan 2019, Ville Syrjälä wrote: > On Mon, Jan 21, 2019 at 01:27:58PM +0200, Jani Nikula wrote: >> We have a wrapper for a reason. >> >> Signed-off-by: Jani Nikula > > Reviewed-by: Ville Syrjälä Thanks, pushed to drm-misc-next. BR, Jani. > >> ---

[PATCH] drm/dp: use DRM_DEBUG_DP() instead of drm_dbg for logging

2019-01-21 Thread Jani Nikula
We have a wrapper for a reason. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_dp_helper.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 26835d174939..4def0bface85 100644 --- a/drivers/gpu

Re: [PATCH 2/2] drm/msm: Use DRM_DEV_INFO_RATELIMITED for shrinker messages

2019-01-21 Thread Jani Nikula
BR, Jani. > > return freed; > } > @@ -134,7 +134,7 @@ msm_gem_shrinker_vmap(struct notifier_block *nb, unsigned > long event, void *ptr) > *(unsigned long *)ptr += unmapped; > > if (unmapped > 0) > - pr_info_ratelimited("Purgin

[PULL] drm-intel-fixes

2019-01-17 Thread Jani Nikula
:51 +0200) drm/i915/gvt fixes for v5.0-rc3 Colin Xu (1): drm/i915/gvt: Allow F_CMD_ACCESS on mmio 0x21f0 Hang Yuan (1): drm/i915/gvt: free VFIO region space in vgpu detach Ja

Re: [PATCH v2] drm/i915: Pass down rc in intel_encoder->compute_config()

2019-01-15 Thread Jani Nikula
@@ -869,7 +869,7 @@ intel_tv_get_config(struct intel_encoder *encoder, > pipe_config->base.adjusted_mode.crtc_clock = pipe_config->port_clock; > } > > -static bool > +static int > intel_tv_compute_config(struct intel_encoder *encoder, >

Re: [PATCH] drm: Split out drm_probe_helper.h

2019-01-15 Thread Jani Nikula
; expect. > > v3: Rebase on top of atomic bochs. > > Cc: Sam Ravnborg > Cc: Jani Nikula > Cc: Laurent Pinchart > Acked-by: Rodrigo Vivi (v2) > Acked-by: Benjamin Gaignard (v2) > Signed-off-by: Daniel Vetter > Cc: linux-arm-ker...@lists.infradead.org > Cc: virt

Re: Clang warning in drivers/gpu/drm/i915/i915_debugfs.c

2019-01-15 Thread Jani Nikula
lly would send a patch myself but since I'm not > familiar with this code, I'd rather not shoot in the dark :) especially > since it's for a trivial logging statement. Fixed by fed85691b408 ("drm/i915: Fix the static code analysis warning in debugfs"), thanks for the report &

Re: [RFC AFBC 03/12] drm/afbc: Add AFBC modifier usage documentation

2019-01-14 Thread Jani Nikula
amespacing it that way for the reason mentioned above - it > does/will/should apply to more than just the gpu/drm/arm tree. Fair enough. It's not like the name is part of the ABI, so I guess let's go with this, and we can rename later if we come up with a better name. BR, Jani. -- Jani Nikula, Intel Op

Re: [RFC AFBC 03/12] drm/afbc: Add AFBC modifier usage documentation

2019-01-14 Thread Jani Nikula
; > + * - DRM_FORMAT_YUV420_10BIT >> > + - 10-bit per component YCbCr 420, single plane >> > + - Plane 0: 3 components >> > + * Component 0: Y(10) >> > + * Component 1: Cb(10, 2x2 subsampled) >> > + * Com

[PULL] drm-intel-fixes

2019-01-11 Thread Jani Nikula
all engines Jani Nikula (1): Merge tag 'gvt-fixes-2019-01-09' of https://github.com/intel/gvt-linux into drm-intel-fixes José Roberto de Souza (2): drm/i915: Disable PSR in Apple panels drm: Fix documentation generation for DP_DPCD_QUIRK_NO_PSR Zhenyu Wang (1): drm/i915

Re: [RFC] drm: add DRM_DEBUG_CORE() and friends and use them

2019-01-10 Thread Jani Nikula
On Thu, 27 Dec 2018, Jani Nikula wrote: > DRM_DEBUG() was intended to be used by the drm core code only, but we > weren't careful. Today, the driver usage of DRM_DEBUG() trumps drm core > usage about 10:1. It's easier to swith the core over to a new > DRM_DEBUG_CORE() macro than the

[PATCH] drm/i915: drop all drmP.h includes

2019-01-08 Thread Jani Nikula
Needs just a few additional includes here and there. Cc: Sam Ravnborg Cc: Daniel Vetter Cc: Laurent Pinchart Acked-by: Daniel Vetter Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/dvo.h | 1 - drivers/gpu/drm/i915/i915_drv.c| 1 - drivers/gpu/drm/i915

[PULL] topic/drmp-cleanup for drm-misc-next and drm-intel-next-queued

2019-01-02 Thread Jani Nikula
2 11:38:08 +0200) Make some drm headers self-contained with includes and forward declarations ---- Jani Nikula (5): drm: un-inline drm_legacy_findmap() drm: inc

Re: [PATCH 0/6] drm/i915: drmP.h include removal w/ drm prep work

2019-01-02 Thread Jani Nikula
On Wed, 02 Jan 2019, Laurent Pinchart wrote: > Hi Jani, > > On Wednesday, 2 January 2019 09:47:58 EET Jani Nikula wrote: >> On Fri, 28 Dec 2018, Jani Nikula wrote: >> > Thanks for all the reviews, pushed patches 1-5 to topic/drmp-cleanup >> > with $(git merge-

Re: [PATCH 0/6] drm/i915: drmP.h include removal w/ drm prep work

2019-01-01 Thread Jani Nikula
On Fri, 28 Dec 2018, Jani Nikula wrote: > Thanks for all the reviews, pushed patches 1-5 to topic/drmp-cleanup > with $(git merge-base drm-misc-next drm-intel-next-queued) as the > starting point. It's also included in drm-tip now. So I did this *before* I got the review feedback fro

Re: [PATCH 0/6] drm/i915: drmP.h include removal w/ drm prep work

2018-12-28 Thread Jani Nikula
On Thu, 27 Dec 2018, Daniel Vetter wrote: > On Thu, Dec 27, 2018 at 02:56:35PM +0200, Jani Nikula wrote: >> First make some drm headers self-contained, removing the implicit >> dependency on a previous drmP.h include. Then remove all drmP.h includes >> from drm/i915. >

Re: [PATCH 1/6] drm: include drm_device.h from drm_legacy.h

2018-12-28 Thread Jani Nikula
On Fri, 28 Dec 2018, Daniel Vetter wrote: > On Fri, Dec 28, 2018 at 10:23:00AM +0200, Jani Nikula wrote: >> On Thu, 27 Dec 2018, Daniel Vetter wrote: >> > On Thu, Dec 27, 2018 at 05:04:20PM +0100, Daniel Vetter wrote: >> >> On Thu, Dec 27, 2018 at 02:56

[PATCH v2] drm: un-inline drm_legacy_findmap()

2018-12-28 Thread Jani Nikula
Also include drm_hashtab.h and add struct drm_device forward declaration in drm_legacy.h to make it more self-contained. Make it easier to drop drmP.h includes. v2: avoid including drm_device.h by un-inlining (Daniel) Cc: Sam Ravnborg Cc: Daniel Vetter Cc: Laurent Pinchart Signed-off-by: Jani

Re: [PATCH] drm/i915: avoid division by zero on skl_calc_wrpll_link

2018-12-28 Thread Jani Nikula
dco_freq += (((cfgcr1_val & DPLL_CFGCR1_DCO_FRACTION_MASK) >> 9) * 24 * > 1000) / 0x8000; > > + if (WARN_ON(p0 == 0 || p1 == 0 || p2 == 0)) > + return 0; > + > return dco_freq / (p0 * p1 * p2 * 5); > } -- Jani Nikula, Intel O

[PATCH v2] drm: forward declare struct drm_file in drm_syncobj.h

2018-12-28 Thread Jani Nikula
Make it easier to drop drmP.h includes. Switch from "" to <> includes while at it. v2: forward declare instead of including drm_file.h (Daniel) Cc: Sam Ravnborg Cc: Daniel Vetter Cc: Laurent Pinchart Reviewed-by: Daniel Vetter Signed-off-by: Jani Nikula --- include/drm/d

Re: [PATCH 1/6] drm: include drm_device.h from drm_legacy.h

2018-12-28 Thread Jani Nikula
On Thu, 27 Dec 2018, Daniel Vetter wrote: > On Thu, Dec 27, 2018 at 05:04:20PM +0100, Daniel Vetter wrote: >> On Thu, Dec 27, 2018 at 02:56:36PM +0200, Jani Nikula wrote: >> > Make it easier to drop drmP.h includes. >> > >> > Cc: Sam Ravnborg >> >

Re: [PATCH] drm/intel_dsi_vbt: Remove duplicate header

2018-12-27 Thread Jani Nikula
ude > #include > #include > -#include > #include "i915_drv.h" > #include "intel_drv.h" > #include "intel_dsi.h" -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 6/6] drm/i915: drop all drmP.h includes

2018-12-27 Thread Jani Nikula
be. Turns out even isn't self-contained, it fails on do_div() for my config if isn't included some other route. Didn't dig deep, but by the looks of it this is not a new breakage (if you can call it that). BR, Jani. -- Jani Nikula, Intel Open Source Graphi

[RFC] drm: add DRM_DEBUG_CORE() and friends and use them

2018-12-27 Thread Jani Nikula
for DRM_DEV_DEBUG() and the ratelimited ones as well. Signed-off-by: Jani Nikula --- drivers/gpu/drm/ati_pcigart.c | 4 +- drivers/gpu/drm/drm_agpsupport.c | 6 +- drivers/gpu/drm/drm_auth.c| 4 +- drivers/gpu/drm/drm_bufs.c| 112 +++--- drivers/gpu

[PATCH 2/6] drm: include kernel.h and agp_backend.h from intel-gtt.h

2018-12-27 Thread Jani Nikula
Make it easier to drop drmP.h includes. Cc: Sam Ravnborg Cc: Daniel Vetter Cc: Laurent Pinchart Signed-off-by: Jani Nikula --- include/drm/intel-gtt.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/drm/intel-gtt.h b/include/drm/intel-gtt.h index 2324c84a25c0..71d81923e6b0

[PATCH 0/6] drm/i915: drmP.h include removal w/ drm prep work

2018-12-27 Thread Jani Nikula
this series self-contained. Should be easy enough to resolve. I'm fine with merging the first 5 through either drm-misc or drm-intel, but I'd rather merge the last one through drm-intel. BR, Jani. Cc: Sam Ravnborg Cc: Daniel Vetter Cc: Laurent Pinchart Jani Nikula (6): drm: include

[PATCH 6/6] drm/i915: drop all drmP.h includes

2018-12-27 Thread Jani Nikula
Needs just a few additional includes here and there. Cc: Sam Ravnborg Cc: Daniel Vetter Cc: Laurent Pinchart Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/dvo.h | 1 - drivers/gpu/drm/i915/i915_drv.c| 1 - drivers/gpu/drm/i915/i915_drv.h| 2

[PATCH 3/6] drm: include idr.h from drm_file.h

2018-12-27 Thread Jani Nikula
Make it easier to drop drmP.h includes. Cc: Sam Ravnborg Cc: Daniel Vetter Cc: Laurent Pinchart Signed-off-by: Jani Nikula --- include/drm/drm_file.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h index 84ac79219e4c..6710b612e2f6 100644

[PATCH 5/6] drm: include drm_file.h from drm_syncobj.h

2018-12-27 Thread Jani Nikula
Make it easier to drop drmP.h includes. Switch from "" to <> includes while at it. Cc: Sam Ravnborg Cc: Daniel Vetter Cc: Laurent Pinchart Signed-off-by: Jani Nikula --- include/drm/drm_syncobj.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/d

[PATCH 4/6] drm: include types.h from drm_hdcp.h

2018-12-27 Thread Jani Nikula
Make it easier to drop drmP.h includes. Cc: Sam Ravnborg Cc: Daniel Vetter Cc: Laurent Pinchart Signed-off-by: Jani Nikula --- include/drm/drm_hdcp.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/drm_hdcp.h b/include/drm/drm_hdcp.h index a6de09c5e47f..d6dfef8cff6a 100644

[PATCH 1/6] drm: include drm_device.h from drm_legacy.h

2018-12-27 Thread Jani Nikula
Make it easier to drop drmP.h includes. Cc: Sam Ravnborg Cc: Daniel Vetter Cc: Laurent Pinchart Signed-off-by: Jani Nikula --- include/drm/drm_legacy.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/drm_legacy.h b/include/drm/drm_legacy.h index 8fad66f88e4f..743d7e70c896

Re: [PATCH 0/6] drm/i915: drmP.h include removal w/ drm prep work

2018-12-27 Thread Jani Nikula
On Thu, 27 Dec 2018, Jani Nikula wrote: > First make some drm headers self-contained, removing the implicit > dependency on a previous drmP.h include. Then remove all drmP.h includes > from drm/i915. > > Inspired by Sam's series [1]. Theres a one line trivial conflict bet

[PULL] drm-intel-next-fixes

2018-12-26 Thread Jani Nikula
take "Interupts" -> "Interrupts" Jani Nikula (1): Merge tag 'gvt-next-2018-12-07' of https://github.com/intel/gvt-linux into drm-intel-next-fixes Peng Hao (1): drm/i915/gvt: fix a typo: "registeration" -> "registration". Xinyun Liu (1): drm/

RE: [Intel-gfx] [PATCH v9 10/39] drm/i915: Implement HDCP2.2 receiver authentication

2018-12-19 Thread Jani Nikula
, checkpatch is not the authority although we do send out >> automated checkpatch results. > > I believe it was Linus' call to not use bool in structs at all > https://lkml.org/lkml/2017/11/21/384 I don't care. That's a valid judgement in the context referenced, but the con

  1   2   3   4   5   6   7   8   9   10   >